From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net build: Correctly include nmnettestlib in the build
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69132
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49bd94a12440d8e3364b1bb5920d2e59ae95a8d0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Freeze version of python2-crypto in check-merged
......................................................................
Freeze version of python2-crypto in check-merged
Newer version of python2-crypto break python2-paramiko which is required
by Lago. This patch adds an EPEL snapshot that contains an older
version of python2-crypto and tries to enforce installing the older
version to make Lago work.
This patch also removes the link to EPEL in the *.repos file because
EPEL is provided natively by Standard-CI
Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M automation/check-merged.packages.el7
M automation/check-patch.repos.el7
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified; Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Freeze version of python2-crypto in check-merged
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/71756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: check-merged: give a significant name to lago_ovirt_http_pid
......................................................................
check-merged: give a significant name to lago_ovirt_http_pid
Change-Id: I2533b1a0580baa516614fd058897489d039ea0ab
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M automation/check-merged.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/71698/1
diff --git a/automation/check-merged.sh b/automation/check-merged.sh
index 32ef4a5..fd2350e 100755
--- a/automation/check-merged.sh
+++ b/automation/check-merged.sh
@@ -95,7 +95,7 @@
lago ovirt deploy
lago ovirt serve &
- PID=$!
+ local lago_ovirt_http_pid=$!
fake_ksm_in_vm
@@ -106,7 +106,7 @@
res="${PIPESTATUS[0]}"
[ "$res" -ne 0 ] && failed="$res"
- kill $PID
+ kill "$lago_ovirt_http_pid"
lago copy-from-vm \
"$VM_NAME" \
--
To view, visit https://gerrit.ovirt.org/71698
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2533b1a0580baa516614fd058897489d039ea0ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: do not use virt-prefixed logger for utilities
......................................................................
lib: do not use virt-prefixed logger for utilities
The @api.method code was born in the virt vertical,
but was later placed in the common area, hoping to be useful
for other verticals and used across the codebase.
However, it still incorrectly uses a virt-prefixed logger, and this
is conflicting with its stated goal: this is no more virt-specific code.
This patch replaces the 'virt' prefix with the 'vdsm' one.
Change-Id: I091fb7336db58aa38af5b01c33d6d9239afff6d4
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/common/api.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Francesco Romani: Verified
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/71637
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I091fb7336db58aa38af5b01c33d6d9239afff6d4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: do not use virt-prefixed logger for utilities
......................................................................
Patch Set 2: Code-Review+2 Continuous-Integration+1
betting on the Fedora mirror failure being transitional
--
To view, visit https://gerrit.ovirt.org/71637
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I091fb7336db58aa38af5b01c33d6d9239afff6d4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Freeze version of python2-crypto in check-merged
......................................................................
Patch Set 1: Code-Review+1
if yum `cat *packages.el7` works, I'm fine.
--
To view, visit https://gerrit.ovirt.org/71756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Freeze version of python2-crypto in check-merged
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/71756/1/automation/check-merged.packages.el7
File automation/check-merged.packages.el7:
Line 1: --exclude=python2-crypto-2.6.1-13*
we suggest developers to install `cat` of this file prior to developing vdsm. This patch breaks things for them.
Can we please this ugly hack somewhere else?
Line 2: autoconf
Line 3: automake
Line 4: git
Line 5: lago
--
To view, visit https://gerrit.ovirt.org/71756
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fb6fbc84297254c87bfc5aa2a67799ce2d0f0f0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes