Change in vdsm[master]: pylint: Rename arguments in configurator.configure
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Rename arguments in configurator.configure
......................................................................
pylint: Rename arguments in configurator.configure
We pass parameters when running configure we use _parse_args and return
already used variable name args which causes pylint to complain:
E:129,23: Instance of 'tuple' has no 'force' member (no-member)
Change-Id: Id7c0b362a87350162ad7838f658af7f9fcea3398
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/tool/configurator.py
1 file changed, 16 insertions(+), 16 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7c0b362a87350162ad7838f658af7f9fcea3398
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: pylint: Rename arguments in configurator.configure
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Rename arguments in configurator.configure
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7c0b362a87350162ad7838f658af7f9fcea3398
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: pylint: Add missing class attributes
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Add missing class attributes
......................................................................
pylint: Add missing class attributes
manifestClass and mountpoint are part of the StorageDomain interface,
but they were defined only in concrete sub classes. This make the code
harder to understand, and make pylint unhappy.
Change-Id: I8b16d038b72be8d6033ba5db2b28a5778dc095bf
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/sd.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75796
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b16d038b72be8d6033ba5db2b28a5778dc095bf
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: pylint: Add missing abstract findDomainPath
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Add missing abstract findDomainPath
......................................................................
pylint: Add missing abstract findDomainPath
pylint was complaining that findDomainPath was missing on
FileStoraeDomain. Add an abstract method in StorageDomain to make it
happy and make it easier to understand the storage domain interface.
Change-Id: Ie09bdbe6d942c79cc87ec7fe29c213a006573741
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/sd.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75795
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie09bdbe6d942c79cc87ec7fe29c213a006573741
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: pylint: Add missing abstract methods
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Add missing abstract methods
......................................................................
pylint: Add missing abstract methods
getVolumeClass(), getLeasesFilePath(), getIdsFilePath(), and
validateMasterMount() were implemented only on concrete storage domain
classes, which is good enough for runtime, but makes it harder to
understand the storage domain interface, and makes pylint unhappy.
Change-Id: Icbc91164f387f6f90e231c37ea53eae5b4943afe
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/sd.py
1 file changed, 21 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbc91164f387f6f90e231c37ea53eae5b4943afe
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: pylint: Add missing abstract methods
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Add missing abstract methods
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75797
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbc91164f387f6f90e231c37ea53eae5b4943afe
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: pylint: Check whether message was parsed to a dict
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Check whether message was parsed to a dict
......................................................................
Patch Set 1: Verified-1
make pylint-diff still fails
************* Module yajsonrpc.stompreactor
E:327,22: Instance of 'bool' has no 'get' member (no-member)
ERROR: InvocationError: '/home/danken/redhat/vdsm.git/.tox/pylint/bin/pylint --errors-only lib/yajsonrpc/stompreactor.py'
--
To view, visit https://gerrit.ovirt.org/76014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0570054ac7ea83e54ee366b35a43c9d7b3cc42c8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: fix multiline strings
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: fix multiline strings
......................................................................
fix multiline strings
remove internal spaces
Change-Id: I5ff32c3e64f057dd8f1c6f6f18e8a7628d6ca93b
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/storage/exception.py
1 file changed, 10 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/75976/1
diff --git a/lib/vdsm/storage/exception.py b/lib/vdsm/storage/exception.py
index b941ccc..cbd6fb9 100644
--- a/lib/vdsm/storage/exception.py
+++ b/lib/vdsm/storage/exception.py
@@ -1562,10 +1562,11 @@
self.value = ("vgname=%s mdasize=%s "
"mdafree=%s" % (vgname, mdasize, mdafree))
code = 613
- message = """Error - The system has reached the high watermark on the VG
- metadata area size. This is due high number of Vdisks or
- large Vdisks size allocated on this specific VG. Please call
- Redhat Global Support to address the issue"""
+ message = (
+ "Error - The system has reached the high watermark on the VG "
+ "metadata area size. This is due high number of Vdisks or "
+ "large Vdisks size allocated on this specific VG. Please call "
+ "Support to address the issue")
class SmallVgMetadata(StorageException):
@@ -1573,10 +1574,11 @@
self.value = ("vgname=%s mdasize=%s "
"mdafree=%s" % (vgname, mdasize, mdafree))
code = 614
- message = """Warning - The allocated VG metadata area size is too small,
- which might limit its capacity (the number of Vdisks and/or
- their size). Refer to GSS knowledge base to understand the
- issue and how to resolve it"""
+ message = (
+ "Warning - The allocated VG metadata area size is too small, "
+ "which might limit its capacity (the number of Vdisks and/or "
+ "their size). Refer to GSS knowledge base to understand the "
+ "issue and how to resolve it")
class CouldNotResizePhysicalVolume(StorageException):
--
To view, visit https://gerrit.ovirt.org/75976
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ff32c3e64f057dd8f1c6f6f18e8a7628d6ca93b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 2 months
Change in vdsm[ovirt-4.1]: spec: create /var/run/vdsm/* post uninstallation in upgrade ...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: create /var/run/vdsm/* post uninstallation in upgrade scenario
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/76026/2//COMMIT_MSG
Commit Message:
Line 12: In an upgrade scenario, this causes the newly created folders to be
Line 13: removed as the post uninistallation instructions are called afterwards,
Line 14: causing the folders to be missing.
Line 15:
Line 16: Bug-Id: https://bugzilla.redhat.com/1437448
please explain that this is needed ONLY in the stable branch, and why.
Line 17: Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: pylint: Include pylint-diff in make check
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Include pylint-diff in make check
......................................................................
Patch Set 1:
please handle the case of `make check` from tarball
(skip test if git is missing)
--
To view, visit https://gerrit.ovirt.org/75895
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d87d0098431d1210e939d01297b0fa4aa365ac6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months