Change in vdsm[master]: pylint: Check changed modules in check-patch
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Check changed modules in check-patch
......................................................................
pylint: Check changed modules in check-patch
Add pylint-diff target checking the modules modified by this patch.
Since this check is fast enough, we can run it for every patch in
check-patch.sh.
Since pylint will fail now for many modules, we do not fail the build
yet. When the current code is pylint-clean we can start failing the
build if a new error is detected.
Timing pylint and pylint-diff for typical patch:
$ time make pylint
...
real 1m31.133s
user 1m29.934s
sys 0m0.849s
$ time make pylint-diff
...
real 0m12.364s
user 0m11.879s
sys 0m0.262s
Change-Id: Ia458909a300c8555a84f3d7f1f8a410c0856e444
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M Makefile.am
M automation/check-patch.sh
M tox.ini
3 files changed, 23 insertions(+), 12 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia458909a300c8555a84f3d7f1f8a410c0856e444
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: pylint: Check changed modules in check-patch
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Check changed modules in check-patch
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/69450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia458909a300c8555a84f3d7f1f8a410c0856e444
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: vdsm metrics: replace dots with underscore in entity names
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: vdsm metrics: replace dots with underscore in entity names
......................................................................
vdsm metrics: replace dots with underscore in entity names
statsd recognize dots as entering to subtree. If a nic name or vol name
include dot in their name, we shell convert it to underscore to avoid
recognize it as sub metric tree
Change-Id: If097f45d9f9d65bd056371234255e91609656ae5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1433734
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/host/api.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/74417/1
diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index d9ee16b..49244bb 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -86,7 +86,7 @@
try:
for dom in hoststats['storageDomains']:
- storage_prefix = prefix + '.storage.' + dom
+ storage_prefix = prefix + '.storage.' + dom.replace('.', '_')
dom_info = hoststats['storageDomains'][dom]
data[storage_prefix + '.delay'] = dom_info['delay']
data[storage_prefix + '.last_check'] = dom_info['lastCheck']
@@ -122,7 +122,7 @@
if 'network' in hoststats:
for interface in hoststats['network']:
if_info = hoststats['network'][interface]
- net_prefix = prefix + '.nic.' + interface
+ net_prefix = prefix + '.nic.' + interface.replace('.', '_')
data[net_prefix + '.speed'] = if_info['speed']
data[net_prefix + '.rx_errors'] = if_info['rxErrors']
data[net_prefix + '.tx_errors'] = if_info['txErrors']
--
To view, visit https://gerrit.ovirt.org/74417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If097f45d9f9d65bd056371234255e91609656ae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 2 months
Change in vdsm[master]: pylint: Rename arguments in configurator.configure
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Rename arguments in configurator.configure
......................................................................
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/75988/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
PS1, Line 158: args
parge, for consistency
PS1, Line 193: args
and here
PS1, Line 215: args
and here
--
To view, visit https://gerrit.ovirt.org/75988
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7c0b362a87350162ad7838f658af7f9fcea3398
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: MOM: Reduce log messages when MOM unavailable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: MOM: Reduce log messages when MOM unavailable
......................................................................
MOM: Reduce log messages when MOM unavailable
When MOM is not available the log gets cluttered with messages.
This patch utilizes the throttledlog module to display the messages
once every 100 calls instead of every time the methods are called.
Change-Id: I0af0d3dc694d16fae791bb5af2feb5c7b6deeb23
Bug-Url: https://bugzilla.redhat.com/1437341
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M lib/vdsm/momIF.py
M lib/vdsm/throttledlog.py
M tests/throttledlog_test.py
3 files changed, 20 insertions(+), 2 deletions(-)
Approvals:
Denis Chaplygin: Looks good to me, but someone else must approve
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Jenny Tokar: Verified
--
To view, visit https://gerrit.ovirt.org/75681
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0af0d3dc694d16fae791bb5af2feb5c7b6deeb23
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: MOM: Reduce log messages when MOM unavailable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: MOM: Reduce log messages when MOM unavailable
......................................................................
Patch Set 6: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/75681
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0af0d3dc694d16fae791bb5af2feb5c7b6deeb23
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: ovs driver: introduce add_vhostuser_port command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ovs driver: introduce add_vhostuser_port command
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/75026/8/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:
Line 160: CA_FILE = os.path.join(PKI_DIR, 'certs', 'cacert.pem')
Line 161:
Line 162: # vhost user sockets path
Line 163:
Line 164: VHOST_SOCK_DIR = '/tmp'
use P_VDSM_RUN instead
--
To view, visit https://gerrit.ovirt.org/75026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie44fe082cffdaf3351450d55da7f48b2a9f7b315
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: network: fail legacy network validation when adding dpdk device
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: fail legacy network validation when adding dpdk device
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/75835/5/lib/vdsm/network/legacy_switch.py
File lib/vdsm/network/legacy_switch.py:
PS5, Line 605: supported only with OVS
are not supported as bond slaves
--
To view, visit https://gerrit.ovirt.org/75835
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7394428f14a6b0db2f3aaee798daa767ab1aae6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: vm: support creating vhostuser interface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: support creating vhostuser interface
......................................................................
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/74327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[ovirt-4.1]: Remove deprecated listen attribute
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Hello Jonathan Dieter,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/75909
to review the following change.
Change subject: Remove deprecated listen attribute
......................................................................
Remove deprecated listen attribute
Tested using ovirt-engine-4.1.1.8 and vdsm-4.19.10.1 with this patch
applied.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1437523
Change-Id: Ibe44ccfc70bba2ad9deabef3a33473725ab7fbbe
Signed-off-by: Jonathan Dieter <jdieter(a)lesbg.com>
---
M vdsm/virt/vm_migrate_hook.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/75909/1
diff --git a/vdsm/virt/vm_migrate_hook.py b/vdsm/virt/vm_migrate_hook.py
index 635e5b8..59cdfa6 100755
--- a/vdsm/virt/vm_migrate_hook.py
+++ b/vdsm/virt/vm_migrate_hook.py
@@ -190,11 +190,13 @@
graphics_listen.attrib.pop('network', None)
graphics_listen.set('type', 'address')
graphics_listen.set('address', target_display_ip)
+ graphics.attrib.pop('listen', None)
else:
libvirt_network = net_api.netname_o2l(target_display_network)
graphics_listen.attrib.pop('address', None)
graphics_listen.set('type', 'network')
graphics_listen.set('network', libvirt_network)
+ graphics.attrib.pop('listen', None)
def _vmconf_display(vm_conf):
--
To view, visit https://gerrit.ovirt.org/75909
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe44ccfc70bba2ad9deabef3a33473725ab7fbbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jonathan Dieter <jdieter(a)lesbg.com>
7 years, 2 months