Change in vdsm[master]: pylint: Silence pylint errors in infra
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Silence pylint errors in infra
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75748
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7baa0f07abc67cb5cf0477bf07128178c394fe2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: pylint: Check whether message was parsed to a dict
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Check whether message was parsed to a dict
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/76014/2/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 321: """
Line 322: def send(self, message, destination=stomp.SUBSCRIPTION_ID_RESPONSE):
Line 323: resp = json.loads(message)
Line 324: if not isinstance(resp, dict):
Line 325: raise ValueError(
> This won't get propagated to the client side. If the message is not correct
pylint is simply not smart enough to tell that after line 325, 'resp' is necessarily a dict. When it imported json.loads() it realized that it might return a boolean, so it complains. I don't think we have a choice but to silence pylint.
Line 326: 'Provided message %s failed parsing to dictionary' % message)
Line 327: response_id = resp.get("id")
Line 328:
Line 329: try:
--
To view, visit https://gerrit.ovirt.org/76014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0570054ac7ea83e54ee366b35a43c9d7b3cc42c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[ovirt-4.1]: spec: call systemd-tmpfiles --create post uninstall in upgra...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/76026/3/vdsm.spec.in
File vdsm.spec.in:
Line 864: fi
Line 865: if [ "${vdsmd_start_required}" = 'yes' ]; then
Line 866: %{_bindir}/vdsm-tool service-start vdsmd >/dev/null 2>&1 || :
Line 867: fi
Line 868:
please add a comment:
# re-create tmp files, as some of them where delivered by
# vdsm-4.18*.rpm but not in future version, and thus
# removed when it is uninstalled.
Line 869: systemd-tmpfiles --create %{vdsm_name}.conf
Line 870: fi
Line 871: exit 0
Line 872:
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: pylint: Use sentinel error to make pylint happy
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Use sentinel error to make pylint happy
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75790
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc38e98c606fde6da761a9f0d57395c426b7d385
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: pylint: Fix Volume.__init__ signature
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Fix Volume.__init__ signature
......................................................................
pylint: Fix Volume.__init__ signature
Volume.__init__ signature was different from FileVolume and BlockVolume
__init__, making pylint unhappy. The code was correct becuase in runtime
only FileVolume and BlockVolume are created, but pylint could not detect
this.
Simplify the code, moving __init__ from FileVolume and BlockVolume up to
Volume class. This fix these pylint warnings:
E:1010,28: Too many positional arguments for constructor call (too-many-function-args)
E:1018,32: Too many positional arguments for constructor call (too-many-function-args)
This change introduces new pylint errors in fileVolume.py and
blockVolume.py, since VolumeManifest is missing many methods. This will
be fixed in the next patch.
Change-Id: I82f0b081ad57bf5a693d4d956e6e08b880e02ccb
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/volume.py
3 files changed, 2 insertions(+), 10 deletions(-)
Approvals:
Nir Soffer: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75798
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82f0b081ad57bf5a693d4d956e6e08b880e02ccb
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: fix copyright message
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: fix copyright message
......................................................................
fix copyright message
Change-Id: I71ce289920be51899613d2895f1c314e84456f56
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M init/vdsmd_init_common.sh.in
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/75975/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index f00666b..cbec4a6 100755
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -1,6 +1,6 @@
#!/bin/sh
# Copyright 2013 IBM, Inc.
-# Copyright 2017 Redhat, Inc.
+# Copyright 2017 Red Hat, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
--
To view, visit https://gerrit.ovirt.org/75975
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I71ce289920be51899613d2895f1c314e84456f56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 2 months
Change in vdsm[master]: net: Centralize bond mode 'numerization'
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Centralize bond mode 'numerization'
......................................................................
net: Centralize bond mode 'numerization'
When handling the bond mode, at several location the numeric value is
required, therefore the conversion from a name value to a numeric value
is performed.
As this task is currently perform at several locations outside the bond
modules, this patch centralizes it under one of bond modules.
This change originated from the need to add another such numerization of
the bond mode value.
Change-Id: I3e40fe1b539a9844a3bb40266d99a87ff4d4f628
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/kernelconfig.py
M lib/vdsm/network/models.py
M lib/vdsm/network/netinfo/bonding.py
3 files changed, 7 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/75856
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e40fe1b539a9844a3bb40266d99a87ff4d4f628
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net: Move numerize_bond_mode implementation to sysfs_options
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Move numerize_bond_mode implementation to sysfs_options
......................................................................
net: Move numerize_bond_mode implementation to sysfs_options
numerize_bond_mode is specific to sysfs options and moving the
implementation down the stack allow usage of it from the sysfs drivers
and help clean netinfo.bonding.
Change-Id: Ie573ded57799457f9e355951c0851b9f7b7b3572
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/netinfo/bonding.py
2 files changed, 7 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/75863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie573ded57799457f9e355951c0851b9f7b7b3572
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net: Move numerize_bond_mode implementation to sysfs_options
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move numerize_bond_mode implementation to sysfs_options
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75863
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie573ded57799457f9e355951c0851b9f7b7b3572
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: net: Centralize bond mode 'numerization'
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Centralize bond mode 'numerization'
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75856
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e40fe1b539a9844a3bb40266d99a87ff4d4f628
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months