Change in vdsm[master]: xmlrpc: rename binding
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: rename binding
......................................................................
Patch Set 9: Code-Review-1
(5 comments)
2 patches:
1. rename "binding" to "server" - explain why
2. rename "xmlrpc" places to "http" to still use xmlrpc code - also explain for what we use it
https://gerrit.ovirt.org/#/c/72768/9/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 206:
Line 207: ('fake_sriov_enable', 'false',
Line 208: 'Enable reporting of fake SR-IOV devices.'),
Line 209:
Line 210: ('http_enable', 'true', 'Enable the http server'),
weird change.. I would explain where the config is used now when xmlrpc is removed.
Line 211:
Line 212: ('jsonrpc_enable', 'true', 'Enable the JSON RPC server'),
Line 213:
Line 214: ('broker_enable', 'false', 'Enable outgoing connection to broker'),
https://gerrit.ovirt.org/#/c/72768/9/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 243:
Line 244: def Host_getCapabilities_Ret(server_address, ret):
Line 245: """
Line 246: We need to add additional information to getCaps as it was done for xmlrpc.
Line 247: """
not related of course..
Line 248: ret['info']['lastClientIface'] = getDeviceByIP(server_address)
Line 249:
Line 250: return ret['info']
Line 251:
https://gerrit.ovirt.org/#/c/72768/9/tests/clientif_test.py
File tests/clientif_test.py:
Line 51: self.channelListener = None
Line 52: self.vmContainerLock = threading.Lock()
Line 53: self.vmContainer = {}
Line 54: self.vmRequests = {}
Line 55: self.servers = {}
why the renaming?
Line 56: self._recovery = False
Line 57:
Line 58: def createVm(self, vmParams, vmRecover=False):
Line 59: self.vmRequests[vmParams['vmId']] = (vmParams, vmRecover)
https://gerrit.ovirt.org/#/c/72768/9/vdsm.spec.in
File vdsm.spec.in:
Line 245: Obsoletes: %{name}-xmlrpc < %{version}-%{release}
Line 246:
Line 247: %description http
Line 248: A http interface for interacting with vdsmd when using OVF store image
Line 249: download or upload.
this phrase should be in the commit msg - we still use xmlrpc code as http server listener for using OVF store images.... and attach the relevant RFE bugzilla that introduce that maybe for extra fun
Line 250:
Line 251: %package client
Line 252: Summary: VDSM client
Line 253: BuildArch: noarch
https://gerrit.ovirt.org/#/c/72768/9/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 258: self.servers['http'] = http_server
Line 259: http_detector = HttpDetector(http_server)
Line 260: self._acceptor.add_detector(http_detector)
Line 261:
Line 262: def _prepareJSONRPCBinding(self):
now you need to change this also to Server.. do the renaming in different patch.
Line 263: if config.getboolean('vars', 'jsonrpc_enable'):
Line 264: try:
Line 265: from vdsm.rpc import Bridge
Line 266: from vdsm.rpc.bindingjsonrpc import BindingJsonRpc
--
To view, visit https://gerrit.ovirt.org/72768
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45271691c3898678ff7d331d99ebb1d398a640af
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: ssl: remove m2crypto
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: remove m2crypto
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/76027/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-04-25 16:31:56 +0200
Line 6:
Line 7: ssl: remove m2crypto
Line 8:
Line 9: The reasons why m2crypto was introduced are not valid anymore and due to
"are not valid anymore" ?:| why?.. you can just say that we want to remove it because we don't want to use it
Line 10: burden to maintain it we are removing it.
Line 11:
Line 12:
Line 13: Change-Id: Iab4f2f745e19d90dbb10206a96bdbd29fd77a420
https://gerrit.ovirt.org/#/c/76027/1/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:
Line 1: # Copyright (C) 2014-2016 Saggi Mizrahi, Red Hat Inc.
dates
(not only in this file)
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License version 2 as
Line 5: # published by the Free Software Foundation.
--
To view, visit https://gerrit.ovirt.org/76027
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab4f2f745e19d90dbb10206a96bdbd29fd77a420
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: build: add flag to choose ssl implementation
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: build: add flag to choose ssl implementation
......................................................................
Patch Set 8: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/72272/8/Makefile.am
File Makefile.am:
Line 67: lib \
Line 68: tests/network/*.py \
Line 69: $(NULL)
Line 70:
Line 71: if M2C
you don't need that
Line 72: M2C_BUILD= --define="with_m2c 1"
Line 73: else
Line 74: M2C_BUILD= --define="with_m2c 0"
Line 75: endif
Line 171: $(DIST_ARCHIVES)
Line 172:
Line 173: rpm: dist
Line 174: rpmbuild -ta $(if $(BUILDID),--define="extra_release .$(BUILDID)") \
Line 175: $(M2C_BUILD) $(DIST_ARCHIVES)
you don't need it. do it as other globals in the spec - I mention that in the spec review
Line 176:
Line 177: dist-hook: gen-VERSION gen-ChangeLog
Line 178: .PHONY: gen-VERSION gen-ChangeLog
Line 179:
https://gerrit.ovirt.org/#/c/72272/8/build-aux/Makefile.subs
File build-aux/Makefile.subs:
Line 28: -e "s,[@]BINDIR[@],$(bindir),g" \
Line 29: -e "s,[@]CONFDIR[@],$(vdsmconfdir),g" \
Line 30: -e "s,[@]HOOKSDIR[@],$(vdsmhooksdir),g" \
Line 31: -e "s,[@]LIBEXECDIR[@],$(vdsmexecdir),g" \
Line 32: -e "s,[@]SSL_IMPLEMENTATION[@],$(M2C),g" \
for this use different variable "SSL_IMPL" in configure.ac, the M2C one is used for the with_m2c flag.. don't overkill it.
Line 33: -e "s,[@]VDSMDIR[@],$(vdsmdir),g" \
Line 34: -e "s,[@]VDSMLIBDIR[@],$(vdsmlibdir),g" \
Line 35: -e "s,[@]VDSMLOGDIR[@],$(vdsmlogdir),g" \
Line 36: -e "s,[@]VDSMREPO[@],$(vdsmrepo),g" \
https://gerrit.ovirt.org/#/c/72272/8/configure.ac
File configure.ac:
Line 258: )
Line 259: AM_CONDITIONAL([M2C], [test "${enable_m2c}" = "yes"])
Line 260: AS_IF([test "${enable_m2c}" = "yes"],
Line 261: AC_SUBST([M2C], ['m2c']),
Line 262: AC_SUBST([M2C], ['ssl']))
use 1 and 0 - it will be easier for you
Line 263:
Line 264: # Users and groups
Line 265: AC_SUBST([VDSMUSER], [vdsm])
Line 266: AC_SUBST([VDSMGROUP], [kvm])
https://gerrit.ovirt.org/#/c/72272/8/vdsm.spec.in
File vdsm.spec.in:
Line 36: # touch configure.ac or Makefile.am.
Line 37: %{!?enable_autotools:%global enable_autotools 0}
Line 38:
Line 39: # M2C build - overrideable using rpmbuild --define "with_m2c 0"
Line 40: # %{!?with_m2c: %global with_m2c 1}
remove this
and use as above -
%global with_m2c @M2C@
Line 41:
Line 42: # Required paths
Line 43: %if 0%{?fedora}
Line 44: %global _polkitdir %{_datadir}/polkit-1/rules.d
--
To view, visit https://gerrit.ovirt.org/72272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06232c8917f620686887a8b07a17608cfb70ef27
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: rpc: propagate executor issue to the engine
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: rpc: propagate executor issue to the engine
......................................................................
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/74005/12//COMMIT_MSG
Commit Message:
Line 6:
Line 7: rpc: propagate executor issue to the engine
Line 8:
Line 9: When we fail with executor being busy so it could not accept more tasks
Line 10: we want to replay with specific error so the engine could react properly
reply
Line 11: and it and perform an action like soft fencing.
Line 12:
Line 13: Bug-Url: https://bugzilla.redhat.com/1433380
Line 14: Change-Id: If4038dfd38fa2f9520d822e4c1394bf5bb003e2d
https://gerrit.ovirt.org/#/c/74005/12/lib/vdsm/executor.py
File lib/vdsm/executor.py:
Line 103: self._name = name
Line 104: self._workers_count = workers_count
Line 105: self._max_workers = max_workers
Line 106: self._worker_id = 0
Line 107: self._tasks = TaskQueue(name, max_tasks)
adding name to the taskQueue can be done separately :| people might ask that, or at least add it in the comment
Line 108: self._scheduler = scheduler
Line 109: if log is not None:
Line 110: self._log = log
Line 111: self._workers = set()
--
To view, visit https://gerrit.ovirt.org/74005
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4038dfd38fa2f9520d822e4c1394bf5bb003e2d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[ovirt-4.1]: spec: call systemd-tmpfiles --create post uninstall in upgra...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec: call systemd-tmpfiles --create post uninstall in upgrade scenario
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2da60e6e06b49f0d0bb2eb407d89dbefe8ded424
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: net: Support editing bond mode using a named value
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Support editing bond mode using a named value
......................................................................
net: Support editing bond mode using a named value
Change-Id: I94b7cd2ff85369cbd78af70699f7d57f398335f7
Bug-Url: https://bugzilla.redhat.com/1424810
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/bond/sysfs_options.py
M tests/network/link_bond_test.py
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/75894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94b7cd2ff85369cbd78af70699f7d57f398335f7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: net: Move sysctl module under the network package
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Move sysctl module under the network package
......................................................................
Patch Set 1:
sysctl is a generic tool, that may have other users in the future, besides network.
Piotr, don't we see a non-network use case for it?
--
To view, visit https://gerrit.ovirt.org/75972
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I573b4b115f78c08d020272316203122ba1987662
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: pylint: Silence pylint errors in infra
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Silence pylint errors in infra
......................................................................
pylint: Silence pylint errors in infra
Some of the silenced errors should be fixed; others should be silenced
more pointedly.
Change-Id: Ia7baa0f07abc67cb5cf0477bf07128178c394fe2
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/commands.py
M lib/vdsm/sslutils.py
M lib/vdsm/supervdsm.py
M vdsm/vdsmd.py
4 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75748
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7baa0f07abc67cb5cf0477bf07128178c394fe2
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: net: Support editing bond mode using a named value
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Support editing bond mode using a named value
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94b7cd2ff85369cbd78af70699f7d57f398335f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: pylint: Use sentinel error to make pylint happy
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Use sentinel error to make pylint happy
......................................................................
pylint: Use sentinel error to make pylint happy
pylint was unhappy about raising an exception that could be None. Make
the code easier to check statically by initializing the exception to a
sentinel _NO_ERROR.
Change-Id: Icc38e98c606fde6da761a9f0d57395c426b7d385
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/storage/misc.py
1 file changed, 8 insertions(+), 3 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75790
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc38e98c606fde6da761a9f0d57395c426b7d385
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month