Change in vdsm[master]: pylint: Silence pylint errors in virt
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Silence pylint errors in virt
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/75749/5/lib/vdsm/virt/containers/domain.py
File lib/vdsm/virt/containers/domain.py:
Line 57
Line 58
Line 59
Line 60
Line 61
> Maybe this wrong code that may fail with AttributeError is the cause for th
what's wrong in this code?
pylint is as unhappy with
import uuid
print uuid.UUID('551f2afd-02de-455a-9c9d-c9342e8ed2ed').int
--
To view, visit https://gerrit.ovirt.org/75749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95cd8a090cceaa433a683a119653df0653e974e5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: pylint: Silence pylint errors in virt
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Silence pylint errors in virt
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/75749/5/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 518
Line 519
Line 520
Line 521
Line 522
> This can be fixed by initializing self._password in this class.
and _password_file as well, to None or something.
--
To view, visit https://gerrit.ovirt.org/75749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95cd8a090cceaa433a683a119653df0653e974e5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: pylint: Silence pylint errors in virt
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Silence pylint errors in virt
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/75749/5/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 105: ''' Base class for v2v errors '''
Line 106:
Line 107:
Line 108: class ClientError(Exception):
Line 109: ''' Base class for client error '''
We can avoid the pylint error by setting
err_name = 'unexpected'
here.
Line 110:
Line 111:
Line 112: class InvalidVMConfiguration(ValueError):
Line 113: ''' Unexpected error while parsing libvirt domain xml '''
--
To view, visit https://gerrit.ovirt.org/75749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95cd8a090cceaa433a683a119653df0653e974e5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: virt: devices: console: add from_xml_tree
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: console: add from_xml_tree
......................................................................
Patch Set 28: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72882
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id99fff24ead20b196556b23b8424b87a7683261c
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: virt: devices: balloon: add from_xml_tree
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: balloon: add from_xml_tree
......................................................................
Patch Set 27: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72881
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c78ff73135e117ddbe64f6e763abd536070bcdc
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: virt: devices: start the from_xml_tree method
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: start the from_xml_tree method
......................................................................
Patch Set 27: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72880
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I21e80625f1b86cd5a49571d2e121ee479535d8d3
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: Drop unused PersistentConfig.restore method
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Drop unused PersistentConfig.restore method
......................................................................
net: Drop unused PersistentConfig.restore method
Change-Id: Icd89c936d1118fd922ac1f6f6d9dc1d9f986d2ad
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd89c936d1118fd922ac1f6f6d9dc1d9f986d2ad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Drop unused PersistentConfig.restore method
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Drop unused PersistentConfig.restore method
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76070
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd89c936d1118fd922ac1f6f6d9dc1d9f986d2ad
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: pylint: ignore no-member in vmdevices
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: pylint: ignore no-member in vmdevices
......................................................................
pylint: ignore no-member in vmdevices
vmxml.Devices fields are set outside __init__, confusing pylint. Let us
ignore this problem to make new pylint-catchable mistakes found.
Change-Id: I51d70b173430ac513320b8efac1233d228ab15da
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
M lib/vdsm/virt/vmdevices/graphics.py
M lib/vdsm/virt/vmdevices/hostdevice.py
M lib/vdsm/virt/vmdevices/lease.py
M lib/vdsm/virt/vmdevices/network.py
M lib/vdsm/virt/vmdevices/storage.py
6 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/75726/1
diff --git a/lib/vdsm/virt/vmdevices/core.py b/lib/vdsm/virt/vmdevices/core.py
index 5d9e55a..b37ada4 100644
--- a/lib/vdsm/virt/vmdevices/core.py
+++ b/lib/vdsm/virt/vmdevices/core.py
@@ -17,6 +17,8 @@
#
# Refer to the README and COPYING files for full details of the license
#
+# pylint: disable=no-member
+
from __future__ import absolute_import
import os.path
diff --git a/lib/vdsm/virt/vmdevices/graphics.py b/lib/vdsm/virt/vmdevices/graphics.py
index a74ba1e..a1fec81 100644
--- a/lib/vdsm/virt/vmdevices/graphics.py
+++ b/lib/vdsm/virt/vmdevices/graphics.py
@@ -17,6 +17,8 @@
#
# Refer to the README and COPYING files for full details of the license
#
+# pylint: disable=no-member
+
from __future__ import absolute_import
import libvirt
diff --git a/lib/vdsm/virt/vmdevices/hostdevice.py b/lib/vdsm/virt/vmdevices/hostdevice.py
index 74f6ca8..b436ad6 100644
--- a/lib/vdsm/virt/vmdevices/hostdevice.py
+++ b/lib/vdsm/virt/vmdevices/hostdevice.py
@@ -17,6 +17,8 @@
#
# Refer to the README and COPYING files for full details of the license
#
+# pylint: disable=no-member
+
from __future__ import absolute_import
import xml.etree.ElementTree as ET
diff --git a/lib/vdsm/virt/vmdevices/lease.py b/lib/vdsm/virt/vmdevices/lease.py
index a5d094c..e163cbd 100644
--- a/lib/vdsm/virt/vmdevices/lease.py
+++ b/lib/vdsm/virt/vmdevices/lease.py
@@ -17,6 +17,7 @@
#
# Refer to the README and COPYING files for full details of the license
#
+# pylint: disable=no-member
"""
lease - manage lease devices in the virt subsystem.
diff --git a/lib/vdsm/virt/vmdevices/network.py b/lib/vdsm/virt/vmdevices/network.py
index 54e90c0..4150078 100644
--- a/lib/vdsm/virt/vmdevices/network.py
+++ b/lib/vdsm/virt/vmdevices/network.py
@@ -17,6 +17,8 @@
#
# Refer to the README and COPYING files for full details of the license
#
+# pylint: disable=no-member
+
from __future__ import absolute_import
import xml.etree.ElementTree as ET
diff --git a/lib/vdsm/virt/vmdevices/storage.py b/lib/vdsm/virt/vmdevices/storage.py
index 09a1c74..79248ee 100644
--- a/lib/vdsm/virt/vmdevices/storage.py
+++ b/lib/vdsm/virt/vmdevices/storage.py
@@ -17,6 +17,8 @@
#
# Refer to the README and COPYING files for full details of the license
#
+# pylint: disable=no-member
+
from __future__ import absolute_import
import collections
--
To view, visit https://gerrit.ovirt.org/75726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51d70b173430ac513320b8efac1233d228ab15da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years
Change in vdsm[master]: v2v: add _command placeholder
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: add _command placeholder
......................................................................
v2v: add _command placeholder
The V2VCommand base class should have placeholder also for the
_command() method, which is supposed to be overridden by subclasses,
much like execute().
This also makes pylint a bit happier.
Change-Id: Ib23332445cabc97d8e2026b6973dad7e77bba109
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/v2v.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Dan Kenigsberg: Passed CI tests
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/75855
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib23332445cabc97d8e2026b6973dad7e77bba109
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years