Change in vdsm[master]: v2v: add _command placeholder
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: add _command placeholder
......................................................................
Patch Set 5: Continuous-Integration+1
unrelated:
13:57:06 FAIL: test_detect_concurrency(True) (protocoldetector_test.AcceptorTests)
13:57:06 ----------------------------------------------------------------------
13:57:06 Traceback (most recent call last):
13:57:06 File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/testlib.py", line 141, in wrapper
13:57:06 return f(self, *args)
13:57:06 File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/protocoldetector_test.py", line 156, in test_detect_concurrency
13:57:06 self.check_concurrently(self.check_detect, use_ssl, data, data)
13:57:06 File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/protocoldetector_test.py", line 265, in check_concurrently
13:57:06 self.assertTrue(all(done))
13:57:06 AssertionError: False is not true
--
To view, visit https://gerrit.ovirt.org/75855
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib23332445cabc97d8e2026b6973dad7e77bba109
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: Revert "ssl: change default library"
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Revert "ssl: change default library"
......................................................................
Revert "ssl: change default library"
This reverts commit aaef1a430bb4b485902a4ad8a18641fad3e805bc.
Due to issue with comparing certificates let's revert this change
for now.
Change-Id: I5d3760dc388d6ddfce7287de631653be384ec642
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d3760dc388d6ddfce7287de631653be384ec642
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: Revert "ssl: change default library"
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Revert "ssl: change default library"
......................................................................
Patch Set 1: Code-Review+2 Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/76160
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d3760dc388d6ddfce7287de631653be384ec642
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: vmpowerdown: implement base class interface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmpowerdown: implement base class interface
......................................................................
vmpowerdown: implement base class interface
The VmPowerdown class was not implementing fully its interface,
demanding to its derived class to fill the blanks. This made
pylint unhappy and the code a bit harder to follow.
In this patch we complete the VmPowerdown interface, so the derived
class need now to override the attributes.
This makes pylint happy and the code a bit easier to read.
Change-Id: I1a5f7880c5f3e8cc37c979294a501632d8dcbe8d
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmpowerdown.py
1 file changed, 13 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75853
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a5f7880c5f3e8cc37c979294a501632d8dcbe8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: pylint: Check whether message was parsed to a dict
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Check whether message was parsed to a dict
......................................................................
pylint: Check whether message was parsed to a dict
We need to make sure that a message is parsed to a dictionary so we
added a check. We still need to silence pylint issue:
E:324,22: Instance of 'bool' has no 'get' member (no-member)
Change-Id: I0570054ac7ea83e54ee366b35a43c9d7b3cc42c8
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/yajsonrpc/stompreactor.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76014
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0570054ac7ea83e54ee366b35a43c9d7b3cc42c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: ssl: change default library
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ssl: change default library
......................................................................
ssl: change default library
We would like to change default ssl library being used from m2crypto to
ssl. This patch would enable us to remove m2crypto.
Change-Id: I80746f401d927232b786661e71deb0a7d38d98c0
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I80746f401d927232b786661e71deb0a7d38d98c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: ssl: change default library
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: change default library
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76107
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80746f401d927232b786661e71deb0a7d38d98c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[ovirt-4.1]: vdsm metrics: replace dots with underscore in entity names
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has uploaded a new change for review.
Change subject: vdsm metrics: replace dots with underscore in entity names
......................................................................
vdsm metrics: replace dots with underscore in entity names
statsd recognize dots as entering to subtree. If a nic name includes
dot in their name we convert it to underscore to avoid
recognize it as sub metric tree in collectd
Change-Id: If097f45d9f9d65bd056371234255e91609656ae5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1433734
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/host/api.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/75998/1
diff --git a/lib/vdsm/host/api.py b/lib/vdsm/host/api.py
index d9ee16b..b3f77e9 100644
--- a/lib/vdsm/host/api.py
+++ b/lib/vdsm/host/api.py
@@ -122,7 +122,7 @@
if 'network' in hoststats:
for interface in hoststats['network']:
if_info = hoststats['network'][interface]
- net_prefix = prefix + '.nic.' + interface
+ net_prefix = prefix + '.nic.' + interface.replace('.', '_')
data[net_prefix + '.speed'] = if_info['speed']
data[net_prefix + '.rx_errors'] = if_info['rxErrors']
data[net_prefix + '.tx_errors'] = if_info['txErrors']
--
To view, visit https://gerrit.ovirt.org/75998
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If097f45d9f9d65bd056371234255e91609656ae5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
7 years, 1 month
Change in vdsm[master]: ssl: remove m2crypto
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: ssl: remove m2crypto
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76027
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab4f2f745e19d90dbb10206a96bdbd29fd77a420
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: vm: use response.success() in setIoTune
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: use response.success() in setIoTune
......................................................................
vm: use response.success() in setIoTune
Tiny refactoring, could also be useful as faking point later
Change-Id: I7e27a00586d767aaa0f3a43717f2272c238366c1
Backport-To: 4.1
Related-To: https://bugzilla.redhat.com/1443654
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/75944
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e27a00586d767aaa0f3a43717f2272c238366c1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month