From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: migrating testAddTwice to the new functional tests
......................................................................
net tests: migrating testAddTwice to the new functional tests
Change-Id: I17791f57e68137973c4cebe5df01a2eb6576debb
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
M tests/network/func_net_basic_test.py
2 files changed, 15 insertions(+), 16 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75754
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I17791f57e68137973c4cebe5df01a2eb6576debb
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: shortcut for ipv6 incapable system
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/75588/4/lib/vdsm/sysctl.py
File lib/vdsm/sysctl.py:
Line 110: with open('/proc/sys/net/ipv6/conf/%s/accept_redirects' % dev, 'w') as f:
Line 111: f.write(setstate)
Line 112:
Line 113:
Line 114: def _is_ipv6_available():
> 1. If this path appears as a result of loading the kmod, I guess it is a va
+1 for the current name, I see no benefit in tying the function name to kernel implementation.
+1 for memoization; whomever modprobes ipv6 during runtime can be asked to restart vdsmd.
--
To view, visit https://gerrit.ovirt.org/75588
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54c2c04b79582d04b08e3198dad80b0796993aca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Set listen attribute as well as already set listen element
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/75715/1//COMMIT_MSG
Commit Message:
PS1, Line 9: Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1437523
Please write as
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1437523
to integrate better with bugzilla.
https://gerrit.ovirt.org/#/c/75715/1/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:
Line 189: if net_api.ovs_bridge(target_display_network):
Line 190: graphics_listen.attrib.pop('network', None)
Line 191: graphics_listen.set('type', 'address')
Line 192: graphics_listen.set('address', target_display_ip)
Line 193: graphics.set('listen', target_display_ip)
Thanks for your patch.
http://libvirt.org/formatdomain.html#elementsGraphics says
"""
The address attribute is duplicated as listen attribute in graphics element for backward compatibility. If both are provided they must be equal.
"""
do we normally set the listen attribute on our VMs? It seems nicer to remove the old attribute.
Line 194: else:
Line 195: libvirt_network = net_api.netname_o2l(target_display_network)
Line 196: graphics_listen.attrib.pop('address', None)
Line 197: graphics_listen.set('type', 'network')
--
To view, visit https://gerrit.ovirt.org/75715
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe44ccfc70bba2ad9deabef3a33473725ab7fbbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jonathan Dieter <jdieter(a)lesbg.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Introduce the sysfs module
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/75788/3/lib/vdsm/storage/sysfs.py
File lib/vdsm/storage/sysfs.py:
PS3, Line 22: sysfs
it is quite odd that nothing outside the module name and comments refers to sysfs... (but it's fine)
PS3, Line 71: return value.strip()
this is not expected to raise EnvironmentError, hence should sit in the "else" clause.
--
To view, visit https://gerrit.ovirt.org/75788
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63680cee2ea43d346da0fafebdbb98601c53993f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Fix AttributeError when renaming non-empty directory
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/75791/2/lib/vdsm/storage/outOfProcess.py
File lib/vdsm/storage/outOfProcess.py:
Line 237: except OSError as e:
Line 238: if e.errno != errno.ENOTEMPTY:
Line 239: raise
Line 240:
Line 241: _IOProcessFileUtils(self._iop).cleanupdir(newpath, False)
what an ugly raceful piece of code. do you know what supposedly needs it? The bug is here since June 2014 and nobody seems to bother. So maybe we can drop it altogether?
Line 242: self.mkdir(newpath)
Line 243: for fname in self._iop.listdir(oldpath):
Line 244: src = os.path.join(oldpath, fname)
Line 245: dst = os.path.join(newpath, fname)
--
To view, visit https://gerrit.ovirt.org/75791
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I352e8643a47f517c879d2085bced6847e0372b30
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Fix AttributeError hiding the real error
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75786
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie976e4a69df23e643a90dab7b18839dc023bf8dc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: Silence pylint errors in virt
......................................................................
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/75749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95cd8a090cceaa433a683a119653df0653e974e5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: monitor: Fix pylint error when invoking callabck
......................................................................
monitor: Fix pylint error when invoking callabck
Pylint was complaining about non-callable cycleCallback. The callback
was initialized to None, and the code was checking if cycleCallback is
not None before invoking it, but pylint is not smart to enough to
understand this.
Fixed by initializing to _NULL_CALLBACK function. Now we don't need the
None check and we can invoke the callback on every iteration. This is a
little bit more expensive compared with the None check, but we call this
once in 10 seconds so it does not matter.
Change-Id: I8f7ac8e842d415b7fe457875529abcae35ddcaec
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M vdsm/storage/monitor.py
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75736
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f7ac8e842d415b7fe457875529abcae35ddcaec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>