Change in vdsm[master]: net tests: removing the remainder of *CompatibilityMultipleN...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: removing the remainder of *CompatibilityMultipleNetsSameNic
......................................................................
net tests: removing the remainder of *CompatibilityMultipleNetsSameNic
After having portions of the test moved to the new functional tests,
what's left is redundant. The remainder of the test initially creates 2
networks:
1) 'test-network4' - 'another-nic', vlan: 100
2) 'test-network5' - 'nic', vlan: 200
There's no value in checking whether these networks were created
successfully as the use case is already covered(2 different networks,
different nics, different vlans)
Afterwards supposedly 2 networks are created, but it is not so as the
networks have the same name and are part of a single transaction
(the second network simply overwrites the first network as they have
the same dictionary key).
This leads to a single new network:
3) 'test-network6' - 'yet-another-nic', vlan: 300
Another network with a different name on a different nic with a
different vlan tag.
Change-Id: I357fadd683f9fe3f890eb5645f845b8538dc59b5
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 0 insertions(+), 46 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I357fadd683f9fe3f890eb5645f845b8538dc59b5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: vmdevices: stop using self.conf
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmdevices: stop using self.conf
......................................................................
vmdevices: stop using self.conf
We feed every Device object the vm.conf dict, but this is
actually used in very few cases.
We fix those cases injecting the needed extra attributes
in the device configuration, so the conf attribute is now useless
and will be removed in a future patch.
Change-Id: Ib8918e8e073fc55f2bae3a74d6279bda062d9930
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
M lib/vdsm/virt/vmdevices/graphics.py
M lib/vdsm/virt/vmdevices/network.py
M lib/vdsm/virt/vmdevices/storage.py
M tests/device_test.py
M tests/vm_test.py
M tests/vmstorage_test.py
M vdsm/virt/vm.py
8 files changed, 98 insertions(+), 36 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
M.Z.: Looks good to me, but someone else must approve
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8918e8e073fc55f2bae3a74d6279bda062d9930
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: M.Z. <pdm(a)zamazal.org>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: tests: consolidate the device XML tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: consolidate the device XML tests
......................................................................
tests: consolidate the device XML tests
We have the device XML tests scattered around, but we want to
consolidate them in a dedicate module.
Benefits:
1. python3 compatibility
2. moved into the vertical-specific subdirectory
3. becomes trivial to understand which module to exercise
Only code movement + rename to be pep8 friendly.
Change-Id: I658ed91aafe017b965e858ff1eed42a26a797618
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M tests/device_test.py
A tests/virttests/devicexml_test.py
D tests/virttests/vmnic_test.py
M tests/vm_test.py
4 files changed, 461 insertions(+), 439 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72878
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I658ed91aafe017b965e858ff1eed42a26a797618
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: devices: extract common parsing function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: extract common parsing function
......................................................................
virt: devices: extract common parsing function
We want all the devices to be able to initialize themselves
from their XML representation.
We start isolating the code which update the state from the XML,
extracting one helper function that we will use in both paths.
Change-Id: I474f93e1b2e64c8212e2e087c864e3f49403b80f
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
M tests/virttests/devicexml_test.py
2 files changed, 72 insertions(+), 29 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I474f93e1b2e64c8212e2e087c864e3f49403b80f
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: devices: stop passing the 'conf' parameter
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: stop passing the 'conf' parameter
......................................................................
virt: devices: stop passing the 'conf' parameter
The device do not use the 'conf' attribute anymore,
so it is now time to remove it.
Change-Id: I4a65e566e3f6ff86c59dc979e7fd35573081b5d2
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
M lib/vdsm/virt/vmdevices/graphics.py
M lib/vdsm/virt/vmdevices/hostdevice.py
M lib/vdsm/virt/vmdevices/lease.py
M lib/vdsm/virt/vmdevices/network.py
M lib/vdsm/virt/vmdevices/storage.py
M tests/device_test.py
M tests/hostdev_test.py
M tests/virttests/vmlease_test.py
M tests/virttests/vmnic_test.py
M tests/vm_test.py
M tests/vmstorage_test.py
M vdsm/virt/vm.py
13 files changed, 134 insertions(+), 171 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a65e566e3f6ff86c59dc979e7fd35573081b5d2
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: devices: extract common parsing function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: extract common parsing function
......................................................................
Patch Set 23: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I474f93e1b2e64c8212e2e087c864e3f49403b80f
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: tests: consolidate the device XML tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: consolidate the device XML tests
......................................................................
Patch Set 23: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72878
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I658ed91aafe017b965e858ff1eed42a26a797618
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: virt: devices: stop passing the 'conf' parameter
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: stop passing the 'conf' parameter
......................................................................
Patch Set 24: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/70926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a65e566e3f6ff86c59dc979e7fd35573081b5d2
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: vmdevices: stop using self.conf
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: stop using self.conf
......................................................................
Patch Set 23: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/70925
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8918e8e073fc55f2bae3a74d6279bda062d9930
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: M.Z. <pdm(a)zamazal.org>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: io-tune: Cache io-tune policy in vdsm for faster reading
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: io-tune: Cache io-tune policy in vdsm for faster reading
......................................................................
io-tune: Cache io-tune policy in vdsm for faster reading
Previously io-tune policy was read from libvirt xml metadata.
Now, vdsm remembers what values were written to the metadata
and does not read it.
Change-Id: I995518af94ead3dff18b493e9cffe11e633eeccc
Bug-Url: https://bugzilla.redhat.com/1435218
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M lib/vdsm/virt/vmtune.py
M tests/vm_test.py
M vdsm/virt/vm.py
3 files changed, 100 insertions(+), 95 deletions(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Phillip Bailey: Looks good to me, but someone else must approve
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/74875
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I995518af94ead3dff18b493e9cffe11e633eeccc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months