Change in vdsm[master]: operation: Prepare for integrating CommandStream
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: operation: Prepare for integrating CommandStream
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/74618
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff363e710fcdc5d6cd5843ca2239973c89a69dd3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: api: provide correlation id
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: provide correlation id
......................................................................
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/75335/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-04-07 14:21:35 +0200
Line 4: Commit: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Line 5: CommitDate: 2017-04-07 14:21:35 +0200
Line 6:
Line 7: api: provide correlation id
you provide option field... part of it is the correlation id
Line 8:
Line 9: This patch added new parameter to each verb where we provide correlation
Line 10: id and remote address from where a verb was called. The parameter is a
Line 11: dictionary:
Line 6:
Line 7: api: provide correlation id
Line 8:
Line 9: This patch added new parameter to each verb where we provide correlation
Line 10: id and remote address from where a verb was called. The parameter is a
A caller will now provide those options in each call ? clients now do that?
can't we get the remote address from the connection details?
Line 11: dictionary:
Line 12:
Line 13: {'cid': '2729c8d7',
Line 14: 'remote_addr': 'localhost'}
https://gerrit.ovirt.org/#/c/75335/1/tests/schemavalidation_test.py
File tests/schemavalidation_test.py:
Line 135: default_args = ctor_defaults + self._get_default_args(
Line 136: method_obj)
Line 137:
Line 138: # check len equality
Line 139: if len(args) - 1 != len(method_args):
state in a comment why -1
Line 140: raise AssertionError(self._prep_msg(rep, method_args,
Line 141: args))
Line 142: for marg in method_args:
Line 143: # verify optional arg
--
To view, visit https://gerrit.ovirt.org/75335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73edc929e6d3e55d3f33a51229180ba35c52ac
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: automation: check-merged: use el7.3 VM as test VM
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: check-merged: use el7.3 VM as test VM
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75352
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32906c57b278d5447fbe961851b744c86cf3e37d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: automation: check-merged: use 'vm-type' instead of 'ovirt-role'
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: check-merged: use 'vm-type' instead of 'ovirt-role'
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75351
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice548f38efd67946921eb72ec72c0e8f3319c17b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: automation: check-merged: increase RAM size of the test VM t...
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: check-merged: increase RAM size of the test VM to 1GB
......................................................................
Patch Set 2: Code-Review+1
if CI guys are aware and accept that change - from vdsm prospective I ack. I think those kind of configurations should be in jenkins project side for the job if possible
--
To view, visit https://gerrit.ovirt.org/75350
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb4ca0af758e2a62d5e2a163458320b44c5325bc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: automation: check-merged: use 'lago collect' to collect logs
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: automation: check-merged: use 'lago collect' to collect logs
......................................................................
Patch Set 3: Code-Review+1
+2 from infra side. thanks!
--
To view, visit https://gerrit.ovirt.org/75349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc01427a02b3368d950db8d39d6b23860d61acb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: automation: check-merged: add '-x' flag to deploy.sh
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: automation: check-merged: add '-x' flag to deploy.sh
......................................................................
automation: check-merged: add '-x' flag to deploy.sh
To allow easier debugging why deploy.sh failed.
Backport-To: 4.1
Backport-To: 4.0
Change-Id: Id3c16cd034e30d0fc5391b58ff2ce12f9d0478e5
Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com>
---
M automation/deploy.sh
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75348
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3c16cd034e30d0fc5391b58ff2ce12f9d0478e5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: xmlrpc: set http 1.1 as default
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: xmlrpc: set http 1.1 as default
......................................................................
xmlrpc: set http 1.1 as default
Change-Id: I58e8045c3b98d14027ceb39686fbfcbd8f46c587
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/config.py.in
M lib/vdsm/xmlrpc.py
2 files changed, 1 insertion(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75299
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58e8045c3b98d14027ceb39686fbfcbd8f46c587
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: automation: check-merged: add '-x' flag to deploy.sh
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: automation: check-merged: add '-x' flag to deploy.sh
......................................................................
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/75348
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c16cd034e30d0fc5391b58ff2ce12f9d0478e5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: nics: list dpdk ports
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: nics: list dpdk ports
......................................................................
Patch Set 23: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/72308/23/lib/vdsm/network/link/dpdk.py
File lib/vdsm/network/link/dpdk.py:
PS23, Line 62: execCmd
> we should check the return code for easier debugging
correct. and raise an exception with stderr if rc!=0.
--
To view, visit https://gerrit.ovirt.org/72308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07f5a1052146c0eea6f0e19aa22d68ff4148646
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months