Change in vdsm[master]: ovs: support creating an ovs-dpdk setup
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: support creating an ovs-dpdk setup
......................................................................
Patch Set 16: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/71812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc2d2f5cbdce0c8b91a182414e5f032b81b4556
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: network: add special treatment for dpdk ports
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: add special treatment for dpdk ports
......................................................................
Patch Set 14: Code-Review-1
(2 comments)
minor nits
https://gerrit.ovirt.org/#/c/74079/14/lib/vdsm/network/link/dpdk.py
File lib/vdsm/network/link/dpdk.py:
Line 75:
Line 76: return False
Line 77:
Line 78:
Line 79: def speed(dev_name):
it's kinda-obvious, but please add a TODO about what each function should be doing.
Line 80: return 0
Line 81:
Line 82:
Line 83: def operstate(dev_name):
https://gerrit.ovirt.org/#/c/74079/14/lib/vdsm/network/link/iface.py
File lib/vdsm/network/link/iface.py:
Line 41: :param oper_blocking: Block until the link is operational.
Line 42: admin state is at kernel level, while link state is at driver level.
Line 43: """
Line 44: if dpdk.is_dpdk(dev):
Line 45: dpdk.up(dev)
just like in down() below, return dpdk.up() is the right thing to do here. We simply delegate the task to dpdk, doing nothing here.
Line 46: elif admin_blocking:
Line 47: _up_blocking(dev, oper_blocking)
Line 48: else:
Line 49: ipwrapper.linkSet(dev, [STATE_UP])
--
To view, visit https://gerrit.ovirt.org/74079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9376dd3ddc45a931dc286cc05d4e57016532058b
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: virt: periodic: expose the `discard` flag
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: periodic: expose the `discard` flag
......................................................................
virt: periodic: expose the `discard` flag
In commit 54b7981 the executor object gained support
for `discard` flag in dispatch().
This patch exposes it in the Operation class, making it possible
to have not-discardable periodic Operations.
Change-Id: Ib698478dc6d90212bd22f08671580a818e1afdc1
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/periodic.py
M tests/periodic_test.py
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified; Passed CI tests
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib698478dc6d90212bd22f08671580a818e1afdc1
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: periodic: HostMonitor: set not-discardable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: periodic: HostMonitor: set not-discardable
......................................................................
virt: periodic: HostMonitor: set not-discardable
Since we made HostMonitor one exclusive operation in change
I60ccd4e0e239ce5dfa2c90947bd6cd59a23e51b3
for the same reasons it also makes sense to set the `discard` flag
to False, so we have periodic reminder that the operation is stuck.
It works like this: with discard=False we implicitely schedule one
check after `timeout` seconds. If this fires, and if the worker is
stuck, one warning is emitted and the check is scheduled again
after `timeout` seconds.
This is indeed the behaviour we want there.
Please note that this change is a partial revert.
We need this because the executor 'periodic check,
not discard' feature was added while after the change
I60ccd4e0e239ce5dfa2c90947bd6cd59a23e51b3
Change-Id: If9d6923ad397c85909067747f0d7dd2a94dce8a1
Related-To: https://bugzilla.redhat.com/1419856
Backport-To: 4.1
Backport-To: 4.0
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/periodic.py
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified; Passed CI tests
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74492
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9d6923ad397c85909067747f0d7dd2a94dce8a1
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: periodic: docs: document the 'exclusive' parameter
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: periodic: docs: document the 'exclusive' parameter
......................................................................
periodic: docs: document the 'exclusive' parameter
Document the recently added 'exclusive' parameter
of periodic.Operation.
No code change.
Change-Id: I603cdd4b1ea44c628c542108fe9611a157eae09c
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/periodic.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified; Passed CI tests
Martin Polednik: Looks good to me, but someone else must approve
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/75135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I603cdd4b1ea44c628c542108fe9611a157eae09c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: periodic: docs: document the 'exclusive' parameter
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: periodic: docs: document the 'exclusive' parameter
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I603cdd4b1ea44c628c542108fe9611a157eae09c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: virt: periodic: expose the `discard` flag
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: periodic: expose the `discard` flag
......................................................................
Patch Set 7: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/74491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib698478dc6d90212bd22f08671580a818e1afdc1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: vmdevices: use default if no displayNetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmdevices: use default if no displayNetwork
......................................................................
vmdevices: use default if no displayNetwork
Fixes a bug introduced in e83e964e8647882d96028fa149ef78f5f0502272.
If no displayNetwork is selected by Graphics, we should use system
default. Otherwise we fail trying to concatenate None and str.
Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/graphics.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified
Francesco Romani: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: vmdevices: use default if no displayNetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: use default if no displayNetwork
......................................................................
Patch Set 3:
started hc suite: http://jenkins.ovirt.org/job/ovirt-system-tests_manual/198/
--
To view, visit https://gerrit.ovirt.org/75134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: vmdevices: use default if no displayNetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: use default if no displayNetwork
......................................................................
Patch Set 3: Verified+1
passes basic o-s-t: http://jenkins.ovirt.org/job/ovirt-system-tests_manual/197/
--
To view, visit https://gerrit.ovirt.org/75134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months