Change in vdsm[master]: yajsonrpc: replace functools.partial with wrapper
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: yajsonrpc: replace functools.partial with wrapper
......................................................................
yajsonrpc: replace functools.partial with wrapper
We do this because we want a nice __repr__ for the
JsonRpc Task, so we can properly log stuck JsonRPC workers.
Change-Id: I1b5fa82cf909b18243f68eb2eae625bf9b63112c
Bug-Url: https://bugzilla.redhat.com/1428415
Backport-To: 4.1
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/yajsonrpc/__init__.py
1 file changed, 19 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/75282
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b5fa82cf909b18243f68eb2eae625bf9b63112c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: lib: jsonrpc: use periodic warning on stuck worker
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: jsonrpc: use periodic warning on stuck worker
......................................................................
lib: jsonrpc: use periodic warning on stuck worker
In change 54b79818e17e44ba1acf7d47e79a7e7946b50b4f we added the option
to check and warn in the logs about stuck executor workers instead
of discarding them.
This patch uses this option for the jsonrpc workers, which were
among the hardest to troubleshoot in case of exausted executor pools.
Change-Id: I62db37cc411307322564edc467abcdff8278fbee
Bug-Url: https://bugzilla.redhat.com/1428415
Backport-To: 4.1
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/config.py.in
M lib/vdsm/rpc/bindingjsonrpc.py
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, but someone else must approve
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/75051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62db37cc411307322564edc467abcdff8278fbee
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: yajsonrpc: add __repr__ for jsonRpcRequest
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: yajsonrpc: add __repr__ for jsonRpcRequest
......................................................................
yajsonrpc: add __repr__ for jsonRpcRequest
Add a proper __repr__ so we can have maningful logs,
from which we can learn which request caused a JsonRPC
worker thread to get stuck.
Change-Id: I52b1c6bf6e92c374b9d3ac7a0b6abb43793ae339
Bug-Url: https://bugzilla.redhat.com/1428415
Backport-To: 4.1
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/yajsonrpc/__init__.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/75283
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52b1c6bf6e92c374b9d3ac7a0b6abb43793ae339
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: Don't eject CD forcefully
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Don't eject CD forcefully
......................................................................
virt: Don't eject CD forcefully
Changing or ejecting a CDs is performed forcefully, as with using a paperclip
on a physical device. The reason for doing that is described in
https://bugzilla.redhat.com/626334, which doesn't look like something valid
these days. Removing a CD forcefully, without notifying the guest OS, is
hardly a proper action and may cause confusion in the guest OS environment,
such as the CD being apparently still mounted and producing I/O errors when
trying to access it.
This patch makes the CD eject cleanly. Only if that attempt fails (and is
signaled as a failure from libvirt) then the CD is ejected forcefully. When a
CD is accessed while being ejected, there can still be problems, but at least
modern RHEL guest OS apparently handles the situation properly: The CD is
unmounted, no longer accessible, and another CD can be mounted.
A different situation is with changing the CD. When something accesses the CD,
such as a process having its current working directory there, weird things may
happen with either forceful or clean CD change. The change may not be properly
recognized, errors may happen when the CD is accessed, or the CD may not be
visible at all. Under such circumstances, when there is no clearly superior
option, it's better to stick with the current behavior. So we keep changing
CDs forceful.
Bug-Url: https://bugzilla.redhat.com/1428514
Backport-To: 4.1
Change-Id: I71067ea1783b1121bc318bfa2a6fec881938295b
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M tests/vm_test.py
M tests/vmfakelib.py
M vdsm/virt/vm.py
3 files changed, 33 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/74982
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71067ea1783b1121bc318bfa2a6fec881938295b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: Handle only libvirt errors in VM._changeBlockDev
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Handle only libvirt errors in VM._changeBlockDev
......................................................................
virt: Handle only libvirt errors in VM._changeBlockDev
We should handle only libvirt errors, not any random errors, there.
Change-Id: I0f14137bba8601efe21310f15c16de6f29314d42
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/75149
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f14137bba8601efe21310f15c16de6f29314d42
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: Make changeCD test use the current interface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Make changeCD test use the current interface
......................................................................
virt: Make changeCD test use the current interface
The test uses obsolete API arguments. Let's update it.
Change-Id: I3faed3b80b3cb5ebadf6dbbc64c5af1ba840d670
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M tests/vm_test.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/75148
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3faed3b80b3cb5ebadf6dbbc64c5af1ba840d670
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: Don't patch *VolumePath in test_change_cd_failures
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Don't patch *VolumePath in test_change_cd_failures
......................................................................
virt: Don't patch *VolumePath in test_change_cd_failures
There is no need to monkey patch those methods to make the test pass.
Actually patching prepareVolumePath leads to an XML error that is raised and
silently swallowed. In the result, we test for a failure, but a wrong failure:
Not the libvirt one, but the XML formatting failure.
We additionally need this fix for a followup patch where XML formatting is
taken out of the corresponding try...except block.
Backport-To: 4.1
Bug-Url: https://bugzilla.redhat.com/1428514
Change-Id: I303c1f84653b1a76008405904a22441873ddc224
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M tests/vm_test.py
1 file changed, 7 insertions(+), 12 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/75147
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I303c1f84653b1a76008405904a22441873ddc224
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: vm: support creating vhostuser interface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: support creating vhostuser interface
......................................................................
Patch Set 12:
(4 comments)
Don't you also need vm-wide definition ?
https://gerrit.ovirt.org/#/c/74327/12/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:
PS12, Line 226: downstream
CentOS 7. Would it be available in el7.4 ?
PS12, Line 228: https://bugzilla.redhat.com/show_bug.cgi?id=1281911
that's a cannot fix bug.
Please a bug that requests this in CentOS7's OvS; When the bug you give is fixed, we can move to dpdkvhostuserclient
https://gerrit.ovirt.org/#/c/74327/12/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
Line 116: [<outbound average="int" [burst="int"] [peak="int"]/>]
Line 117: </bandwidth>]
Line 118: </interface>
Line 119:
Line 120: -- In case of an ovs dpdk bridge --
please add after SR-IOV; In its current place, it makes the "slightly different" below wrong.
Line 121:
Line 122: <interface type="vhostuser">
Line 123: <address bus="0x00" domain="0x0000" slot="0x04" type="pci"/>
Line 124: <mac address="00:1a:4a:16:01:54"/>
Line 243: detach_detachable(self.hostdev)
Line 244: else:
Line 245: ovs_bridge = supervdsm.getProxy().ovs_bridge(self.network)
Line 246: if ovs_bridge is not None and ovs_bridge['dpdk']:
Line 247: self.device = 'vhostuser'
I feel very uncomfortable with this. self.device is always a hwclass element, never overridden by the device object during its lifetime. Please discuss this with petr/edy/francesco
Line 248:
Line 249: def teardown(self):
Line 250: if self.is_hostdevice:
Line 251: self.log.info('Reattaching device %s to host.' % self.hostdev)
--
To view, visit https://gerrit.ovirt.org/74327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: ovs driver: introduce add_vhostuser_port command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ovs driver: introduce add_vhostuser_port command
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie44fe082cffdaf3351450d55da7f48b2a9f7b315
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: network api: update ovs_bridge call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network api: update ovs_bridge call
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/74512/10/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
PS10, Line 151: print(ovs_bridge)
debug remnant?
--
To view, visit https://gerrit.ovirt.org/74512
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c98e4098d61b54300d144dc29b519ef3f431ad
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months