Change in vdsm[master]: vmdevices: use default if no displayNetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: use default if no displayNetwork
......................................................................
Patch Set 3:
ci please build
--
To view, visit https://gerrit.ovirt.org/75134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: mkimage: injectFilesToFs: check image location
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mkimage: injectFilesToFs: check image location
......................................................................
mkimage: injectFilesToFs: check image location
Make sure the image being mounted is in the payload directory. Don't
allow just any image to be mounted and altered.
Change-Id: Id87bb6776722906aef87e189eb36089307190a2b
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/mkimage.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74996
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id87bb6776722906aef87e189eb36089307190a2b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: supervdsm: mkimage: expose getFileName function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm: mkimage: expose getFileName function
......................................................................
supervdsm: mkimage: expose getFileName function
Change-Id: I9990d23185893146b26057405797e3bd4d99ac2d
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/mkimage.py
M lib/vdsm/supervdsm_api/mkimage.py
2 files changed, 5 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9990d23185893146b26057405797e3bd4d99ac2d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: generate XML files for automatic driver installation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: generate XML files for automatic driver installation
......................................................................
generate XML files for automatic driver installation
To get virtio support when installing Windows guest, user has to attach
floppy with virtio drivers and then manually load the drivers at the
beginning of the installation. By providing file Autounattend.xml with
paths to the drivers we can instruct windows to load the drivers
automatically and thus simplify the process for the user.
Unfortunately, due to various driver loading bugs in Windows, we cannot
have single XML file shared by all Windows version. The path to the
drivers must match only the drivers correct for the specific Windows
version being installed.
Change-Id: I784c4c83d5defcf425ff82b2d2b44288d7dcaae1
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M .gitignore
M static/Makefile.am
A static/usr/share/vdsm/autounattend/Autounattend.xml.in
M vdsm.spec.in
4 files changed, 94 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74252
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I784c4c83d5defcf425ff82b2d2b44288d7dcaae1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: mkimage: make sure proper owner/group is set on payload dire...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mkimage: make sure proper owner/group is set on payload directory
......................................................................
mkimage: make sure proper owner/group is set on payload directory
A minor fix to the creation of payload directory. In RPM package the
directory has vdsm/qemu as owner/group, but when the directory is
deleted and later recreated by supervdsm, owner/group remained set to
root. It is unlikely that this could have caused any real issues as only
supervdsm writes into that directory at the moment.
Change-Id: I26b03c250954d3fbd89292d962eb3329a50bafe5
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/mkimage.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74254
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I26b03c250954d3fbd89292d962eb3329a50bafe5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: mkimage: injectFilesToFs: fix owner and group
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mkimage: injectFilesToFs: fix owner and group
......................................................................
mkimage: injectFilesToFs: fix owner and group
Make sure the media has owner and group that suits the payload
directory. Supposing the caller has not taken care of that already.
Change-Id: Iaa00b49eb53aaa7ee10e353337f0762bc4ac54aa
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/mkimage.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74998
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa00b49eb53aaa7ee10e353337f0762bc4ac54aa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: mkimage: add _injectFilesToFs function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mkimage: add _injectFilesToFs function
......................................................................
mkimage: add _injectFilesToFs function
The change is just refactoring. The code for mounting and modifying the
floppy image is moved into separate function so it can be reused later.
Change-Id: Ieea3e91c1ce1a5f82a676e43fdf94d6e398158da
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/mkimage.py
1 file changed, 17 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74253
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieea3e91c1ce1a5f82a676e43fdf94d6e398158da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: supervdsm: mkimage: expose injectFilesToFs function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: supervdsm: mkimage: expose injectFilesToFs function
......................................................................
supervdsm: mkimage: expose injectFilesToFs function
Change-Id: Ib3f704bbbac9a2035fb1573792c3376ae50a2be6
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/mkimage.py
M lib/vdsm/supervdsm_api/mkimage.py
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3f704bbbac9a2035fb1573792c3376ae50a2be6
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: mkimage: injectFilesToFs: allow specifying file system type
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mkimage: injectFilesToFs: allow specifying file system type
......................................................................
mkimage: injectFilesToFs: allow specifying file system type
The image can potentially come from any source. In some cases it may be
good idea to constrain the file system to prevent probing.
Change-Id: I19472240601c41335c844c46ac3da9271925fea5
Signed-off-by: Tomáš Golembiovský <tgolembi(a)redhat.com>
---
M lib/vdsm/mkimage.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Verified
--
To view, visit https://gerrit.ovirt.org/74997
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19472240601c41335c844c46ac3da9271925fea5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: vdsm-tool: Don't configure firewalld unless required in vdsm...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Don't configure firewalld unless required in vdsm.conf
......................................................................
Patch Set 6: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/75099/6/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
PS6, Line 265: '
why's the apostrophe? (It may seem that I'm in a crusade against them...)
https://gerrit.ovirt.org/#/c/75099/6/lib/vdsm/tool/configurators/firewall...
File lib/vdsm/tool/configurators/firewalld.py:
Line 67: _add_to_required_services('vdsm.gluster.api', ('glusterfs', 'samba', 'nfs'))
Line 68: _add_to_required_services('cockpit', ('cockpit',))
Line 69:
Line 70:
Line 71: def configure():
to rephrase my comment:
if for some reason someone runs
vdsm-tool configure
without checking
vdsm-tool is-configured
first, your could would configure firewalld regardless of the value in vdsm.conf.
Line 72: if service_status('firewalld') == 1:
Line 73: service_start('firewalld')
Line 74:
Line 75: fw_client = FirewallClient()
--
To view, visit https://gerrit.ovirt.org/75099
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c46eb2915ef3cb31d4a494070db7ac430672601
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months