Change in vdsm[master]: lib: executor: handle timeout=None in __repr__
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: executor: handle timeout=None in __repr__
......................................................................
lib: executor: handle timeout=None in __repr__
After the change 54b79818e17e44ba1acf7d47e79a7e7946b50b4f we could have
timeout=None much more often.
This exposed one bug in the __repr__ method of executor.Task if timeout
is indeed None, the format string expodes with
File "/home/fromani/Projects/upstream/vdsm/lib/vdsm/executor.py", line 377, in __repr__
id(self)
TypeError: %d format: a number is required, not NoneType
This patch fixes that.
Change-Id: I5960673cd97e261d7296db27dd9a1c62931989ac
Bug-Url: https://bugzilla.redhat.com/1428415
Backport-To: 4.1
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/executor.py
M tests/executor_test.py
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/75059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5960673cd97e261d7296db27dd9a1c62931989ac
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: virt: metadata: add device support
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: metadata: add device support
......................................................................
virt: metadata: add device support
Add context manager to handle the per-device metadata.
We implement this on top of the VM metadata, so rewriting
any device metadata actually means rewriting *all* the
VM metadata.
The client code has to take explicit care of synchronizing
the accesses to the metadata section.
Change-Id: I99a9bee0c703e6be2530aa8faff65e5a0029b930
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/metadata.py
M tests/virttests/metadata_test.py
2 files changed, 185 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99a9bee0c703e6be2530aa8faff65e5a0029b930
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: virt: metadata: use errors.Base
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: use errors.Base
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38a345049928bbec3c398a3ab52fd51fe81f865d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: virt: metadata: generalize the device search
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: generalize the device search
......................................................................
Patch Set 11: Code-Review-1
only the doctext bothers me
--
To view, visit https://gerrit.ovirt.org/74770
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30748501da2e930f1d0eb18feef0d5a08e3a49e8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: virt: metadata: add device support
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: add device support
......................................................................
Patch Set 17: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/74232
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a9bee0c703e6be2530aa8faff65e5a0029b930
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: wip:dpdk: add dpdkvhostuser port
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: wip:dpdk: add dpdkvhostuser port
......................................................................
Patch Set 8: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/74327/8/lib/vdsm/network/ovs/switch.py
File lib/vdsm/network/ovs/switch.py:
Line 69: transaction = ovsdb.transaction()
Line 70: with transaction:
Line 71: transaction.add(ovsdb.add_port(bridge, port))
Line 72: transaction.add(ovsdb.set_vhostuser_port(bridge, port))
Line 73:
please hide in a private function and add a link to the OvS bug fixinging the need for that (and explaining the security problem here)
Line 74: uid = pwd.getpwnam("qemu").pw_uid
Line 75: gid = grp.getgrnam("kvm").gr_gid
Line 76: os.chown('/var/run/openvswitch/{}'.format(port), uid, gid)
Line 77:
https://gerrit.ovirt.org/#/c/74327/8/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
PS8, Line 197: vdsm.conf
I don't see us ever configuring a different path to ovs directory. But having a properly-named constant for this sounds right.
PS8, Line 198: .format
os.path.join() is better fitting.
--
To view, visit https://gerrit.ovirt.org/74327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: network api: update ovs_bridge call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network api: update ovs_bridge call
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/74512/8/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:
PS8, Line 154: is_dpdk
> please add to the schema, and make sure that is_bla naming fits (I think it
(only if this is exposed in getCapabilities, I'm not sure it does)
--
To view, visit https://gerrit.ovirt.org/74512
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c98e4098d61b54300d144dc29b519ef3f431ad
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: ovs driver: introduce add_vhostuser_port command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ovs driver: introduce add_vhostuser_port command
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie44fe082cffdaf3351450d55da7f48b2a9f7b315
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: network api: update ovs_bridge call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network api: update ovs_bridge call
......................................................................
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/74512/8/lib/vdsm/network/ovs/info.py
File lib/vdsm/network/ovs/info.py:
PS8, Line 154: is_dpdk
please add to the schema, and make sure that is_bla naming fits (I think it does not, just 'dpdk'=True/False is better).
https://gerrit.ovirt.org/#/c/74512/8/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
PS8, Line 150: ovs_bridge
need to update ovs_bridge documentation as well.
--
To view, visit https://gerrit.ovirt.org/74512
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02c98e4098d61b54300d144dc29b519ef3f431ad
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: ovs: support creating an ovs-dpdk setup
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: support creating an ovs-dpdk setup
......................................................................
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/71812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iadc2d2f5cbdce0c8b91a182414e5f032b81b4556
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month