Change in vdsm[master]: test: pass device in preserve_default_route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: test: pass device in preserve_default_route
......................................................................
test: pass device in preserve_default_route
Setting default route without device fails due to an
"invalid argument" error.
Change-Id: Ia003640b44c599b5bca5eb5467572f25a837a792
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/network/nettestlib.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/75129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia003640b44c599b5bca5eb5467572f25a837a792
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: test: pass device in preserve_default_route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: test: pass device in preserve_default_route
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/75129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia003640b44c599b5bca5eb5467572f25a837a792
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: vdsm-tool: Don't configure firewalld unless required in vdsm...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm-tool: Don't configure firewalld unless required in vdsm.conf
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/75099/4//COMMIT_MSG
Commit Message:
Line 7: vdsm-tool: Don't configure firewalld unless required in vdsm.conf
Line 8:
Line 9: Using the recently introduced firewalld_enable variable
Line 10: which determines whether or not firewalld should be enabled
Line 11: (and iptables' service disabled).
here, too, add Bug-Url https://bugzilla.redhat.com/show_bug.cgi?id=995362
Line 12:
Line 13: Change-Id: I0c46eb2915ef3cb31d4a494070db7ac430672601
--
To view, visit https://gerrit.ovirt.org/75099
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c46eb2915ef3cb31d4a494070db7ac430672601
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: test: pass device in preserve_default_route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: test: pass device in preserve_default_route
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia003640b44c599b5bca5eb5467572f25a837a792
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: virt: devices: stop passing the 'conf' parameter
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: stop passing the 'conf' parameter
......................................................................
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/70926/20/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:
PS20, Line 61: display_network
this should rebase on top of phoracek's fix, skipping create_libvirt_network if display_network is None.
--
To view, visit https://gerrit.ovirt.org/70926
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a65e566e3f6ff86c59dc979e7fd35573081b5d2
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: vm: graphics: handle missing displayNetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphics: handle missing displayNetwork
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/74976/1/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:
PS1, Line 63: display_network
as Sahina reported, this expoldes if displayNetwork is None.
--
To view, visit https://gerrit.ovirt.org/74976
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3daccec137cac92f224ecf0d83c2fb15024439b3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: API: replace validateMinimalKeySet
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: API: replace validateMinimalKeySet
......................................................................
Patch Set 11: Code-Review+1
I like anything that makes API.py a bit smaller.
--
To view, visit https://gerrit.ovirt.org/72374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc88ea8ec405974cc022be358f1ecb64242505b8
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: virt: periodic: HostMonitor: set not-discardable
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: periodic: HostMonitor: set not-discardable
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74492
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9d6923ad397c85909067747f0d7dd2a94dce8a1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: virt: periodic: expose the `discard` flag
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: periodic: expose the `discard` flag
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/74491/3/lib/vdsm/virt/periodic.py
File lib/vdsm/virt/periodic.py:
Line 151: Please note that timing may not be exact due to
Line 152: (OS) scheduling constraings.
Line 153: timeout: same meaning of Executor.dispatch
Line 154: scheduler: Scheduler instance to use
Line 155: executor: Executor instance to use
please document this new arg too, I find it a bit confusing.
Line 156: """
Line 157: self._func = func
Line 158: self._period = period
Line 159: self._timeout = _timeout_from(period) if timeout == 0 else timeout
--
To view, visit https://gerrit.ovirt.org/74491
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib698478dc6d90212bd22f08671580a818e1afdc1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: lib: jsonrpc: use periodic warning on stuck worker
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: jsonrpc: use periodic warning on stuck worker
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75051
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I62db37cc411307322564edc467abcdff8278fbee
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months