Change in vdsm[master]: virt: drop unused guests_gateway_ip
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: virt: drop unused guests_gateway_ip
......................................................................
virt: drop unused guests_gateway_ip
guests_gateway_ip is a prehistoric configurable, that has been
completely replaced by display network.
If it is ever used, it renderes a VM non-migratible (as the graphics
address on one host should not exist on the destination host, too).
This patch drops something that should have been removed many years ago,
with the introduction of libvirtvm.py.
Change-Id: Ia2e08388ffab439cb8985d4f220a410b4f6b6c90
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/config.py.in
M lib/vdsm/virt/vmdevices/graphics.py
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/75150/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 3fb17d5..53b30a9 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -414,8 +414,6 @@
'Set to "0.0.0.0" to listen only on IPv4. '
'Set to "::" to listen on both IPv4 & IPv6.'),
- ('guests_gateway_ip', '', None),
-
('broker_address', '127.0.0.1',
'Address where the broker is listening at. Use an empty string '
'for none'),
diff --git a/lib/vdsm/virt/vmdevices/graphics.py b/lib/vdsm/virt/vmdevices/graphics.py
index bb8aa9e..f5bf419 100644
--- a/lib/vdsm/virt/vmdevices/graphics.py
+++ b/lib/vdsm/virt/vmdevices/graphics.py
@@ -233,7 +233,7 @@
if network in nets else network)
ip, _, _, _ = net_api.ip_addrs_info(device)
except (libvirt.libvirtError, KeyError, IndexError):
- ip = config.get('addresses', 'guests_gateway_ip')
+ ip = '0'
finally:
if ip == '':
ip = '0'
--
To view, visit https://gerrit.ovirt.org/75150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2e08388ffab439cb8985d4f220a410b4f6b6c90
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years, 2 months
Change in vdsm[master]: cmdutils: Introduce the receive() helper
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: cmdutils: Introduce the receive() helper
......................................................................
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/74927/9//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2017-03-28 03:38:45 +0300
Line 4: Commit: Nir Soffer <nsoffer(a)redhat.com>
Line 5: CommitDate: 2017-04-03 01:19:15 +0300
Line 6:
Line 7: [RFC] procutils: Introduce the procutils module
> OK, tried that, but commands is not python 3 compatible because of AsyncPro
ok
Line 8:
Line 9: This module provide utilities for working with subprocesses.
Line 10:
Line 11: The first utility is procutils.communicate(), replacing both AsyncProc,
--
To view, visit https://gerrit.ovirt.org/74927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d193caa5da0ed564b4fab12aa85e3751f1a1df7
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: operation: Support streaming command output
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: operation: Support streaming command output
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75008
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I976314ce3e9a1b4ba77d74c3c1ad742cc0e9fe80
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: cmdutils: Introduce the receive() helper
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: cmdutils: Introduce the receive() helper
......................................................................
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/74927/11//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-04-03 21:56:56 +0300
Line 6:
Line 7: cmdutils: Introduce the receive() helper
Line 8:
Line 9: cmdutils.receive() replaces both both commands.AsyncProc and
remove one both
Line 10: utils.CommandStream. This function allows reading from sub process
Line 11: stdout and stderr in the same time, without using callbacks as in
Line 12: utils.CommandStream, and avoiding the performance issues and the
Line 13: complexity of utils.AsyncProc. This function is also python 3
Line 10: utils.CommandStream. This function allows reading from sub process
Line 11: stdout and stderr in the same time, without using callbacks as in
Line 12: utils.CommandStream, and avoiding the performance issues and the
Line 13: complexity of utils.AsyncProc. This function is also python 3
Line 14: compatible.
all new code is py3 compatible.. no need to mention imo
Line 15:
Line 16: cmdutils.receive() does not support writing to and reading from a sub
Line 17: process in one thread in the same time. This is supported by
Line 18: commands.AsyncProc, but I don't know of any real world use case for
--
To view, visit https://gerrit.ovirt.org/74927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d193caa5da0ed564b4fab12aa85e3751f1a1df7
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: vmdevices: use default if no displayNetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: use default if no displayNetwork
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/75134/2/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:
Line 235: # the device is defaulted to the network name (i.e. northbound port).
Line 236: device = (nets[network].get('iface', network)
Line 237: if network in nets else network)
Line 238: ip, _, _, _ = net_api.ip_addrs_info(device)
Line 239: # TODO: is this still an option with on-demand created networks?
> I don't understand this TODO.
maybe I do. please rebase on top of https://gerrit.ovirt.org/#/c/75150/
Line 240: except (libvirt.libvirtError, KeyError, IndexError):
Line 241: ip = config.get('addresses', 'guests_gateway_ip')
Line 242: finally:
Line 243: if ip == '':
--
To view, visit https://gerrit.ovirt.org/75134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: vmdevices: use default if no displayNetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmdevices: use default if no displayNetwork
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/75134/2/lib/vdsm/virt/vmdevices/graphics.py
File lib/vdsm/virt/vmdevices/graphics.py:
PS2, Line 67: guests_gateway_ip
this is an ancient sh*t that nobody is using (or at least should be using). Please don't duplicate it here - it's more than enough in _getNetworkIp.
If displayNetwork is not specified, we listen on everything ('0'). With any other value, the VM would not be migratable.
Line 235: # the device is defaulted to the network name (i.e. northbound port).
Line 236: device = (nets[network].get('iface', network)
Line 237: if network in nets else network)
Line 238: ip, _, _, _ = net_api.ip_addrs_info(device)
Line 239: # TODO: is this still an option with on-demand created networks?
I don't understand this TODO.
Line 240: except (libvirt.libvirtError, KeyError, IndexError):
Line 241: ip = config.get('addresses', 'guests_gateway_ip')
Line 242: finally:
Line 243: if ip == '':
--
To view, visit https://gerrit.ovirt.org/75134
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb016d002b507d6c9b31f5f628ba4d8fa3543a12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: virt: metadata: generalize the device search
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: metadata: generalize the device search
......................................................................
virt: metadata: generalize the device search
until we get client-supplied alias, we must be able to lookup device
using attribute matching.
Thus, generalize how we search them.
Change-Id: I30748501da2e930f1d0eb18feef0d5a08e3a49e8
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/metadata.py
M tests/virttests/metadata_test.py
2 files changed, 112 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74770
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30748501da2e930f1d0eb18feef0d5a08e3a49e8
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: metadata: use errors.Base
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: metadata: use errors.Base
......................................................................
virt: metadata: use errors.Base
metadata.Error should inherit from errors.Base, to comply
with the Vdsm best practices.
Change-Id: I38a345049928bbec3c398a3ab52fd51fe81f865d
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/metadata.py
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/75117
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a345049928bbec3c398a3ab52fd51fe81f865d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: virt: metadata: generalize the device search
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: metadata: generalize the device search
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74770
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30748501da2e930f1d0eb18feef0d5a08e3a49e8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: tests: use ipv6 gateway properly in preserve_default_route
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: use ipv6 gateway properly in preserve_default_route
......................................................................
tests: use ipv6 gateway properly in preserve_default_route
Fixing a typo in preserve_default_route where set_default_route
received an ipv4 address while trying to set ipv6 default route.
Change-Id: I0668dfd2337d50da4aad1dd036a8d520973d5aa7
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/network/nettestlib.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/75095
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0668dfd2337d50da4aad1dd036a8d520973d5aa7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months