From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Provide an alternative to libvirt.is_libvirt_device
......................................................................
net: Provide an alternative to libvirt.is_libvirt_device
The dhclient_monitor has been using libvirt.is_libvirt_device to
determine if a processed interface belongs to an owned network.
As part of the effort to remove the dependency on libvirt and to
correctly check for network interfaces, the networks_northbound_ifaces
is introduced, reporting all the northbound ifaces of all networks.
Change-Id: Ia0b4fc20a65137e5f40ebc624b18b140f6bdd32c
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/dhclient_monitor.py
M lib/vdsm/network/kernelconfig.py
M lib/vdsm/network/libvirt.py
M tests/functional/networkTests.py
4 files changed, 22 insertions(+), 37 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia0b4fc20a65137e5f40ebc624b18b140f6bdd32c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: Clean libvirt related mock leftovers
......................................................................
net tests: Clean libvirt related mock leftovers
Change-Id: If467d0a7b0dacf1f92983bc9a7cf7abe7c4c8bd4
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M tests/network/config_network_test.py
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74592
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If467d0a7b0dacf1f92983bc9a7cf7abe7c4c8bd4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Clean libvirt related mock leftovers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/74592
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If467d0a7b0dacf1f92983bc9a7cf7abe7c4c8bd4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Cleanup configurator backup of libvirt nets
......................................................................
net: Cleanup configurator backup of libvirt nets
Backup and restoration of libvirt networks is no longer needed, cleaning
the remaining code.
Change-Id: Ia412eed97a69c3af9f21556103783e5c48ec5bbc
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/libvirt.py
4 files changed, 3 insertions(+), 46 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia412eed97a69c3af9f21556103783e5c48ec5bbc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Drop libvirt network removal from setup network flow
......................................................................
net: Drop libvirt network removal from setup network flow
Libvirt networks are now removed at netupgrade step and are no longer
removed in the setup networks flow.
This patch compliments the removal of libvirt networks creation and
decouples host networking from libvirt.
The only reference left to libvirt is in the netupgrade step.
Change-Id: I47132e05de01de04d669b824766b9661ae460e00
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/netupgrade.py
M tests/network/netupgrade_test.py
6 files changed, 35 insertions(+), 29 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/74494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47132e05de01de04d669b824766b9661ae460e00
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Provide an alternative to libvirt.is_libvirt_device
......................................................................
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/74579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0b4fc20a65137e5f40ebc624b18b140f6bdd32c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Cleanup configurator backup of libvirt nets
......................................................................
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/74548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia412eed97a69c3af9f21556103783e5c48ec5bbc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Drop libvirt network removal from setup network flow
......................................................................
Patch Set 5: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/74494
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47132e05de01de04d669b824766b9661ae460e00
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: shortcut for ipv6 incapable system
......................................................................
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/75588/6//COMMIT_MSG
Commit Message:
PS6, Line 9: load
loaded
Line 8:
Line 9: If IPv6 kmod is not load it raises problems with
Line 10: 'No such file or directory /proc/sys/net/ipv6/...'.
Line 11:
Line 12: This bug caused problems for OVS switch on ipv6-disabled systems.
can you point to a bugzilla or mailing discussing this?
Line 13:
Line 14: Change-Id: I54c2c04b79582d04b08e3198dad80b0796993aca
--
To view, visit https://gerrit.ovirt.org/75588
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54c2c04b79582d04b08e3198dad80b0796993aca
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: fix typo in comment
......................................................................
fix typo in comment
Change-Id: Icc8523b3c7ac82d4898fc4a610dc182e6b26c334
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/testValidation.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/75729/1
diff --git a/tests/testValidation.py b/tests/testValidation.py
index b5d0357..d4a8c80 100644
--- a/tests/testValidation.py
+++ b/tests/testValidation.py
@@ -71,7 +71,7 @@
build and may fail on overloaded machines or machines with unpreditable
resources.
- These tests are mark with @stresstest decorator and are diabled by default.
+ These tests are mark with @stresstest decorator and are disabled by default.
Use this plugin to enable these tests.
"""
name = 'stresstests'
--
To view, visit https://gerrit.ovirt.org/75729
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc8523b3c7ac82d4898fc4a610dc182e6b26c334
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>