vdsm-patches April 2017

vdsm-patches@lists.fedorahosted.org

1 participants
306 discussions

Change in vdsm[master]: xmlrpc: silence pylint import-error
by Code Review 21 Apr '17

21 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has uploaded a new change for review. Change subject: xmlrpc: silence pylint import-error ...................................................................... xmlrpc: silence pylint import-error Change-Id: I44c2bb08c83fd0e7f55670f405dba653bb869b83 Signed-off-by: Dan Kenigsberg <danken(a)redhat.com> --- M lib/vdsm/xmlrpc.py 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/27/75727/1 diff --git a/lib/vdsm/xmlrpc.py b/lib/vdsm/xmlrpc.py index fabdac3..e0f3aff 100644 --- a/lib/vdsm/xmlrpc.py +++ b/lib/vdsm/xmlrpc.py @@ -21,8 +21,7 @@ from __future__ import absolute_import import logging -from six.moves.xmlrpc_server import SimpleXMLRPCDispatcher -from six.moves.xmlrpc_server import SimpleXMLRPCRequestHandler +from six.moves import xmlrpc_server import socket import sys @@ -30,12 +29,12 @@ from .executor import TaskQueue -class IPXMLRPCRequestHandler(SimpleXMLRPCRequestHandler): +class IPXMLRPCRequestHandler(xmlrpc_server.SimpleXMLRPCRequestHandler): protocol_version = "HTTP/1.1" -class SimpleThreadedXMLRPCServer(SimpleXMLRPCDispatcher): +class SimpleThreadedXMLRPCServer(xmlrpc_server.SimpleXMLRPCDispatcher): """ This server does not listen to to connections; the user is responsible for accepting connections and adding them to the server. @@ -50,8 +49,9 @@ def __init__(self, requestHandler=IPXMLRPCRequestHandler, logRequests=False, allow_none=False, encoding=None): - SimpleXMLRPCDispatcher.__init__(self, allow_none=allow_none, - encoding=encoding) + xmlrpc_server.SimpleXMLRPCDispatcher.__init__( + self, allow_none=allow_none, + encoding=encoding) self.requestHandler = requestHandler self.logRequests = logRequests -- To view, visit https://gerrit.ovirt.org/75727 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44c2bb08c83fd0e7f55670f405dba653bb869b83 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>

1 2

Change in vdsm[master]: monitor: Fix pylint error when invoking callabck
by Code Review 21 Apr '17

21 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: monitor: Fix pylint error when invoking callabck ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/75736 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f7ac8e842d415b7fe457875529abcae35ddcaec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: nics: list dpdk ports
by Code Review 21 Apr '17

21 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: nics: list dpdk ports ...................................................................... nics: list dpdk ports dpdk ports can't be seen by kernel tools. We wish to know which dpdk ports are in the system in order to bind them to ovs-dpdk bridge. We query 'lshw -json' in order to get a json formatted response of system devices, take only network class devices which have a 'handle' key and don't have logical name - meaning they are physical network devices which are not recognized by the kernel. Also, added fake network info for dpdk ports. Change-Id: Ia07f5a1052146c0eea6f0e19aa22d68ff4148646 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M automation/build-artifacts.packages.el7 M automation/build-artifacts.packages.fc25 M automation/check-merged.packages.el7 M automation/check-patch.packages.el7 M automation/check-patch.packages.fc25 A lib/vdsm/network/link/dpdk.py A tests/network/dpdk_test.py M vdsm.spec.in 8 files changed, 228 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Verified Edward Haas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/72308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia07f5a1052146c0eea6f0e19aa22d68ff4148646 Gerrit-PatchSet: 36 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: nics: list dpdk ports
by Code Review 21 Apr '17

21 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: nics: list dpdk ports ...................................................................... Patch Set 35: Verified+1 same as verified PS32 -- To view, visit https://gerrit.ovirt.org/72308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07f5a1052146c0eea6f0e19aa22d68ff4148646 Gerrit-PatchSet: 35 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[ovirt-4.1]: image: typo leading to AttributeError
by Code Review 20 Apr '17

20 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: image: typo leading to AttributeError ...................................................................... image: typo leading to AttributeError dstSdUUID and dstVolFormat should be separated by a comma, by mistake it was added as a dot as part of change I6a0aacc8c663. Change-Id: Ie399364218643ec5c7ea58a4a332426a42db1ee0 Bug-Url: https://bugzilla.redhat.com/1358717 Bug-Url: https://bugzilla.redhat.com/1419240 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M vdsm/storage/image.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Maor Lipchuk: Verified Liron Aravot: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie399364218643ec5c7ea58a4a332426a42db1ee0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[ovirt-4.1]: image: typo leading to AttributeError
by Code Review 20 Apr '17

20 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: image: typo leading to AttributeError ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/75697 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie399364218643ec5c7ea58a4a332426a42db1ee0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: API: replace validateMinimalKeySet
by Code Review 20 Apr '17

20 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: API: replace validateMinimalKeySet ...................................................................... API: replace validateMinimalKeySet Now that we have proper exception support, we can replace this utility function with new smaller code, achieving the same goal with less boilerplate. We took this chance to bootstrap the 'validate' module, which will hold any validation function we may need in the future. Change-Id: Ibc88ea8ec405974cc022be358f1ecb64242505b8 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M lib/vdsm/common/exception.py A lib/vdsm/common/validate.py M lib/vdsm/utils.py M tests/Makefile.am A tests/validate_test.py M vdsm/API.py 6 files changed, 92 insertions(+), 65 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/72374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc88ea8ec405974cc022be358f1ecb64242505b8 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: API: replace validateMinimalKeySet
by Code Review 20 Apr '17

20 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: API: replace validateMinimalKeySet ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/72374 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc88ea8ec405974cc022be358f1ecb64242505b8 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

Change in vdsm[master]: docs: executor: document Executor.dispatch()
by Code Review 20 Apr '17

20 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has submitted this change and it was merged. Change subject: docs: executor: document Executor.dispatch() ...................................................................... docs: executor: document Executor.dispatch() Fix the documentation of the `Executor.dispatch` method to reflect the last changes. No code changes, only docstring. Change-Id: I9fa8e03a43e0852c8ebed84a3fb7d0256e083fb3 Signed-off-by: Francesco Romani <fromani(a)redhat.com> --- M lib/vdsm/executor.py 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/75209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9fa8e03a43e0852c8ebed84a3fb7d0256e083fb3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in vdsm[master]: docs: executor: document Executor.dispatch()
by Code Review 20 Apr '17

20 Apr '17

From Dan Kenigsberg <danken(a)redhat.com>: Dan Kenigsberg has posted comments on this change. Change subject: docs: executor: document Executor.dispatch() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/75209 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9fa8e03a43e0852c8ebed84a3fb7d0256e083fb3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-HasComments: No

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

vdsm-patches April 2017