Change in vdsm[master]: lib: dmidecode: suppress bogus pylint warning
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: lib: dmidecode: suppress bogus pylint warning
......................................................................
lib: dmidecode: suppress bogus pylint warning
We got a pylint complain about dmidecodeUtil:
E: 44,22: Module 'dmidecode' has no 'system' member (no-member)
This is likely caused by this star-import as the very
beginning of dmidecode.py:
from dmidecodemod import *
(dmidecode.py doesn't define system() and gets it from dmidecodemod.so)
Thus, at runtime we have this method, but no static analysis tool
can detect it.
This patch suppress the unhelpful pylint warning.
Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/dmidecodeUtil.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Edward Haas: Verified; Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: lib: dmidecode: suppress bogus pylint warning
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: dmidecode: suppress bogus pylint warning
......................................................................
Patch Set 1:
I hate it, don't understand it, but let us take it in.
--
To view, visit https://gerrit.ovirt.org/76977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: logUtils: Move logUtils module to vdsm.common
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: logUtils: Move logUtils module to vdsm.common
......................................................................
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/76919/9/vdsm.spec.in
File vdsm.spec.in:
Line 803: # So Remove them if it is played with /etc/sysctl.conf.
Line 804: if grep -q "# VDSM section begin" /etc/sysctl.conf; then
Line 805: /bin/sed -i '/# VDSM section begin/,/# VDSM section end/d' \
Line 806: /etc/sysctl.conf
Line 807: fi
quite yucky but you could add
# REQUIRED_FOR upgrade from vdsm<=4.19
grep -q vdsm.logUtils /etc/vdsm/logger.conf && sed -i s/vdsm.logUtils/vdsm.common.logutils/ /etc/vdsm/logger.conf
to allow upgrade of folks who edited that file.
Line 808:
Line 809: # VDSM installs vdsm-modules-load.d.conf file - the following command will
Line 810: # refresh vdsm kernel modules requirements to start on boot
Line 811: /bin/systemctl restart systemd-modules-load.service >/dev/null 2>&1 || :
--
To view, visit https://gerrit.ovirt.org/76919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic642205e3d5515acfeb607bb5dcad24f699d286f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: logUtils: Move logUtils module to vdsm.common
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: logUtils: Move logUtils module to vdsm.common
......................................................................
Patch Set 9: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/76919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic642205e3d5515acfeb607bb5dcad24f699d286f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: logUtils: Move logUtils module to vdsm.common
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: logUtils: Move logUtils module to vdsm.common
......................................................................
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/76919/8/static/etc/vdsm/logger.conf.in
File static/etc/vdsm/logger.conf.in:
Line 60: formatter=sysform
Line 61: args=('/dev/log', handlers.SysLogHandler.LOG_USER)
Line 62:
Line 63: [handler_logfile]
Line 64: class=vdsm.common.logutils.UserGroupEnforcingHandler
> Sadly, this two little ones cost me 1h figuring out why the services crashe
this is actually a big problem. if someone editted this file, it would not be replaced on upgrade, and they would be left with a reference to a non-existing object.
we're kinda doomed. either keep vdsm.logUtils refering the new location, or provide a little 'sed' fixing the log file on upgrade.
Line 65: args=('@VDSMUSER@', '@VDSMGROUP@', '@VDSMLOGDIR(a)/vdsm.log',)
Line 66: filters=storage.misc.TracebackRepeatFilter
Line 67: level=DEBUG
Line 68: formatter=long
--
To view, visit https://gerrit.ovirt.org/76919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic642205e3d5515acfeb607bb5dcad24f699d286f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: utils: Extract CommandPath from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract CommandPath from utils module
......................................................................
utils: Extract CommandPath from utils module
CommandPath has been relocated to common.cmdutils, to make it clearer
that it is being used by multiple subsystems, and verifying that it
has no dependencies on on non-common vdsm code.
Change-Id: I7cd1021c37205ab2f10c653ab1ee961a0bad919f
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/alignmentScan.py
A lib/vdsm/common/cmdutils.py
M lib/vdsm/gluster/api.py
M lib/vdsm/gluster/cli.py
M lib/vdsm/gluster/storagedev.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/ip/dhclient.py
M lib/vdsm/network/ipwrapper.py
M lib/vdsm/network/nm/networkmanager.py
M lib/vdsm/network/ovs/driver/vsctl.py
M lib/vdsm/numa.py
M lib/vdsm/qemuimg.py
M lib/vdsm/storage/blkdiscard.py
M lib/vdsm/storage/curlImgWrap.py
M lib/vdsm/storage/multipath.py
M lib/vdsm/supervdsm_api/containers.py
M lib/vdsm/supervdsm_api/systemd.py
M lib/vdsm/tool/configurators/lvm.py
M lib/vdsm/tool/configurators/passwd.py
M lib/vdsm/tool/service.py
M lib/vdsm/tool/transient.py
M lib/vdsm/udevadm.py
M lib/vdsm/utils.py
M lib/vdsm/v2v.py
M lib/vdsm/virt/containers/command.py
M lib/vdsm/virt/containers/docker.py
M lib/vdsm/virtsparsify.py
M lib/vdsm/virtsysprep.py
A tests/common/cmdutils_test.py
M tests/containers/conttestlib.py
M tests/functional/networkTests.py
M tests/functional/virtTests.py
M tests/modprobe.py
M tests/network/dhcp.py
M tests/network/firewall.py
M tests/network/nettestlib.py
M tests/network/nmnettestlib.py
M tests/utils_test.py
M tests/v2v_test.py
M tests/virttests/seal_job_test.py
M vdsm/storage/curl-img-wrap
M vdsm_hooks/ethtool_options/ethtool_options.py
M vdsm_hooks/openstacknet/openstacknet_utils.py
43 files changed, 240 insertions(+), 188 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cd1021c37205ab2f10c653ab1ee961a0bad919f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: utils: Extract CommandPath from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Extract CommandPath from utils module
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76894
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cd1021c37205ab2f10c653ab1ee961a0bad919f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: hooks: do not use vm.conf directly
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: do not use vm.conf directly
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/76311/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2153: # on this flow. Issues:
Line 2154: # - we will also call the more specific before_vm_dehibernate
Line 2155: # - we feed the hook with wrong XML
Line 2156: # - we ignore the output of the hook
Line 2157: hooks.before_vm_start(self._buildDomainXML(), self._custom)
!
Line 2158:
Line 2159: fromSnapshot = self.conf.get('restoreFromSnapshot', False)
Line 2160: with self._confLock:
Line 2161: srcDomXML = self.conf.pop('_srcDomXML')
--
To view, visit https://gerrit.ovirt.org/76311
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d7392fcfd82b7701d9007c1340909d6d2b74aae
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: lib: dmidecode: suppress bogus pylint warning
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: lib: dmidecode: suppress bogus pylint warning
......................................................................
Patch Set 1:
but how can it pass check-patch even without this?
--
To view, visit https://gerrit.ovirt.org/76977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d6aaa0d25e79fbe2dac851a62bcde36e8f7cf62
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: ssl: remove m2crypto
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: remove m2crypto
......................................................................
Patch Set 9:
ci please build
--
To view, visit https://gerrit.ovirt.org/76027
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab4f2f745e19d90dbb10206a96bdbd29fd77a420
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years