Change in vdsm[master]: network: wrap rule.py add/del exceptions with IPRuleError
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: wrap rule.py add/del exceptions with IPRuleError
......................................................................
network: wrap rule.py add/del exceptions with IPRuleError
Change-Id: I6c426ad2d5f8fb660cc0fee782ce865772831e4e
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ip/rule/__init__.py
M tests/network/ip_rule_test.py
2 files changed, 33 insertions(+), 14 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76520
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c426ad2d5f8fb660cc0fee782ce865772831e4e
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: network: prepare ip_rule_test for different implementations
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: prepare ip_rule_test for different implementations
......................................................................
network: prepare ip_rule_test for different implementations
Change-Id: Ie0c6093745ac31d0d40eece976f2564531f57843
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M tests/network/__init__.py
M tests/network/ip_rule_test.py
2 files changed, 18 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0c6093745ac31d0d40eece976f2564531f57843
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: network: split ip.rule api and implementation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: split ip.rule api and implementation
......................................................................
network: split ip.rule api and implementation
Prepare ground for different IPRuleApi implementations (such as
NetworkManager one) by splitting API and its iproute2 implementation.
Change-Id: Ibcc3bbc7f1d1fa5d1f3e9f2cdbc297da18e71b4f
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/ip/rule/__init__.py
A lib/vdsm/network/ip/rule/iproute2.py
M lib/vdsm/network/sourceroute.py
M tests/network/__init__.py
M tests/network/ip_rule_test.py
5 files changed, 100 insertions(+), 50 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76521
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcc3bbc7f1d1fa5d1f3e9f2cdbc297da18e71b4f
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: network: add driverloader module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: add driverloader module
......................................................................
network: add driverloader module
DriverLoader class provides tools to gather and provide drivers
(interface implementations).
In this patch we use it just for ip.route and ip.rule. In following
patches we will use this also for OVS and bonding drivers.
Change-Id: I4c15594a0cb99273f4d1b71b8403be6e64b87f15
Signed-off-by: Petr Horacek <phoracek(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/driverloader.py
M lib/vdsm/network/ip/route/__init__.py
M lib/vdsm/network/ip/rule/__init__.py
A tests/network/driverloader_test.py
M tests/network/ip_route_test.py
M vdsm.spec.in
7 files changed, 90 insertions(+), 48 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76719
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c15594a0cb99273f4d1b71b8403be6e64b87f15
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horacek <phoracek(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: dmidecode: collect only system info
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dmidecode: collect only system info
......................................................................
dmidecode: collect only system info
We report only system related info in getHardwareInfo so
collecting other verbs is unnecessary.
Change-Id: I97488bf273d69eb987360da152d712dde6d2167a
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1447454
---
M lib/vdsm/dmidecodeUtil.py
1 file changed, 7 insertions(+), 14 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/76687
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97488bf273d69eb987360da152d712dde6d2167a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Introducing validate_bond_names to netswitch validators
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Introducing validate_bond_names to netswitch validators
......................................................................
net: Introducing validate_bond_names to netswitch validators
There is no difference in the definition of valid bond names
between OVS and legacy switch. As such, bond name validation
was moved upwards to netswitch validators.
Besides checking for valid bond names upon bond creation,
we're now also checking the names of externally created bonds
that networks are being set on.
Change-Id: I02923dd6d1c444b6b6e7678e0b8af0d078202edc
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/models.py
M lib/vdsm/network/netswitch/configurator.py
M lib/vdsm/network/netswitch/validator.py
M tests/network/models_test.py
M tests/network/netswitch_test.py
6 files changed, 54 insertions(+), 21 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02923dd6d1c444b6b6e7678e0b8af0d078202edc
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net tests: Migrating testFailWithInvalidBondingName to the n...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: Migrating testFailWithInvalidBondingName to the new functional tests.
......................................................................
net tests: Migrating testFailWithInvalidBondingName to the new
functional tests.
Change-Id: I59be49903fc757f6c45276ecef68900af5140f53
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/functional/networkTests.py
M tests/network/func_bond_basic_test.py
M tests/network/func_net_with_bond_test.py
3 files changed, 30 insertions(+), 13 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76428
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59be49903fc757f6c45276ecef68900af5140f53
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net tests: testing sb validations using dedicated function
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: testing sb validations using dedicated function
......................................................................
net tests: testing sb validations using dedicated function
Instead of using the general validate functions, now using
the dedicated validate_southbound_devices_usages function.
Change-Id: I67991a792023c91d38dd66d174a791a17b7ed3e4
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M tests/network/netswitch_test.py
1 file changed, 12 insertions(+), 31 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67991a792023c91d38dd66d174a791a17b7ed3e4
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: ssl: remove m2crypto
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: remove m2crypto
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76027
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab4f2f745e19d90dbb10206a96bdbd29fd77a420
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: Remove redundant code for prepare volume path
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Remove redundant code for prepare volume path
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73573/1//COMMIT_MSG
Commit Message:
Line 7: Remove redundant code for prepare volume path
Line 8:
Line 9: Follow a comment that suggests to remove a particular piece of
Line 10: code once engine 3.3 won't be supported as this code handles
Line 11: an input that is not generated by later versions of engine.
The down side is that old VMs, started by Engine-3.2 but still alive, would fail to migrate to 4.2. I think we can live with that, but it should be acknowledged here.
Line 12:
Line 13: The down side is that old VMs, started by Engine-3.2 but still
Line 14: alive, would fail to migrate to a 4.2 host.
Line 15:
--
To view, visit https://gerrit.ovirt.org/73573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9eb2f8fe53af5eb8e923c40eac3c9db8d6be9ad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years