Change in vdsm[master]: automation: add pylint to check target
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: automation: add pylint to check target
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/76390/5//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2017-05-11 11:46:36 +0300
Line 6:
Line 7: automation: add pylint to check target
Line 8:
Line 9: Adding pylint to make check.
the commit message is not clear here. most developers just run `make check`. You should warn them that from now on, they'd better add --jobs=2
Line 10:
Line 11: Running a local build, the average time for running 'make check' is:
Line 12:
Line 13: With 1 job:
--
To view, visit https://gerrit.ovirt.org/76390
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a14a4d1a0f37397d1f5f89f33517ee87e95eb28
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: automation: run check target in parallel
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: automation: run check target in parallel
......................................................................
Patch Set 3: Code-Review+1
please warn in the commit message that the change makes the output interleaved.
I think that it is a price that we should pay to run faster.
--
To view, visit https://gerrit.ovirt.org/76446
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3eb92096ce9a1c4d008ece0536b4cd7805d9988
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: net: Remove network.utils
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Remove network.utils
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76393
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id7924f0acc231e706ab0e24436e1130313073846
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: dmidecode: don't assume dmidecode output is ok
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: dmidecode: don't assume dmidecode output is ok
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/76671/1/lib/vdsm/dmidecodeUtil.py
File lib/vdsm/dmidecodeUtil.py:
Line 29: # value for each key. Keys in d that their value is a dictionary will be
Line 30: # ignored because those keys define a lable for the sub dictionary
Line 31: # (and those keys are irrelevant for us in dmidecode output)
Line 32: def __leafDict(d):
Line 33: ret = {}
why do you do it in such a low location? why do you do it at all? When does dmidecode fail, and how?
can you please elaborate in the commit message?
Line 34: try:
Line 35: for k, v in d.iteritems():
Line 36: if isinstance(v, dict):
Line 37: ret.update(__leafDict(v))
--
To view, visit https://gerrit.ovirt.org/76671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bd4cc123bd1c20a5bdac6d9befa60bc9783263c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: utils: Drop unused utils.forceLink
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Drop unused utils.forceLink
......................................................................
utils: Drop unused utils.forceLink
Change-Id: I7395dea4ea79b9c5ac1a80e2b36fb37ab4481a7d
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/utils.py
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76601
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7395dea4ea79b9c5ac1a80e2b36fb37ab4481a7d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract atomic_file_write from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract atomic_file_write from utils module
......................................................................
utils: Extract atomic_file_write from utils module
atomic_file_write has been relocated to common.fileutils.
Change-Id: I40c2b6cdb1d0b6ed534ed51cfc53438c1bc36a42
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/common/fileutils.py
M lib/vdsm/network/ifacquire.py
M lib/vdsm/utils.py
A tests/common/fileutils_tests.py
M tests/network/ifacquire_test.py
M tests/utils_test.py
6 files changed, 114 insertions(+), 86 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76559
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40c2b6cdb1d0b6ed534ed51cfc53438c1bc36a42
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract rmTree from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract rmTree from utils module
......................................................................
utils: Extract rmTree from utils module
rmTree has been relocated to common.fileutils.
Adjusted for pep8 compliant names.
Change-Id: I2b931273a77c5900cb772e003b876fb3e8c8370c
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/common/fileutils.py
M lib/vdsm/network/netconfpersistence.py
M lib/vdsm/utils.py
M tests/hookValidation.py
M tests/tool_test.py
5 files changed, 23 insertions(+), 25 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76560
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b931273a77c5900cb772e003b876fb3e8c8370c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract rmFile from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract rmFile from utils module
......................................................................
utils: Extract rmFile from utils module
rmFile has been relocated to common.fileutils.
Adjusted for pep8 compliant names.
Change-Id: I3f07166326353ecb2ebabfe9897ab9fce9d480ad
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/common/fileutils.py
M lib/vdsm/mkimage.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/ifcfg_acquire.py
M lib/vdsm/network/ifacetracking.py
M lib/vdsm/supervdsm_api/udev.py
M lib/vdsm/supervdsm_server.py
M lib/vdsm/utils.py
M lib/vdsm/virt/containers/xmlfile.py
M lib/vdsm/virt/recovery.py
M lib/vdsm/virt/utils.py
M tests/hookValidation.py
M tests/network/conf_persistence_test.py
M tests/network/conf_test.py
M tests/network/netfunctestlib.py
M vdsm/storage/blockVolume.py
M vdsm/virt/vm.py
M vdsm_hooks/fcoe/fcoe_before_network_setup.py
18 files changed, 66 insertions(+), 58 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76558
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f07166326353ecb2ebabfe9897ab9fce9d480ad
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: common fileutils: Use logging exception in rm_file
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: common fileutils: Use logging exception in rm_file
......................................................................
common fileutils: Use logging exception in rm_file
Change-Id: I746a08fe04160018932e6ae815013e7a0bc8fbbb
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/common/fileutils.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76577
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I746a08fe04160018932e6ae815013e7a0bc8fbbb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract monotonic_time from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract monotonic_time from utils module
......................................................................
utils: Extract monotonic_time from utils module
monotonic_time has been relocated to common.time.
Change-Id: I523d2aab1abaf9dc5b81431994873c02c728e92f
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
A lib/vdsm/common/time.py
M lib/vdsm/concurrent.py
M lib/vdsm/executor.py
M lib/vdsm/host/stats.py
M lib/vdsm/kvm2ovirt.py
M lib/vdsm/m2cutils.py
M lib/vdsm/network/netlink/monitor.py
M lib/vdsm/network/restore_net_config.py
M lib/vdsm/protocoldetector.py
M lib/vdsm/schedule.py
M lib/vdsm/sslutils.py
M lib/vdsm/storage/asyncevent.py
M lib/vdsm/supervdsm_server.py
M lib/vdsm/throttledlog.py
M lib/vdsm/utils.py
M lib/vdsm/v2v.py
M lib/vdsm/virt/sampling.py
M lib/vdsm/virt/utils.py
M lib/vdsm/virt/vmstats.py
M lib/yajsonrpc/__init__.py
M lib/yajsonrpc/stomp.py
M tests/integration/jsonRpcHelper.py
M tests/network/netlink_test.py
M tests/periodic_test.py
M tests/schedule_test.py
M tests/storage_asyncevent_test.py
M tests/storage_iscsi_test.py
M tests/storage_qcow2_test.py
M tests/testlib.py
M tests/utils_test.py
M tests/virttests/bulk_sampling_test.py
M tests/vm_test.py
M vdsm/clientIF.py
M vdsm/vdsmd.py
M vdsm/virt/vm.py
35 files changed, 146 insertions(+), 112 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76642
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I523d2aab1abaf9dc5b81431994873c02c728e92f
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month