Change in vdsm[master]: utils: Extract rget from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract rget from utils module
......................................................................
utils: Extract rget from utils module
As network.canonicalize is the only user of this dict util, it has been
relocated to the same module that uses it.
In case other users will require it, a dictutils module may fit.
Change-Id: Ic9cf1aed8a94640638155e864011dca73728ceec
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/canonicalize.py
M lib/vdsm/utils.py
M tests/utils_test.py
3 files changed, 16 insertions(+), 27 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9cf1aed8a94640638155e864011dca73728ceec
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract rget from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Extract rget from utils module
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9cf1aed8a94640638155e864011dca73728ceec
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: dmidecode: collect only system output
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: dmidecode: collect only system output
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76687
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97488bf273d69eb987360da152d712dde6d2167a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: api: log call context for api calls
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: log call context for api calls
......................................................................
Patch Set 11: -Code-Review
following last vdsm-call, removing my -1 and I hope we'll have better solution later on that uses logger formatter and positional fields for parsing (at least for api logs)
--
To view, visit https://gerrit.ovirt.org/75517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I128a338037b22b43b1065cfb40ea95de6f371b99
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: dmidecode: don't assume dmidecode output is ok
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: dmidecode: don't assume dmidecode output is ok
......................................................................
Patch Set 1: Code-Review+1
following patch please remove all trees we don't care about. its a dead code
--
To view, visit https://gerrit.ovirt.org/76671
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bd4cc123bd1c20a5bdac6d9befa60bc9783263c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: utils: Extract touchFile from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract touchFile from utils module
......................................................................
utils: Extract touchFile from utils module
touchFile has been relocated to common.fileutils.
Adjusted for pep8 compliant names.
Change-Id: I2148898c67a63751833f7f51b500524f38e9fb59
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
A lib/vdsm/common/fileutils.py
M lib/vdsm/network/ifacetracking.py
M lib/vdsm/tool/upgrade.py
M lib/vdsm/utils.py
M tests/moduleloader_test.py
M vdsm/API.py
6 files changed, 45 insertions(+), 21 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76553
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2148898c67a63751833f7f51b500524f38e9fb59
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract memoized from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract memoized from utils module
......................................................................
utils: Extract memoized from utils module
memoized has been relocated to common.cache.
Change-Id: Ibbb1dbab5593ba9a61d5a5d814544c6caa3ca235
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
A lib/vdsm/common/cache.py
M lib/vdsm/cpuinfo.py
M lib/vdsm/dmidecodeUtil.py
M lib/vdsm/host/__init__.py
M lib/vdsm/host/caps.py
M lib/vdsm/host/rngsources.py
M lib/vdsm/host/stats.py
M lib/vdsm/hostdev.py
M lib/vdsm/hugepages.py
M lib/vdsm/machinetype.py
M lib/vdsm/network/ip/address.py
M lib/vdsm/network/ip/dhclient.py
M lib/vdsm/network/link/bond/sysfs_options.py
M lib/vdsm/network/netinfo/bonding.py
M lib/vdsm/network/netswitch.py
M lib/vdsm/network/nm/networkmanager.py
M lib/vdsm/network/ovs/driver/vsctl.py
M lib/vdsm/numa.py
M lib/vdsm/osinfo.py
M lib/vdsm/ppc64HardwareInfo.py
M lib/vdsm/tool/configurators/passwd.py
M lib/vdsm/utils.py
M tests/caps_test.py
A tests/common/cache_test.py
M tests/network/nettestlib.py
M tests/utils_test.py
M tests/vmapi_test.py
M tests/vmfakecon.py
28 files changed, 210 insertions(+), 153 deletions(-)
Approvals:
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76544
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibbb1dbab5593ba9a61d5a5d814544c6caa3ca235
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract random_iface_name from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract random_iface_name from utils module
......................................................................
utils: Extract random_iface_name from utils module
random_iface_name has been relocated to network.link.iface.
Change-Id: I62e4b49f1ca1c1b5b923480322eb2aad948fad30
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/link/iface.py
M lib/vdsm/network/netconfpersistence.py
M lib/vdsm/network/ovs/switch.py
M lib/vdsm/tool/dump_bonding_opts.py
M lib/vdsm/utils.py
M tests/network/link_bond_test.py
M tests/network/netinfo_test.py
M tests/network/nettestlib.py
M tests/network/nmnettestlib.py
9 files changed, 30 insertions(+), 26 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76545
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I62e4b49f1ca1c1b5b923480322eb2aad948fad30
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract tobool from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: Extract tobool from utils module
......................................................................
utils: Extract tobool from utils module
This patch is one of a seriese of patches that aim to split utils module
and relocate its content to vdsm.common.
Change-Id: I131143cb9ca29fd0f6545ec9398d882a082c6af2
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
A lib/vdsm/common/conv.py
M lib/vdsm/hostdev.py
M lib/vdsm/network/canonicalize.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/connectivity.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/netrestore.py
M lib/vdsm/tool/register.py
M lib/vdsm/utils.py
M lib/vdsm/virt/libvirtxml.py
M lib/vdsm/virt/migration.py
M lib/vdsm/virt/vmdevices/core.py
M lib/vdsm/virt/vmdevices/graphics.py
M lib/vdsm/virt/vmdevices/hostdevice.py
M lib/vdsm/virt/vmdevices/network.py
M lib/vdsm/virt/vmdevices/storage.py
M lib/vdsm/virt/vmpowerdown.py
M tests/API_test.py
M vdsm/API.py
M vdsm/hooking.py
M vdsm/virt/vm.py
M vdsm/virt/vm_migrate_hook.py
M vdsm_hooks/extra_ipv4_addrs/extra_ipv4_addrs.py
23 files changed, 106 insertions(+), 75 deletions(-)
Approvals:
Nir Soffer: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76458
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I131143cb9ca29fd0f6545ec9398d882a082c6af2
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: utils: Extract tobool from utils module
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Extract tobool from utils module
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/76458/9/vdsm_hooks/extra_ipv4_addrs/extra_ip...
File vdsm_hooks/extra_ipv4_addrs/extra_ipv4_addrs.py:
Line 64: top_level_device, addr.strip()]
Line 65:
Line 66:
Line 67: def _top_dev(network, attrs):
Line 68: if hooking.tobool(attrs.get('bridged')):
good catch
Line 69: return network
Line 70: # bridgeless
Line 71: nics, vlan, _, bonding = netinfo.cache.NetInfo(
Line 72: netswitch.netinfo()).getNicsVlanAndBondingForNetwork(network)
--
To view, visit https://gerrit.ovirt.org/76458
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I131143cb9ca29fd0f6545ec9398d882a082c6af2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month