Change in vdsm[master]: rawhide: Add Fedora rawhide image
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: rawhide: Add Fedora rawhide image
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76566
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2e5c6e4ddf981d086a1b8095bcf8ee51f0d074
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: rawhide: Use longer passphrase to make genrsa happy
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: rawhide: Use longer passphrase to make genrsa happy
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76568
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a43d7c3a7bebea7ec28fd03d7d5a982aebe9891
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: xmlrpc: remove transport verification
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: remove transport verification
......................................................................
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/72769/12//COMMIT_MSG
Commit Message:
Line 4: Commit: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Line 5: CommitDate: 2017-05-10 10:15:47 +0200
Line 6:
Line 7: xmlrpc: remove transport verification
Line 8:
whend did we stopped using the removed dead code?
Line 9:
Line 10: Change-Id: Ie469e81454abd6954861179c8a7494cc474f9db7
--
To view, visit https://gerrit.ovirt.org/72769
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie469e81454abd6954861179c8a7494cc474f9db7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: xmlrpc: rename binding
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: xmlrpc: rename binding
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/72768/13/vdsm.spec.in
File vdsm.spec.in:
Line 241: %package http
Line 242: Summary: VDSM http API
Line 243: BuildArch: noarch
Line 244: Requires: %{name}-python = %{version}-%{release}
Line 245: Obsoletes: %{name}-xmlrpc < %{version}-%{release}
please double check in Fedora packaging doc if "Provides" is also needed"
Line 246:
Line 247: %description http
Line 248: A http interface for interacting with vdsmd when using OVF store image
Line 249: download or upload.
--
To view, visit https://gerrit.ovirt.org/72768
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45271691c3898678ff7d331d99ebb1d398a640af
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: ssl: add flag to enable client certificate
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ssl: add flag to enable client certificate
......................................................................
ssl: add flag to enable client certificate
We are not strict about having resolvable names. In OST and possibly in
customer environments there could be wrongly configured name resolution
service which caused certificate verification to fail. In order to
mitigate potential breakage we provide a flag to enable/disable the
verification.
Change-Id: I94a6b1af7148c080da160c60e45fc6e282a48874
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/config.py.in
M lib/vdsm/sslutils.py
2 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I94a6b1af7148c080da160c60e45fc6e282a48874
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: ssl: client cert check for IPv4 mapped addresses
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ssl: client cert check for IPv4 mapped addresses
......................................................................
ssl: client cert check for IPv4 mapped addresses
When we check the certificate it is possible that in the certificate
we have IPv4 address and we use IPv4 mapped addresses (starting with
::FFFF/96). We need to make sure that this case in covered in
ssutils#compare_names.
Change-Id: Ic012664db7181ab703ec4de53a0ba7c225bb73f9
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M lib/vdsm/sslutils.py
M tests/ssl_test.py
2 files changed, 39 insertions(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76197
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic012664db7181ab703ec4de53a0ba7c225bb73f9
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: ssl: change default library
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ssl: change default library
......................................................................
ssl: change default library
We would like to change default ssl library being used from m2crypto to
ssl. The value that we saw when introducing m2crypto was no longer
there when we started to maintain the connection. We do not need to
maintain two code bases using different ssl libraries.
This patch would enable us to remove m2crypto in the future.
Change-Id: Ib6c64b0781cee9d97829e955490e0608e4208933
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6c64b0781cee9d97829e955490e0608e4208933
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: ssl: change default library
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: change default library
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76205
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c64b0781cee9d97829e955490e0608e4208933
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: ssl: add flag to enable client certificate
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: add flag to enable client certificate
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/76573/4/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 222: self._handshake(dispatcher)
Line 223: else:
Line 224: if config.getboolean('vars', 'verify_client_cert'):
Line 225: if not self._verify_host(dispatcher.socket.getpeercert(),
Line 226: dispatcher.socket.getpeername()[0]):
on another patch: _verify_host should get ALL the names of the peer, not only the first one.
Line 227: self.log.error("peer certificate does not match host name")
Line 228: dispatcher.socket.close()
Line 229: return
Line 230:
--
To view, visit https://gerrit.ovirt.org/76573
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94a6b1af7148c080da160c60e45fc6e282a48874
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: ssl: client cert check for IPv4 mapped addresses
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: client cert check for IPv4 mapped addresses
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76197
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic012664db7181ab703ec4de53a0ba7c225bb73f9
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month