Change in vdsm[master]: [WIP] Added getStorageDevices verb.

Thursday, 19 April 2012

Hello Ayal Baron, Timothy Asir, Saggi Mizrahi, Federico Simoncelli, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/3725

to review the following change.

Change subject: [WIP] Added getStorageDevices verb.
......................................................................

[WIP] Added getStorageDevices verb.

This verb is used to get list of storage devices in the node.  Return
value is a dictionary, its keys are device names and values are
properties of those devices as dictionary.

    {DEVNAME: {'container':   CONTAINER_DEVNAME,
               'contentType': CONTENT_TYPE_STRING,
               'endSize':     SIZE_MB,
               'flagList':    STRING_LIST,
               'fsSize':      SIZE_MB,
               'fsSizeFree':  SIZE_MB,
               'fsType':      STRING,
               'fsUuid':      UUID,
               'members':     DEVNAME_LIST,
               'model':       STRING,
               'mountPoint':  STRING,
               'name':        DEVNAME,
               'origin':      LV_DEVNAME,
               'parent':      PARENT_DEVNAME,
               'partitions':  DEVNAME_LIST,
               'size':        SIZE_MB,
               'sizeFree':    SIZE_MB,
               'startSize':   SIZE_MB,
               'status':      STATUS_STRING,
               'tableType':   DISK_TABLE_TYPE,
               'type':        TYPE_STRING,
               'uuid':        UUID,
               'vendor':      STRING},...}

here, property dictionary contains

    container:   If DEVNAME is used by another device eg. LVM PV, MD etc, name
                 of that device is set
    contentType: This is determined by various other properties.  Possible
                 value is one of 'SWAP', 'OS', 'DATA' and
'NA'
    endSize:     If DEVNAME is a partition, its end boundry is set.  The value
                 is in MB
    flagList:    If DEVNAME is a partition, its flags(eg. boot,bios_grub etc)
                 are set as a list of strings
    fsSize:      If DEVNAME has a file system, its size is set.  The value is
                 in MB
    fsSizeFree:  If DEVNAME is mounted, its free size is set.  The value is in
                 MB
    fsType:      If DEVNAME is formatted, its file system type is set
    fsUuid':     If DEVNAME has file system, its UUID is set
    members:     If DEVNAME is a MD, LVM VG etc, its member device names are
                 set as list of strings
    model:       Model of DEVNAME is set as string
    mountPoint:  If DEVNAME is mounted, its mount point is set
    name:        DEVNAME is set here for completion
    origin:      If DEVNAME is a snapshot of LV, that LV name is set
    parent:      If DEVNAME is a partition, its disk name is set
    partitions:  If DEVNAME is a disk, its partition names are set as list of
                 strings
    size:        Size of DEVNAME is set.  The value is in MB
    sizeFree:    If DEVNAME is VG, its size of free extents is set.  If its a
                 partitioned disk, its unallocated size is set.  The value is
                 in MB
    startSize:   If DEVNAME is a partition, its start boundry is set.  The
                 value is in MB
    status:      This is determined by various other properites of the DEVNAME.
                 Possible value is one of 'UNINITIALIZED', 'NA',
'UNUSABLE',
                 'FORMAT_UNSUPPORTED', 'MOUNTED', 'FORMATTED' and
'PARTED'
    tableType':  If DEVNAME is a disk, its table(label) type is set as a string
    type:        This is determined value.  Possible value is one of 'MD',
                 'LVM_VG', 'LVM_LV_SNAPSHOT', 'LVM_LV' and
'BLOCK'
    uuid:        UUID of DEVNAME
    vendor:      Vendor of DEVNAME is set as string

Change-Id: I2cb217321a7a8dfcd1b507c7cba2888f08612207
Signed-off-by: Bala.FA <barumuga(a)redhat.com&gt;
---
M vdsm.spec.in
M vdsm/API.py
M vdsm/BindingXMLRPC.py
M vdsm/Makefile.am
A vdsm/storage_device_utils.py
M vdsm_cli/vdsClient.py
6 files changed, 505 insertions(+), 1 deletion(-)

  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/3725/1
--
To view, visit http://gerrit.ovirt.org/3725
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cb217321a7a8dfcd1b507c7cba2888f08612207
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com&gt;

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011