On 05/20/2011 01:08 AM, Kamil Paral wrote:
> I ran into another python 2.4 issue in master today
> (try/catch/finally at util.py:276) and while I did fix my dev
> machine, I'm not sure if we want to be changing this on master.
It's the method "valid_rpm(rpm_file)", I wrote it. But the method
should be called from the tests only, therefore just on the clients,
shouldn't it? I thought it should not affect the server side.
True, its only called on the clients but it is parsed at import time and
causes exceptions to be thrown at that time.
On a side note, 'make install' doesn't work on RHEL5 either - it tries
to byte-compile all of the python code for 2.4 and dies when it hits the
finally blocks. For some reason, building the RPM isn't affected, though.
> Since we're planning to move to RHEL6 soon, is it worth
fixing this
> in master or should we just make sure that stable is 2.4 compatible
> and hold off on any incompatible changes until we upgrade
> production?
>
> I'm tempted to say leave it alone for now and hopefully we'll
> upgrade production to RHEL6 before we need to deal with this. I'll
> just patch my RHEL5 machine for now and keep track of the required
> changes if we should need them.
We're thinking alike. Let's leave it as it is and patch it only when
we know that we certainly won't have RHEL6 for our next release. The
change is trivial anyway.
+10000 for moving to RHEL6. Dealing with AutoQA on RHEL5 for a dev
environment is painful.
Tim