Thank you for the link, James, must have slipped my attention.
I used odrinary git-diff against master to generate the patch, since i
did not want it to contain all the commit information in my branch, but
just the code.
The body of the e-mail and the patch itself are different, because i
wanted to put only the important information to the body (i.e. the code
i wrote, without the tests we took from base-os team).
Hope it did not cause you (or Will) any trouble, and I can of course
provide the patch using standard git-format-patch way.
joza
On 03/22/2010 08:26 PM, James Laska wrote:
Great stuff Josef! I'm excited to see initscript jobs processing
in
AutoQA. I'll leave the technical review to wwoods and kparal, but one
thing I noticed is that the body of the mail, and the attached patch are
different. How did you generate the patch to send to the list, did you
use git-format-patch and git-send-email (from the patch submission
process [1]) or some other technique?
Thanks,
James
[1]
https://fedoraproject.org/wiki/AutoQA_PatchProcess#Patch_submission
_______________________________________________
autoqa-devel mailing list
autoqa-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/autoqa-devel