----- Original Message -----
> ---
> hooks/post-repo-update/watch-repos.py | 12 ++++++------
> hooks/post-tree-compose/watch-composes.py | 10 +++++-----
> lib/python/config.py | 16 +++++++++-------
No objections, looks like $ARCH is more self-documenting than %a. I
wonder if we should be using string.format() instead of
string.replace()
here?
http://docs.python.org/library/stdtypes.html#str.format
I'm not aware that it's better or worse than using string.replace(),
I'm
just familiar with how Chris Lumens uses it for templating in the
anaconda_storage test. Definitely your call on which is the
appropriate
fit.
http://git.fedorahosted.org/git/?p=autoqa.git;a=blob;f=tests/anaconda_sto...
str.format seems to be available only from Python 2.6. Let's keep
the str.replace() in.
> lib/python/repoinfo.py | 29 +++++++++++++++++++++++------
ACK, that makes sense, and kudos for the docstring additions
> repoinfo.conf | 4 ++++
Good comments, thanks.
> 5 files changed, 47 insertions(+), 24 deletions(-)
Thanks,
James
Thank you for the review. Pushed to master.