Re: Review Request: conflicts and repoclosure tests minor refactoring
While studying conflicts and repoclosure tests I've done some
minor
code refactoring that might be worth pushing to master, please
review at origin/mkrizek:
$ git log origin/master..origin/mkrizek
Thanks,
Martin
I wanted to respond "you can push small changes like these right away", but in
the end I have one concern:
self.detail.id = "%s-%s" % (name, kwargs['arch'])
if name else baseurl
This is extremely confusing, that really works? Usually I do use ternary operator, but in
this case it's not a good idea. I took me quite some time just to understand the
purpose and I'm still not sure whether it really works. I don't believe that
people usually remember which one of '%' and ternary operator has higher priority.
I don't.