Re: [PATCH] Include traceback in email output
----- "James Laska" <jlaska(a)redhat.com> wrote:
On Wed, 2010-10-06 at 09:08 -0400, Kamil Paral wrote:
> ----- "Kamil Páral" <kparal(a)redhat.com> wrote:
>
> > If the test crashes, provide the full traceback at the end of the
> > self.outputs. This way we can quickly examine the cause from the
body
> > of
> > the email and don't have to search for full autoqa logs on the
> > server.
> > ---
> > lib/python/decorators.py | 6 +++---
> > lib/python/test.py | 8 ++++++--
> > 2 files changed, 9 insertions(+), 5 deletions(-)
>
> Note, this is based on Josef's "[PATCH] Removed individual
XYZ_failed
> methods in test.py". James, it should address your concern of now
knowing
> in which method the exception occurred. We won't have it in the
mail
> subject, but it will be included in the traceback in the mail body.
Thanks Kamil, this seems like a nice improvement.
With regards to the patch itself, I can't find anything wrong with
either this patchset, or the XYZ_failed set. I have mixed feelings
though, this is the patch you don't want to see in action, that means
tests are 'sploding :)
Ok, both patches pushed.