----- Original Message -----
From: "Kamil Paral" <kparal(a)redhat.com>
To: "AutoQA development" <autoqa-devel(a)lists.fedorahosted.org>
Sent: Thursday, January 12, 2012 5:24:12 PM
Subject: Re: rats_install test updated for review
> Greeting,
>
> The rats_install test has been updated to adapt the F16 release and
> to use rsyslog to get logs,
> --initrd-inject is used to attach the ks file instead of to
> compress
> the ks file into initrd.img manually.
>
> The source codes can be found in branch rats_install
>
http://git.fedorahosted.org/git/?p=autoqa.git;a=tree;h=refs/heads/rats_in...
>
> irb is not configured currently.
> some functions there are not used by rats_install, I just leave
> them
> there for future ISO installation. They will
> not affect other parts of the autoqa, just leave them there.please
> kindly review it and give me your feedback. Thanks.
>
> Hongqing
Hey,
could you please add module documentation to any module touched? That
means putting a docstring (triple quote syntax) after the license
boilerplate that describes what this module is good for and what
kind of methods we can find there.
I have updated the comments and docstring
Maybe the rsyslog.py module methods can be merged into anaconda.py
module? They seem to be tightly coupled anyway.
rsyslog.py is merged into
anaconda.py
Can we rename analog to analog.py? My editor refuses to choose
correct syntax highlighting otherwise :) Not a big deal though.
Btw why is the 'analog' file present both in library and in
rats_install directory?
analog is renamed to analog.py and the one in
rats_install is removed.
please find the final version at
http://git.fedorahosted.org/git/?p=autoqa.git;a=tree;h=refs/heads/rats_in...
I haven't tried running the test yet. Before I test it out
properly,
can you please respond to the questions in the "0.8.0 Status Update"
email thread?
Thanks!
Kamil
_______________________________________________
autoqa-devel mailing list
autoqa-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/autoqa-devel