#294: Detect required Fedora releases correctly
--------------------+-------------------------------------------------------
Reporter: kparal | Owner: vhumpa
Type: defect | Status: assigned
Priority: major | Milestone: 0.5.0
Component: core | Resolution:
Keywords: |
--------------------+-------------------------------------------------------
Changes (by vhumpa):
* owner: => vhumpa
* status: new => assigned
Comment:
Check the reviewboard:
https://fedorahosted.org/reviewboard/r/131/
Added get_system_release(rpmstr, prefix='fc') function that determines the
system release name out of a package name. This function doesn't require
it to be in envr format so that 'old' and different packaging names (like
foo-1.1-1.i686.fc15.1) are recognized. Depcheck and Initscripts
control.autoqa files have been modified to use this method instead of
doing .split('.')[-1], which didn't work on non envr names.
Possible discussion: 1) if the release name is not found(because it wasn't
present), control.autoqa just doesn't get test scheduled to be executed.
This seemed as desirable behavior to me but we can consider throwing an
exception instead. 2) I made two implementations of get_system_release(),
one using 're' module and likely more 'bulletproof' while the other
takes
advantage of envra() function with no regexp. The first one is used now
and second commented - in case we don't want to import 're' module for
some reason, those two can be swapped.
--
Ticket URL: <
https://fedorahosted.org/autoqa/ticket/294#comment:3>
AutoQA <
http://autoqa.fedorahosted.org>
Automated QA project