Re: [PATCH 1/2] add repoinfo.getreleases() and get_bodhi_releases()

[Will Woods]

----- "Kamil Paral"  wrote:
> Patchset tested, it works well. It may be applied to master. Few
> comments below.

Thanks for testing, Kamil. Will push shortly.
> >    return [r.upper() for r in self.getreleases()]
>
> If the bodhi tracked releases are always the same as currently active
> releases (I don't know whether this is true) we can save one method
> here and just use getreleases() (and .upper()) in the bodhi watcher.
> But that's just an idea.

Well, I can't guarantee that's going to stay true - it works right
now, anyway. But that's why we have a (sort of) well-defined API
for repoinfo - so the watcher (and anything else using repoinfo)
doesn't need to worry about changing their code if Bodhi changes.

We just change repoinfo.get_bodhi_releases() and everything else
will work just fine.

-w