On Thu, 2011-07-07 at 05:27 -0400, Kamil Paral wrote:
<snip>
Finally we're not ashamed of the Makefile :-)
Heh ... no, still ashamed. Just afraid to admit it now :)
<snip>
> +install-buildrequires:
> + yum install $$(grep ^BuildRequires: $(SPECFILE) | cut -d ' ' -f 2)
This is cool. Could we add also "install-requires" target? It would
help when checking out autoqa from git onto new computers.
Good idea, added.
<snip>
I have not tested the patch but I don't have any concerns about
the
changes.
I've been testing it relative to the updated wiki docs. I've also been
testing it to ensure that it only executes build targets once, or
whenever the autoqa.spec (or autoqa.tar.gz) changes. There's a minor
issue where it will always build packages for Fedora %{release}'s
different from what you are currently building on. I'm experimenting
with ways around that, but it's not a big deal either way.
What I would like to see is the documentation page [1] linked in the
Makefile so that it's easy to understand the process (which targets to
call and in what sequence). Also it will be great if every target has
a very brief description (one-liner) of what it does. For example in a
few seconds I can't say the difference between "make rpm" and "make
nvr". A few words description would help.
My intent is to document the make targets people will need to know about
on the AutoQA_Build_Process wiki. Anything else really isn't
needed/required. I'll add a 'make help' to cover the remaining targets
not already documented on the wiki.
Thanks,
James