Re: [PATCH] add helloworld test

[Kamil Paral]

----- "Vojtěch Aschenbrenner" <vaschenb(a)redhat.com&gt; wrote:

>  On Wed, Jul 14, 2010 at 05:41:29PM -0400, Will Woods wrote:
>  >   job.run_test('helloworld', config=autoqa_conf, **locals())
>  > 
>  > (doing **locals() passes the contents of locals as if they had all
>  been
>  > given to the function as "var_name=var_value" pairs)
>  
>  This is problem, because locals() will pass many parameters (not only
>  ours), output included at the end of mail (sorry for LONGLONG mail).
>  
>  > Probably we want *args as well as **kwargs here, just in case.
>  
>  OK, *args included now, but here is problem with this mess in
>  arguments
>  from locals(). 
I didn't occur to me that there will be some many local variables.
I think we one several choices:

== Temporary solutions ==
1. Leave helloworld available just for post-koji-build

2. Test the presence of all variables (defined for any hook) in 
helloworld control file and pass to the job only those that are 
currently available. This means more work when maintaining this test.

== Proper solutions ==
3. Pass all autoqa variables into the control file as a dictionary,
instead of a pile of variables. We have talked about this some time
ago. It will need a modification of all the test cases and some
tweaks in autoqa harness. But overall it shouldn't be such a hard
change. Vojtěch could do it easily I believe.

What do you think?

[PATCH] add helloworld test

[Will Woods]

On Thu, 2010-07-15 at 07:17 -0400, Kamil Paral wrote:

>  == Proper solutions ==
>  3. Pass all autoqa variables into the control file as a dictionary,
>  instead of a pile of variables. We have talked about this some time
>  ago. It will need a modification of all the test cases and some
>  tweaks in autoqa harness.  
Right. We might be able to cheat a little by changing the control files
to pass the dict as keyword args, like so:
-job.run_test('classname', name=name, config=autoqa_config, ...)
+job.run_test('classname', **autoqa_args)
If that works as expected, we can avoid having to change the test
wrappers... but see below.

>  But overall it shouldn't be such a hard change. Vojtěch could do
> it
>  easily I believe.
>  
>  What do you think? 
Sounds like a good idea, and I think now's a good time, since we're
already making a whole lot of little changes to the tests for Josef's
AutoQATest baseclass patch.

These two patches will change the test code/examples fairly
significantly, so I'm thinking we should bump the version number to
0.4.0 to reflect that. Which means we might want an 0.3 branch in git,
so we can keep the current production code bugfixed / up to date while
we make these changes.

Does that sound reasonable? James, you're the current buildmaster - is
it useful/necessary to keep a branch for 0.3.x? Do you anticipate us
needing 0.3.x bugfixes in the next week or two while the 0.4.0 code
shapes up?

-w

[PATCH] add helloworld test

[James Laska]

On Thu, 2010-07-15 at 13:03 -0400, Will Woods wrote:
>  On Thu, 2010-07-15 at 07:17 -0400, Kamil Paral wrote:
>  
>  > == Proper solutions ==
>  > 3. Pass all autoqa variables into the control file as a dictionary,
>  > instead of a pile of variables. We have talked about this some time
>  > ago. It will need a modification of all the test cases and some
>  > tweaks in autoqa harness. 
>  
>  Right. We might be able to cheat a little by changing the control files
>  to pass the dict as keyword args, like so:
>  -job.run_test('classname', name=name, config=autoqa_config, ...)
>  +job.run_test('classname', **autoqa_args)
>  If that works as expected, we can avoid having to change the test
>  wrappers... but see below.
>  
>  > But overall it shouldn't be such a hard change. Vojtěch could do it
>  > easily I believe.
>  > 
>  > What do you think?
>  
>  Sounds like a good idea, and I think now's a good time, since we're
>  already making a whole lot of little changes to the tests for Josef's
>  AutoQATest baseclass patch.
>  
>  These two patches will change the test code/examples fairly
>  significantly, so I'm thinking we should bump the version number to
>  0.4.0 to reflect that. Which means we might want an 0.3 branch in git,
>  so we can keep the current production code bugfixed / up to date while
>  we make these changes.
>  
>  Does that sound reasonable? James, you're the current buildmaster - is
>  it useful/necessary to keep a branch for 0.3.x? Do you anticipate us
>  needing 0.3.x bugfixes in the next week or two while the 0.4.0 code
>  shapes up? 
The only 0.3.0 bugfix on my radar is the issue Kamil discovered with the
koji-build watcher and repoinfo.  I'm still investigating a fix for
that, but I'd be just as fine landing that in 0.4.0.

If we had to create a branch for some reason, it's not too much trouble
to create a branch from a specific point in the master branch history,
right?  Something like ...

# git checkout -b v0.3 a200e6a49d47a5b9242f11858315f26ad0a3381e

Thanks,
James

[PATCH] add helloworld test

[Will Woods]

On Thu, 2010-07-15 at 13:56 -0400, James Laska wrote:

>  If we had to create a branch for some reason, it's not too much
> trouble
>  to create a branch from a specific point in the master branch history,
>  right?  Something like ...
>  
>  # git checkout -b v0.3 a200e6a49d47a5b9242f11858315f26ad0a3381e 
Good point. And if we've already got a tag in place for the last
release, it's basically trivial to branch off from that tag.

(are we tagging the repo for each released version? that'd be a good
idea...)

-w

[PATCH] add helloworld test

[James Laska]

On Thu, 2010-07-15 at 15:34 -0400, Will Woods wrote:
>  On Thu, 2010-07-15 at 13:56 -0400, James Laska wrote:
>  
>  > If we had to create a branch for some reason, it's not too much trouble
>  > to create a branch from a specific point in the master branch history,
>  > right?  Something like ...
>  > 
>  > # git checkout -b v0.3 a200e6a49d47a5b9242f11858315f26ad0a3381e
>  
>  Good point. And if we've already got a tag in place for the last
>  release, it's basically trivial to branch off from that tag.
>  
>  (are we tagging the repo for each released version? that'd be a good
>  idea...) 
Oh yeah, I forgot about that.  Yes, I tag each time I do a new build.
Hopefully I'm doing that right. :)

# git tag
v0.3-3
v0.3.1-1
v0.3.2-1
v0.3.3-1
v0.3.4-1
v0.3.5-1

Thanks,
James

[PATCH] add helloworld test

[Vojtěch Aschenbrenner]

On Thu, Jul 15, 2010 at 01:03:59PM -0400, Will Woods wrote:
>  Right. We might be able to cheat a little by changing the control
> files
>  to pass the dict as keyword args, like so:
>  -job.run_test('classname', name=name, config=autoqa_config, ...)
>  +job.run_test('classname', **autoqa_args)
>  If that works as expected, we can avoid having to change the test
>  wrappers... but see below. 
I modified autoqa script to passing arguments via **autoqa_args
[PATCH 1].
According to this change, I modified:
* helloworld test [PATCH 2]
* control files for all tests [PATCH 3]
* templates for all hooks [PATCH 4]

Patches are in following e-mails.

[PATCH 1/4] autoqa script passing arguments via dictionary

[Vojtěch Aschenbrenner]

---
 autoqa |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/autoqa b/autoqa
index b4b9097..d0473f8 100755
--- a/autoqa
+++ b/autoqa
@@ -83,8 +83,7 @@ def prep_controlfile(controlfile, extradata):
         os.write(fd, autoqa_conf_str)
     except IOError:
         pass
-    for k,v in extradata.iteritems():
-        os.write(fd,"%s='%s'\n" % (k,v))
+    os.write(fd, "autoqa_args = %r" % extradata)
     os.write(fd,'\n\n')
     os.write(fd,controldata.read())
     os.close(fd)
-- 
1.7.1.1

[PATCH 2/4] Hello world test

[Vojtěch Aschenbrenner]

---
 tests/helloworld/control       |   13 +++++++++++
 tests/helloworld/helloworld.py |   44 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 57 insertions(+), 0 deletions(-)
 create mode 100644 tests/helloworld/control
 create mode 100644 tests/helloworld/helloworld.py

diff --git a/tests/helloworld/control b/tests/helloworld/control
new file mode 100644
index 0000000..fc34275
--- /dev/null
+++ b/tests/helloworld/control
@@ -0,0 +1,13 @@
+# vim: set syntax=python
+TIME="SHORT"
+AUTHOR = "Vojtech Aschenbrenner <vaschenb(a)redhat.com&gt;&quot;
+DOC = """
+This test runs helloworld. It will only print params what it will get.
+Main purpose is to show, how to write tests.
+"""
+NAME = 'helloworld'
+TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need multiple machines
+TEST_CLASS = 'General'
+TEST_CATEGORY = 'Functional'
+
+job.run_test('helloworld', config=autoqa_conf, **autoqa_args)
diff --git a/tests/helloworld/helloworld.py b/tests/helloworld/helloworld.py
new file mode 100644
index 0000000..ffc699c
--- /dev/null
+++ b/tests/helloworld/helloworld.py
@@ -0,0 +1,44 @@
+#
+# Copyright 2010, Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# Author: Vojtech Aschenbrenner <vaschenb(a)redhat.com&gt;
+
+from autotest_lib.client.bin import test
+from autotest_lib.client.bin.test_config import config_loader
+import autoqa.util
+import os
+
+class helloworld(test.test):
+    version = 1 # increment if setup() changes
+
+    def initialize(self, config):
+        self.config = config_loader(config, self.tmpdir)
+        self.autotest_url = autoqa.util.make_autotest_url(self.config)
+
+    def setup(self):
+        pass
+
+    def run_once(self, *args, **kwargs):
+        self.arguments1 = args
+        self.arguments2 = kwargs
+        print "===Printing passed params==="
+        for self.arg in self.arguments1:
+            print "%s" % (self.arg)
+        for self.name, self.arg in self.arguments2.iteritems():
+            print "%s = %r" % (self.name, self.arg)
+        print "%s = %r" % ("autotest_url", self.autotest_url)
+        print "===End of passed params==="
-- 
1.7.1.1

[PATCH 3/4] New control files for new autoqa script with params in dict

[Vojtěch Aschenbrenner]

---
 tests/conflicts/control    |    5 +----
 tests/initscripts/control  |    7 +------
 tests/rats_install/control |    2 +-
 tests/rats_sanity/control  |    5 +----
 tests/repoclosure/control  |    3 +--
 tests/rpmguard/control     |    8 +-------
 tests/rpmlint/control      |    7 +------
 7 files changed, 7 insertions(+), 30 deletions(-)

diff --git a/tests/conflicts/control b/tests/conflicts/control
index 7c9b780..c95e66e 100644
--- a/tests/conflicts/control
+++ b/tests/conflicts/control
@@ -10,7 +10,4 @@ TEST_TYPE = 'CLIENT'
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional' 
 
-job.run_test('conflicts', baseurl=url,
-                          parents=parents,
-                          reponame=reponame,
-                          config=autoqa_conf)
+job.run_test('conflicts', config=autoqa_conf, **autoqa_args)
diff --git a/tests/initscripts/control b/tests/initscripts/control
index fec4fc0..3c1328d 100644
--- a/tests/initscripts/control
+++ b/tests/initscripts/control
@@ -9,9 +9,4 @@ TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need
multiple machines
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 
-# post-koji-build tests can expect the following variables from autoqa:
-# envr: package ENVR (required, epoch can be skipped)
-# name: package name
-# kojitag: koji tag applied to this package
-
-job.run_test('initscripts', name=name, envr=envr, kojitag=kojitag,
config=autoqa_conf)
+job.run_test('initscripts', config=autoqa_conf, **autoqa_args)
diff --git a/tests/rats_install/control b/tests/rats_install/control
index f3fd56e..168b081 100644
--- a/tests/rats_install/control
+++ b/tests/rats_install/control
@@ -16,4 +16,4 @@ TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 TEST_TYPE = 'CLIENT'
 
-job.run_test('rats_install', baseurl=url, treename=treename, config=autoqa_conf)
+job.run_test('rats_install', config=autoqa_conf, **autoqa_args)
diff --git a/tests/rats_sanity/control b/tests/rats_sanity/control
index 299d423..f1143fb 100644
--- a/tests/rats_sanity/control
+++ b/tests/rats_sanity/control
@@ -17,7 +17,4 @@ TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional' # Acceptance, really, but whatevs
 TEST_TYPE = 'CLIENT'
 
-job.run_test('rats_sanity', baseurl=url,
-                            parents=parents,
-                            reponame=reponame,
-                            config=autoqa_conf)
+job.run_test('rats_sanity', config=autoqa_conf, **autoqa_args)
diff --git a/tests/repoclosure/control b/tests/repoclosure/control
index 8467545..bc8bc31 100644
--- a/tests/repoclosure/control
+++ b/tests/repoclosure/control
@@ -11,5 +11,4 @@ TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 
 
-job.run_test('repoclosure', baseurl=url, parents=parents, reponame=reponame,
-             config=autoqa_conf)
+job.run_test('repoclosure', config=autoqa_conf, **autoqa_args)
diff --git a/tests/rpmguard/control b/tests/rpmguard/control
index 8c6bd12..44c31e6 100644
--- a/tests/rpmguard/control
+++ b/tests/rpmguard/control
@@ -12,10 +12,4 @@ TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need
multiple machines
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Regression'
 
-# post-koji-build tests can expect the following variables from autoqa:
-# envr: package NVR (required, epoch can be skipped)
-# name: package name
-# kojitag: koji tag applied to this package
-
-job.run_test('rpmguard', name=name, envr=envr, kojitag=kojitag,
-                              config=autoqa_conf)
+job.run_test('rpmguard', config=autoqa_conf, **autoqa_args)
diff --git a/tests/rpmlint/control b/tests/rpmlint/control
index a03be4e..04095a6 100644
--- a/tests/rpmlint/control
+++ b/tests/rpmlint/control
@@ -10,9 +10,4 @@ TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need
multiple machines
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 
-# post-koji-build tests can expect the following variables from autoqa:
-# envr: package NVR (required, epoch can be skipped)
-# name: package name
-# kojitag: koji tag applied to this package
-
-job.run_test('rpmlint', name=name, envr=envr, kojitag=kojitag,
config=autoqa_conf)
+job.run_test('rpmlint', config=autoqa_conf, **autoqa_args)
-- 
1.7.1.1

[PATCH 4/4] Modified templates for all hooks for new autoqa script

[Vojtěch Aschenbrenner]

---
 hooks/post-bodhi-update/control.template       |   10 +---------
 hooks/post-bodhi-update/test_class_template.py |    6 ++++++
 hooks/post-koji-build/control.template         |    8 +-------
 hooks/post-koji-build/test_class_template.py   |    5 +++++
 hooks/post-repo-update/control.template        |   12 +-----------
 hooks/post-repo-update/test_class_template.py  |    7 +++++++
 hooks/post-tree-compose/control.template       |   10 +---------
 hooks/post-tree-compose/test_class_template.py |    6 ++++++
 8 files changed, 28 insertions(+), 36 deletions(-)

diff --git a/hooks/post-bodhi-update/control.template
b/hooks/post-bodhi-update/control.template
index 34878e0..b58f98c 100644
--- a/hooks/post-bodhi-update/control.template
+++ b/hooks/post-bodhi-update/control.template
@@ -9,12 +9,4 @@ TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need
multiple machines
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 
-# post-bodhi-update tests can expect the following variables from autoqa:
-# title: title of the update request
-# updateid: Unique ID of the update request (may be empty)
-# targettag: target koji tag for this update
-# envrs: comma-separated list of package envrs in this update request
-
-job.run_test('testclassname', name=name, title=title, updateid=updateid,
-                              envrs=envrs, targettag=targettag,
-                              config=autoqa_conf)
+job.run_test('testclassname', config=autoqa_conf, **autoqa_args)
diff --git a/hooks/post-bodhi-update/test_class_template.py
b/hooks/post-bodhi-update/test_class_template.py
index bd572a1..dab644d 100644
--- a/hooks/post-bodhi-update/test_class_template.py
+++ b/hooks/post-bodhi-update/test_class_template.py
@@ -17,6 +17,12 @@
 #
 # Author: Will Woods <wwoods(a)redhat.com&gt;
 
+# post-bodhi-update tests can expect the following variables from autoqa:
+# title: title of the update request
+# updateid: Unique ID of the update request (may be empty)
+# targettag: target koji tag for this update
+# envrs: comma-separated list of package envrs in this update request
+
 import autoqa.util
 from autotest_lib.client.bin import test, utils
 from autotest_lib.client.bin.test_config import config_loader
diff --git a/hooks/post-koji-build/control.template
b/hooks/post-koji-build/control.template
index b90260f..b58f98c 100644
--- a/hooks/post-koji-build/control.template
+++ b/hooks/post-koji-build/control.template
@@ -9,10 +9,4 @@ TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need
multiple machines
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 
-# post-koji-build tests can expect the following variables from autoqa:
-# envr: package ENVR (required, epoch can be skipped)
-# name: package name
-# kojitag: koji tag applied to this package
-
-job.run_test('testclassname', name=name, envr=envr, kojitag=kojitag,
-                              config=autoqa_conf)
+job.run_test('testclassname', config=autoqa_conf, **autoqa_args)
diff --git a/hooks/post-koji-build/test_class_template.py
b/hooks/post-koji-build/test_class_template.py
index 9f63003..3c5cea8 100644
--- a/hooks/post-koji-build/test_class_template.py
+++ b/hooks/post-koji-build/test_class_template.py
@@ -17,6 +17,11 @@
 #
 # Author: Will Woods <wwoods(a)redhat.com&gt;
 
+# post-koji-build tests can expect the following variables from autoqa:
+# envr: package ENVR (required, epoch can be skipped)
+# name: package name
+# kojitag: koji tag applied to this package
+
 import autoqa.util
 from autotest_lib.client.bin import test, utils
 from autotest_lib.client.bin.test_config import config_loader
diff --git a/hooks/post-repo-update/control.template
b/hooks/post-repo-update/control.template
index 50ba58d..b58f98c 100644
--- a/hooks/post-repo-update/control.template
+++ b/hooks/post-repo-update/control.template
@@ -9,14 +9,4 @@ TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need
multiple machines
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 
-# post-repo-update tests can expect the following variables from autoqa:
-#
-#url - url of repo that changed
-#parents - space-separated list of urls for 'parent' repos of the given repo
-#reponame - name for repo that changed
-#autoqa_conf - contents of /etc/autoqa/autoqa.conf on the server
-
-job.run_test('testclassname', baseurl=url,
-                              parents=parents,
-                              reponame=reponame,
-                              config=autoqa_conf)
+job.run_test('testclassname', config=autoqa_conf, **autoqa_args)
diff --git a/hooks/post-repo-update/test_class_template.py
b/hooks/post-repo-update/test_class_template.py
index 8070b4e..b4b9360 100644
--- a/hooks/post-repo-update/test_class_template.py
+++ b/hooks/post-repo-update/test_class_template.py
@@ -19,6 +19,13 @@
 
 # HEY YOU, NOTE: you should change the Copyright / Author.
 
+# post-repo-update tests can expect the following variables from autoqa:
+#
+#url - url of repo that changed
+#parents - space-separated list of urls for 'parent' repos of the given repo
+#reponame - name for repo that changed
+#autoqa_conf - contents of /etc/autoqa/autoqa.conf on the server
+
 import autoqa.util
 from autotest_lib.client.bin import test, utils
 from autotest_lib.client.bin.test_config import config_loader
diff --git a/hooks/post-tree-compose/control.template
b/hooks/post-tree-compose/control.template
index e327799..b58f98c 100644
--- a/hooks/post-tree-compose/control.template
+++ b/hooks/post-tree-compose/control.template
@@ -9,12 +9,4 @@ TEST_TYPE = 'CLIENT' # SERVER can be used for tests that need
multiple machines
 TEST_CLASS = 'General'
 TEST_CATEGORY = 'Functional'
 
-# post-tree-compose tests can expect the following variables from autoqa:
-#
-#url - url of the new tree
-#treename - name for the new tree
-#autoqa_conf - contents of /etc/autoqa/autoqa.conf on the server
-
-job.run_test('testclassname', baseurl=url,
-                              treename=treename,
-                              config=autoqa_conf)
+job.run_test('testclassname', config=autoqa_conf, **autoqa_args)
diff --git a/hooks/post-tree-compose/test_class_template.py
b/hooks/post-tree-compose/test_class_template.py
index 94a0617..93189d0 100644
--- a/hooks/post-tree-compose/test_class_template.py
+++ b/hooks/post-tree-compose/test_class_template.py
@@ -19,6 +19,12 @@
 
 # HEY YOU, NOTE: you should change the Copyright / Author.
 
+# post-tree-compose tests can expect the following variables from autoqa:
+#
+#url - url of the new tree
+#treename - name for the new tree
+#autoqa_conf - contents of /etc/autoqa/autoqa.conf on the server
+
 import autoqa.util
 from autotest_lib.client.bin import test, utils
 from autotest_lib.client.bin.test_config import config_loader
-- 
1.7.1.1

[PATCH] add helloworld test

[Josef Skladanka]

On 07/15/2010 07:03 PM, Will Woods wrote:
>  On Thu, 2010-07-15 at 07:17 -0400, Kamil Paral wrote:
>
> > == Proper solutions ==
> > 3. Pass all autoqa variables into the control file as a dictionary,
> > instead of a pile of variables. We have talked about this some time
> > ago. It will need a modification of all the test cases and some
> > tweaks in autoqa harness.
>
>  Right. We might be able to cheat a little by changing the control files
>  to pass the dict as keyword args, like so:
>  -job.run_test('classname', name=name, config=autoqa_config, ...)
>  +job.run_test('classname', **autoqa_args)
>  If that works as expected, we can avoid having to change the test
>  wrappers... but see below. 
The only think I do not like on this approach is, that after this 
change, I'll never know, which particular arguments are passed in 
autoqa_args. Does not seem to be a big deal, but i kind of used it as a 
reference of possible data i can work with inside the tests called by 
the respective hook.
But i guess, that if this will be well documented in some other way, 
then this is no problem at all.

J.

[PATCH] add helloworld test

[Josef Skladanka]

never mind, I overlooked the documentation of possible arguments in the 
comments at the beginning of the templates.

Joza

On 07/20/2010 09:13 AM, Josef Skladanka wrote:
>  On 07/15/2010 07:03 PM, Will Woods wrote:
> > On Thu, 2010-07-15 at 07:17 -0400, Kamil Paral wrote:
> >
> >> == Proper solutions ==
> >> 3. Pass all autoqa variables into the control file as a dictionary,
> >> instead of a pile of variables. We have talked about this some time
> >> ago. It will need a modification of all the test cases and some
> >> tweaks in autoqa harness.
> >
> > Right. We might be able to cheat a little by changing the control files
> > to pass the dict as keyword args, like so:
> > -job.run_test('classname', name=name, config=autoqa_config, ...)
> > +job.run_test('classname', **autoqa_args)
> > If that works as expected, we can avoid having to change the test
> > wrappers... but see below.
>
>  The only think I do not like on this approach is, that after this
>  change, I'll never know, which particular arguments are passed in
>  autoqa_args. Does not seem to be a big deal, but i kind of used it as a
>  reference of possible data i can work with inside the tests called by
>  the respective hook.
>  But i guess, that if this will be well documented in some other way,
>  then this is no problem at all.
>
>  J.
>
>  _______________________________________________
>  autoqa-devel mailing list
>  autoqa-devel(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/autoqa-devel

[PATCH] add helloworld test

[Kamil Paral]

----- "Josef Skladanka" <jskladan(a)redhat.com&gt; wrote:

>  never mind, I overlooked the documentation of possible arguments in
>  the 
>  comments at the beginning of the templates.
>  
>  Joza 
Josef reviewed the patches and agreed it should be fine to push it to
master. Therefore pushed.