----- "Vojtěch Aschenbrenner" <vaschenb(a)redhat.com> wrote:
On Wed, Jul 14, 2010 at 05:41:29PM -0400, Will Woods wrote:
> job.run_test('helloworld', config=autoqa_conf, **locals())
>
> (doing **locals() passes the contents of locals as if they had all
been
> given to the function as "var_name=var_value" pairs)
This is problem, because locals() will pass many parameters (not only
ours), output included at the end of mail (sorry for LONGLONG mail).
> Probably we want *args as well as **kwargs here, just in case.
OK, *args included now, but here is problem with this mess in
arguments
from locals().
I didn't occur to me that there will be some many local variables.
I think we one several choices:
== Temporary solutions ==
1. Leave helloworld available just for post-koji-build
2. Test the presence of all variables (defined for any hook) in
helloworld control file and pass to the job only those that are
currently available. This means more work when maintaining this test.
== Proper solutions ==
3. Pass all autoqa variables into the control file as a dictionary,
instead of a pile of variables. We have talked about this some time
ago. It will need a modification of all the test cases and some
tweaks in autoqa harness. But overall it shouldn't be such a hard
change. Vojtěch could do it easily I believe.
What do you think?