[AutoQA] #203: make rpmguard run as a post-bodhi-update test too

[fedora-badges]

#203: make rpmguard run as a post-bodhi-update test too
--------------------+-------------------------------------------------------
 Reporter:  wwoods  |       Owner:                  
     Type:  task    |      Status:  new             
 Priority:  major   |   Milestone:  Multi-hook tests
Component:  tests   |     Version:  1.0             
 Keywords:          |  
--------------------+-------------------------------------------------------
 Using the multihook capability described elsewhere, make rpmguard run for
 the post-bodhi-update hook.

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/203>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project

[fedora-badges]

#203: make rpmguard run as a post-bodhi-update test too
---------------------+------------------------------------------------------
  Reporter:  wwoods  |       Owner:                  
      Type:  task    |      Status:  new             
  Priority:  major   |   Milestone:  Multi-hook tests
 Component:  tests   |     Version:  1.0             
Resolution:          |    Keywords:                  
---------------------+------------------------------------------------------
Comment (by wwoods):

 There's a quirk here - for the post-koji-build hook, 'kojitag' will be the
 newly-applied tag. But for post-bodhi-update, 'kojitag' is the tag that is
 being ''requested''.

 list_previous_release() gives the newest package in any of the
''parent''
 repos of the repo that corresponds to the given kojitag. So when a package
 is requesting to be moved into updates-testing we'll compare it to the
 newest package in updates

 We've recently changed the behavior of koji_utils'
 list_previous_releases() method so it only returns results for the
 ''parent'' tags of the given tag. So a package requesting to be moved
into
 -updates will ''not'' be compared against the ''current''
package in
 -updates - instead it will be compared to the original version, in the
 'fedora' repo.

 This seems wrong, but at the moment I'm not sure what the Right Thing To
 Do is. Needs some thought.

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/203#comment:1>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project

[fedora-badges]

#203: make rpmguard run as a post-bodhi-update test too
---------------------+------------------------------------------------------
  Reporter:  wwoods  |       Owner:  vaschenb        
      Type:  task    |      Status:  new             
  Priority:  major   |   Milestone:  Multi-hook tests
 Component:  tests   |     Version:  1.0             
Resolution:          |    Keywords:                  
---------------------+------------------------------------------------------
Changes (by kparal):

  * owner:  => vaschenb

Comment:

 Replying to [comment:1 wwoods]:
>  There's a quirk here - for the post-koji-build hook,
> 'kojitag' will be
>  
 the newly-applied tag. But for post-bodhi-update, 'kojitag' is the tag
 that is being ''requested''.
>  
 That's perfectly fine, it's documented in hooks' READMEs.

>  list_previous_release() gives the newest package in any of the
>  
 ''parent'' repos of the repo that corresponds to the given
kojitag. So
 when a package is requesting to be moved into updates-testing we'll
 compare it to the newest package in updates
>  
 > We've recently changed the behavior of koji_utils'
 list_previous_releases() method so it only returns results for the
 ''parent'' tags of the given tag. So a package requesting to be moved
into
 -updates will ''not'' be compared against the ''current''
package in
 -updates - instead it will be compared to the original version, in the
 'fedora' repo.
>  
 No no, vice versa:

http://git.fedorahosted.org/git/?p=autoqa.git;a=commit;h=ac2bd8797565947b...

 I changed behaviour to search also the provided repo itself, not just its
 parents. So the comparison should work just fine.

 Also, in some cases rpmguard needs to search only the parent repos, e.g.
 when package is being pushed into updates-testing (rpmguard wants to
 compare against the latest ''stable'' package version). In this case I
can
 just use unstable_tags=False and everything works just fine.

>  This seems wrong, but at the moment I'm not sure what the Right
> Thing To
>  
 Do is. Needs some thought.

 I believe the problem you describe was present before my recent patch was
 accepted, but doesn't exist anymore. But I could have overlooked some use
 case?

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/203#comment:2>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project

[fedora-badges]

#203: make rpmguard run as a post-bodhi-update test too
---------------------+------------------------------------------------------
  Reporter:  wwoods  |       Owner:  vaschenb        
      Type:  task    |      Status:  closed          
  Priority:  major   |   Milestone:  Multi-hook tests
 Component:  tests   |     Version:  1.0             
Resolution:  fixed   |    Keywords:                  
---------------------+------------------------------------------------------
Changes (by vaschenb):

  * status:  new => closed
  * resolution:  => fixed

Comment:

 Created new git branch - multihook_tests, modified tests are there...

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/203#comment:3>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project

[fedora-badges]

#203: make rpmguard run as a post-bodhi-update test too
---------------------+------------------------------------------------------
  Reporter:  wwoods  |       Owner:  vaschenb        
      Type:  task    |      Status:  reopened        
  Priority:  major   |   Milestone:  Multi-hook tests
 Component:  tests   |     Version:  1.0             
Resolution:          |    Keywords:                  
---------------------+------------------------------------------------------
Changes (by kparal):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Replying to [comment:3 vaschenb]:
>  Created new git branch - multihook_tests, modified tests are
> there...
>  
 Thanks, Vojta! Just let's close this only after it's committed to master.

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/203#comment:4>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project

[fedora-badges]

#203: make rpmguard run as a post-bodhi-update test too
---------------------+------------------------------------------------------
  Reporter:  wwoods  |       Owner:  vaschenb        
      Type:  task    |      Status:  closed          
  Priority:  major   |   Milestone:  Multi-hook tests
 Component:  tests   |     Version:  1.0             
Resolution:  fixed   |    Keywords:                  
---------------------+------------------------------------------------------
Changes (by kparal):

  * status:  reopened => closed
  * resolution:  => fixed

Comment:

 This has been pushed to master (although I'll commit some more fixes
 soon).

-- 
Ticket URL: <https://fedorahosted.org/autoqa/ticket/203#comment:5>
AutoQA <http://autoqa.fedorahosted.org>
Automated QA project