On Wed, 2011-01-12 at 10:08 -0500, Kamil Paral wrote:
----- Original Message -----
> > create mode 100644 tests/anaconda_checkbot/anaconda_checkbot.py
> > create mode 100755 tests/anaconda_checkbot/checkbot.sh
> > create mode 100644 tests/anaconda_checkbot/control
> > create mode 100644 tests/anaconda_checkbot/control.autoqa
> > create mode 100644 tests/anaconda_checkbot/mock.cfg.in
>
> Since last reviewed, some minor bug fixes, and adjusted to only
> execute
> from the git-post-receive watcher. Whenever someone does a `git push`
> into upstream anaconda.git, this test will be triggered (it throttles
> at
> 10 minutes).
>
anaconda_checkbot.py:
> assert kwargs['hook'] in ['post-tree-compose',
'git-post-receive'], \
> 'Unexpected hook argument: %s' % kwargs['hook']
The 'post-tree-compose' is not mentioned in control.autoqa. Do we want
to have it there?
Before I had the 'git-post-receive' hook completed, 'post-tree-compose'
was the method used to trigger this test. While it's currently only
enabled for 'git-post-receive', I left support for this in the wrapper
for testing purposes. I thought it would be overkill to have it run for
post-tree-compose *and* git-post-receive, but I still liked having
support for post-tree-compose execution if needed.
> > create mode 100644 hooks/git-post-receive/README
> > create mode 100644 hooks/git-post-receive/autoqa-git-hook.conf
> > create mode 100755 hooks/git-post-receive/autoqa-git-hook.wsgi
> > create mode 100644 hooks/git-post-receive/hook.py
> > create mode 100755 hooks/git-post-receive/post-receive.sample
>
> This is new since the last time we reviewed the branch on the list.
> I've tried to document as much as possible ahead of time in the README
> listed above (see
>
http://git.fedorahosted.org/git/?p=autoqa.git;a=blob;f=hooks/git-post-rec...).
> Just like most everything else in the patchset, this is an addition,
> and only one new test is using this hook (see anaconda_checkbot
> below). So I'm not expecting any disruption to existing tests.
>
> I'm anxious to see this hook+test in action, but since it's beyond the
> original bill of sale for the branch, I definitely welcome discussion
> first.
autoqa-git-hook.wsgi:
>def index(environ, start_response):
> """This function will be mounted on "/"
> """
> start_response('200 OK', [('Content-Type',
'text/html')])
> return ['''Thank you, come again.''']
Could you please provide a usage description instead? I have had
a hard time finding out correct arguments.
This isn't intended for humans to run, so I didn't spend a lot of time
on human friendly responses. I also didn't want to worry about html
presentation here. Would it be okay to say something generic like ...
"Consult autoqa documentation for assistance."
and we start documenting our hooks on the wiki?
Also, can it have a dryrun option please? So that it just prints
what it would do, but does not execute anything.
Certainly, I added support for to recognize query string options
'dryrun' or 'dry-run'.
readme:
> --url: Git repository URL. The git repository must exist on one of the git
> server specified by git_servers in autoqa.conf
I don't see any changes to autoqa.conf, is this a valid comment?
It's marked elsewhere in the code with TODO's. I was waiting for the
autoqa.conf code to settle down before adding, and wasn't planning to do
this on the first drop. But it didn't seem to difficult, so I've
adjusted this in my latest fixes.
> --branch: the git branch to use (default: master)
If --branch option has a default value, it should be probably listed
amongst optional arguments, not the mandatory ones?
It is a required parameter, but does provide a default value. I can see
how that might be misleading. I've moved this into optional.
>AutoQA tests can expect the following variables from
post-koji-build hook:
Copy-n-paste typo :) ^^^^^^^^^^^^^^^
Thanks! Fixed.
>## Next, enable the post-receive hook
>$ cp /usr/share/autoqa/git-post-receive/post-receive.sample hooks/post-receive
./.git/hooks/post-receive ? ^^^^^^^^^^^^^^^^^^
>## Adjust the AutoQA WSGI configuration as needed ##
>## (/etc/httpd/conf.d/autoqa-git-hook.conf). Information on configuring WSGI
>## applications is available at
>##
http://code.google.com/p/modwsgi/wiki/ConfigurationGuidelines
Maybe we could also mention that the wsgi app can be run as a
standard python script (at least for testing purposes)?
Good point, I've added some text to address that.
All in all, I like the new hook, we will certainly have further uses
for that. Thank you.
Thank you for the review comments! I've made several corrections to the
'clumens' branch based on your feedback. Let me know what you think.
http://git.fedorahosted.org/git/?p=autoqa.git;a=commit;h=f0ca4818f73ab933...
Thanks,
James