On Fri, 2011-01-07 at 10:47 -0500, Kamil Paral wrote:
First round of review, just looking at tests/compose_tree for now.
On Monday, I'll try to actually run it :)
> control.autoqa:
> # The test can be run for post-tree-compose, or post-koji-build
> if hook != 'post-koji-build':
> execute = False
What about the post-tree-compose? An outdated comment?
Ah yes, thanks. I'll fix this in the clumens branch
> compose_tree.py:
> try:
> out = utils.system_output(cmd, retain_output=True)
> except error.CmdError, e:
> self.result = 'FAILED'
> out = e.result_obj.stdout
> else:
> self.outputs = out
Maybe 'finally' instead of 'else'?
Possibly, I was just copying from another test there. I can't see any
benefit to using else vs finally here. It seems the big difference is
how exceptions are handled . Any thoughts?
http://docs.python.org/reference/compound_stmts.html#finally
Thanks,
James