On Tue, Aug 02, 2011 at 08:26:14AM -0400, Bryan Kearney wrote:
On 08/02/2011 07:26 AM, James Bowes wrote:
>On Fri, Jul 29, 2011 at 03:37:52PM -0400, jesus m. rodriguez wrote:
>>On 07/29/2011 03:34 PM, Bryan Kearney wrote:
>>>On 07/29/2011 03:33 PM, jesus m. rodriguez wrote:
>>>>On 07/29/2011 02:22 PM, Bryan Kearney wrote:
>>>>>Today, there is one type which is allowed to do exports.. it is the
>>>>>"Candlepin" type. We have gotten the request to support
more than one
>>>>>distributor type. Anyone mind putting a boolean on that type which
is
>>>>>"is distributor", and changing the logic so that it checks
that instead
>>>>>of the type iteself?
>>>>
>>>>I'd rather change Candlepin type to Distributor (no boolean). This
>>>>would be a simple change. The drawback would mean you wouldn't be
>>>>able to be a different type and be a distributor. My hesitation to
>>>>adding the boolean is that it's only for one type, unless
there's
>>>>also plans to add more types that can be distributor.
>>>>
>>>>jesus
>>>>
>>>There would be more than one type...
>>>
>>>-- bk
>>>
>>
>>I'm ok with adding the boolean then.
>>
>
>I'd prefer to change the logic that decides if you can export to be
>written in javascript. that way we can update it along with any type
>changes (ie add a distributor type, and alter the js to allow
>distributor to also export), or even add new logic, like you can only
>export after midnight, and only if your consumer type fell in the pool.
>
So, you would prefer
if type in ["Candelpin", "SAM", "Foo", "Bar"]
-- bk
yeah
-James