Javier Palacios wrote:
I don't see the need for the explicit Fedora and CentOS breeds when they share very much in common (all now are born from Fedora and share the same structures).
What is the reason for introducing this?
Besides the particular fixing of this double *release* file, the same reasons behind the ubuntu importer. Although the three are quite similar, they have slight differences. For example, you will have no repodata on RHEL media, or can do a more specific search for some items, such as the kernel packages in match_kernelarch_file. And remove the if fedora elif redhat that exists along the code.
I don't want this. The initial reason for --breed's creation is to handle distributions that require slightly different kernel arguments.
Existing users will have --breed=redhat and will be confused when they search and find some imports tagged redhat and some fedora/centos.
These are all Red Hat rederived distributions so things can stay as is, and we can specifically handle the generic-release by ignoring it.
Also, your patch likely breaks Scientific Linux.
More than likely. To really be backwards compatible, the get_release_files from the RedHatImporter should not be touched, and the new one should be copied to the fedora and centos importers.
I'm not going to apply this, so things should stay working. I think this keeps things simple and we should not be introducing major changes to the importer at this time. A simple workaround to ignore generic-release is sufficient.
Javier Palacios _______________________________________________ cobbler mailing list cobbler@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/cobbler