Managing debian repos

[Javier Palacios]

Hello,

I send attached a couple of patches to prepare the addition of debian
repositories.

The first one is a modification to item_repo, to add a breed name to
the repo. Currently
it is just "redhat", but as fas as I see, in the mid term should be
moved to something
like ( rsync | rhn | yum | apt ).

The second one changes action_reposync, reorganizing some methods and including
a couple of classes to manage specific repo types.

I've run `make test` and tried against a real f9 updates repository
with success.

I've not started to work with real debian repos yet, but as far as I
see, now any debian
related change will be completelly isolated from redhat workflow.

Javier Palacios

[Javier Palacios]

>  The second one changes action_reposync, reorganizing some methods and
> including
>  a couple of classes to manage specific repo types. 
Please, don't apply this second patch. I've continued working creating
specific subclasses
for repo objects owning a sync method, and I've realized that most of
the changes on
second patch are actually reverted, so it will be much easier to
understand the changes
whitout it.

Javier Palacios

[Michael DeHaan]

Javier Palacios wrote:
> > The second one changes action_reposync, reorganizing some methods
> and including
> > a couple of classes to manage specific repo types.
> >     
>
>  Please, don't apply this second patch. I've continued working creating
>  specific subclasses
>  for repo objects owning a sync method, and I've realized that most of
>  the changes on
>  second patch are actually reverted, so it will be much easier to
>  understand the changes
>  whitout it.
>
>  Javier Palacios
>  _______________________________________________
>  cobbler mailing list
>  cobbler(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler
>     
Will do.

I'm very excited to see the repo additions. Thanks!

I have a few patches in queue at the moment, though will look at #1 in 
the next day or so.

--Michael

[Javier Palacios]

>  I'm very excited to see the repo additions. Thanks!
>
>  I have a few patches in queue at the moment, though will look at #1 in
>  the next day or so. 
No aditions yet but only code relocation, and bare minimum changes to
allow it to work.
Patch is against current status (drop also the old first submitted patch).
The changes should not disturb anything that currently work. I have
checked that normal
repos are synced, but I'm not been able to check with rsync repos and
that seems to fail on `make test`. I'll try to find out how to test
that if it really fails on previously working cases.

Javier Palacios

[Javier Palacios]

>  No aditions yet but only code relocation, and bare minimum changes
> to
>  allow it to work.
>  Patch is against current status (drop also the old first submitted patch). 
here is the mentioned patch, that I didn't attach the first time ....

[Javier Palacios]

Here is the second (and final?) patch to manage debian repositories.
It adds a --breed option to `create repo` that should match rsync, rhn,
yum or apt, depending on the type of repository to be created. If no
repository breed is given, it should behave exactly in the same manner
than before. I have successfully tested the "empty", yum and  apt breeds,
but not the rsync one (I'm unsure about how to test that) nor the RHN one.

Javier Palacios

[Michael DeHaan]

Javier Palacios wrote:
>  Here is the second (and final?) patch to manage debian repositories.
>  It adds a --breed option to `create repo` that should match rsync, rhn,
>  yum or apt, depending on the type of repository to be created. If no
>  repository breed is given, it should behave exactly in the same manner
>  than before. I have successfully tested the "empty", yum and  apt breeds,
>  but not the rsync one (I'm unsure about how to test that) nor the RHN one.
>
>  Javier Palacios
>    
>  ------------------------------------------------------------------------
>
>  _______________________________________________
>  cobbler mailing list
>  cobbler(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler
>     
Great, I'll take a look at this today or tomorrow.   This will be very 
nice to have.

I'm currently checking some corner cases of the import code, namely 
making sure CentOS also still is happy, etc.

Thanks!

--Michael

[Michael DeHaan]

Michael DeHaan wrote:
>  Javier Palacios wrote:
>    
> > Here is the second (and final?) patch to manage debian repositories.
> > It adds a --breed option to `create repo` that should match rsync, rhn,
> > yum or apt, depending on the type of repository to be created. If no
> > repository breed is given, it should behave exactly in the same manner
> > than before. I have successfully tested the "empty", yum and  apt breeds,
> > but not the rsync one (I'm unsure about how to test that) nor the RHN one.
> >
> > Javier Palacios
> >   
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > cobbler mailing list
> > cobbler(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/cobbler
> >   
> >     
>
>  Great, I'll take a look at this today or tomorrow.   This will be very 
>  nice to have.
>
>  I'm currently checking some corner cases of the import code, namely 
>  making sure CentOS also still is happy, etc.
>
>  Thanks!
>
>  --Michael
>
>
>  _______________________________________________
>  cobbler mailing list
>  cobbler(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler
>     
Seems to work very well. I made some small changes such that if the 
breed was "" (as it will be in upgrade scenarios) it would infer it from 
the URL and not error out.

I also did not have debmirror installed but confirmed the following 
syntax appears operational:

[root@localhost cobbler]# cobbler repo add --arch=i386 --name=foo 
--breed=apt --mirror=http://foo.example.org


[root@localhost cobbler]# cobbler reposync --only=foo
- /usr/bin/debmirror --passive --nocleanup --ignore-release-gpg 
--verbose --method=http --host=foo.example.org --root= --dist= 
/var/www/cobbler/repo_mirror/last -a i386

I've applied this. One possible extension we want to add is that when we 
edit a profile to attach repos to it:

cobbler profile edit --name=foo --repos="a b"

we make sure that the profiles are compatible with the distro.

For instance, redhat profiles allow "yum" and "rsync" and
"rhn"
Debian would allow "apt".

Either way, very cool.

I think the only other major missing piece in cobbler is that bit about 
testing whether we get import to auto-assign the trees so that installs 
from the PXE menu after a debian distro import are fully working out of 
the box.

I also think getting koan's --replace-self and --virt modes to work 
would be pretty cool, as they complete the cobbler picture.

--Michael

[Michael DeHaan]

Michael DeHaan wrote:
>  Michael DeHaan wrote:
>    
> > Javier Palacios wrote:
> >   
> >     
> >> Here is the second (and final?) patch to manage debian repositories.
> >> It adds a --breed option to `create repo` that should match rsync, rhn,
> >> yum or apt, depending on the type of repository to be created. If no
> >> repository breed is given, it should behave exactly in the same manner
> >> than before. I have successfully tested the "empty", yum and  apt
> breeds,
> >> but not the rsync one (I'm unsure about how to test that) nor the RHN one.
> >>
> >> Javier Palacios
> >>   
> >> ------------------------------------------------------------------------
> >>
> >> _______________________________________________
> >> cobbler mailing list
> >> cobbler(a)lists.fedorahosted.org
> >> https://fedorahosted.org/mailman/listinfo/cobbler
> >>   
> >>     
> >>       
> > Great, I'll take a look at this today or tomorrow.   This will be very 
> > nice to have.
> >
> > I'm currently checking some corner cases of the import code, namely 
> > making sure CentOS also still is happy, etc.
> >
> > Thanks!
> >
> > --Michael
> >
> >
> > _______________________________________________
> > cobbler mailing list
> > cobbler(a)lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/cobbler
> >   
> >     
>
>  Seems to work very well. I made some small changes such that if the 
>  breed was "" (as it will be in upgrade scenarios) it would infer it from 
>  the URL and not error out.
>
>  I also did not have debmirror installed but confirmed the following 
>  syntax appears operational:
>
>  [root@localhost cobbler]# cobbler repo add --arch=i386 --name=foo 
>  --breed=apt --mirror=http://foo.example.org
>
>
>  [root@localhost cobbler]# cobbler reposync --only=foo
>  - /usr/bin/debmirror --passive --nocleanup --ignore-release-gpg 
>  --verbose --method=http --host=foo.example.org --root= --dist= 
>  /var/www/cobbler/repo_mirror/last -a i386
>
>  I've applied this. One possible extension we want to add is that when we 
>  edit a profile to attach repos to it:
>
>  cobbler profile edit --name=foo --repos="a b"
>
>  we make sure that the profiles are compatible with the distro.
>
>  For instance, redhat profiles allow "yum" and "rsync" and
> "rhn"
>  Debian would allow "apt".
>
>  Either way, very cool.
>
>  I think the only other major missing piece in cobbler is that bit about 
>  testing whether we get import to auto-assign the trees so that installs 
>  from the PXE menu after a debian distro import are fully working out of 
>  the box.
>
>  I also think getting koan's --replace-self and --virt modes to work 
>  would be pretty cool, as they complete the cobbler picture.
>
>  --Michael
>
>
>
>
>
>
>  _______________________________________________
>  cobbler mailing list
>  cobbler(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler
>     
I should also add, changes pushed.

(Testing welcome, for folks who want to verify existing reposyncs work 
as well as the new stuff.)

--Michael