Cobbler 2.4.0 sample.seed not rendering kickstart_done snippet?

[Zack Perry]

I am testing the 2.4.0 from epel-testing using two netbooks, one as the cobbler server running SL 6.3, the other is a test install machine.  The distro is Ubuntu 12.04.1 server.

A while ago, I again used the /var/lib/cobbler/kickstarts/sample.seed to test out things, and used cobbler system getks --name=nb1 to check out the rendered preseed file.

Immediately, I noticed that $SNIPPET('kickstart_done') is not rendered, despite the fact that I have the kickstart defined in the profile, and the system report indicates the following:

Kickstart                      : <<inherit>>

The entire kickstart_done snippet seems to be ignored. Is this a known issue, or is there a hint for me to debug it?

On our production cobbler server (2.2.3), for RH alike systems, the rendering works fine.

Regards,

-- Zack

[Zack Perry]

[...]
> The entire kickstart_done snippet seems to be ignored. Is
> this a known issue, or is there a hint for me to debug it?

[...]

Yup.  I simplified the end of my copy of the sample.seed to to the following:

# This command is run just before the install finishes, but when there is
# still a usable /target directory. You can chroot to /target and use it
# directly, or use the apt-install and in-target commands to easily install
# packages and run commands in the target system.
# d-i preseed/late_command string [command]
$pxe_just_once
$kickstart
$SNIPPET('kickstart_done')

Then, a cobbler system getks --name=nb1 shows the following:

# This command is run just before the install finishes, but when there is
# still a usable /target directory. You can chroot to /target and use it
# directly, or use the apt-install and in-target commands to easily install
# packages and run commands in the target system.
# d-i preseed/late_command string [command]
1
/var/lib/cobbler/kickstarts/ubuntu-server.seed

So, I suspect that there is a bug?

Regards,

-- Zack

[Zack Perry]

I know what's going on now.  A bit of critical reading always helps:

See this:

25      ## SAVE KICKSTART
    26      #if $kickstart != ''
    27          #if $breed == 'redhat'
    28              #set saveks = "\nwget "http://%s/cblr/svc/op/ks/%s/%s%5C" -O /root/cobbler.ks" % (srv, "system", system_name)
    29          #else if $breed == 'vmware' and $os_version == 'esx4'
    30              #set saveks = "\ncurl "http://%s/cblr/svc/op/ks/%s/%s%5C" -o /root/cobbler.ks" % (srv, "system", system_name)
    31          #else if $breed == 'vmware' and $os_version == 'esxi4'
    32              #set saveks = "\nwget "http://%s/cblr/svc/op/ks/%s/%s%5C" -O /var/log/cobbler.ks" % (srv, "system", system_name)
    33          #else if $breed == 'debian'
    34              #set saveks = "wget "http://%s/cblr/svc/op/ks/%s/%s%5C" -O /target/var/log/cobbler.seed;" % (srv, "system", system_name)
    35          #end if
    36      #end if

For Ubuntu, the breed is 'ubuntu', not 'debian'.  This conditional check is insufficient :-(

I will fix it.

Regards,

-- Zack

[James Cammarata]

On Wed, Nov 14, 2012 at 6:54 PM, Zack Perry  wrote:
> I know what's going on now.  A bit of critical reading always helps:
>
> See this:
> 25      ## SAVE KICKSTART
> 26      #if $kickstart != ''
> 27          #if $breed == 'redhat'
> 28              #set saveks = "\nwget \"http://%s/cblr/svc/op/ks/%s/%s\" -O /root/cobbler.ks" % (srv, "system", system_name)
> 29          #else if $breed == 'vmware' and $os_version == 'esx4'
> 30              #set saveks = "\ncurl \"http://%s/cblr/svc/op/ks/%s/%s\" -o /root/cobbler.ks" % (srv, "system", system_name)
> 31          #else if $breed == 'vmware' and $os_version == 'esxi4'
> 32              #set saveks = "\nwget \"http://%s/cblr/svc/op/ks/%s/%s\" -O /var/log/cobbler.ks" % (srv, "system", system_name)
> 33          #else if $breed == 'debian'
> 34              #set saveks = "wget \"http://%s/cblr/svc/op/ks/%s/%s\" -O /target/var/log/cobbler.seed;" % (srv, "system", system_name)
> 35          #end if
> 36      #end if
>
> For Ubuntu, the breed is 'ubuntu', not 'debian'.  This conditional check is insufficient :-(

Yeah, this may have been part of the fixes recently, so check master.
If not, send me a pull request.

[Zack Perry]

Hi James,

You meant https://github.com/cobbler/cobbler/blob/master/snippets/kickstart_done?

Nope. Same thing. Ditto for

https://github.com/jimi1283/cobbler/blob/master/snippets/kickstart_done

Let me do some more tests this evening, and then I will send in a pull request.

Regards,

-- Zack

[...]
> Yeah, this may have been part of the fixes recently, so
> check master.
> If not, send me a pull request.