contents of post_install_network_config in devel

[Andy Gospodarek]

I was looking over the contents of post_install_network_config in the
devel branch of cobbler and it looks pretty good.  The idea that one
wants to setup VLANs or bonding as part of the post-install process is a
good one.

Anyway, there are a few changes that I'd propose though for RHEL/Centos5
and Fedora and several that would be needed to make RHEL/Centos4 work
correctly.

For RHEL/Centos5 and Fedora the bonding parameter 'max_bonds' in
modprobe.conf isn't really needed, so it can be dropped.

--- a/snippets/post_install_network_config
+++ b/snippets/post_install_network_config
@@ -48,16 +48,6 @@
     ## end looping through the interfaces to see which ones we need to configure.
 
     ## =============================================================================
-
-    #set $i = 0
-    
-    ## setup bonding if we have to
-
-    #if $numbondingdevs > 0
-        echo "options bonding max_bonds=$numbondingdevs" >>
         /etc/modprobe.conf
-    #end if
-    
-    ## =============================================================================
     
     ## create a staging directory to build out our network scripts into
     ## make sure we preserve the loopback device


For RHEL/Centos4 the bonding options will need to be placed in
/etc/modprobe.conf rather than in ifcfg-bondX files.

--- a/snippets/post_install_network_config
+++ b/snippets/post_install_network_config
@@ -189,9 +179,7 @@
 
             #if $bonding.lower() == "master" and $bonding_opts != ""
                 ## configure bonding if required
-                cat >> $devfile << EOF
-                BONDING_OPTS="$bonding_opts"
-                EOF
+                echo "options $iname $bonding_opts" >>
/etc/modprobe.conf.cobbler
             #end if
 
             echo "ONPARENT=yes" >> $devfile

In general the VLAN stuff looks good too, but it would be hard to know
for sure without testing it pretty well.

Long term it would be great to support VLANs on bonded interfaces, but
there are not a bunch of people doing that right now (and I didn't write
any patches, so I should probably shutup :), so it's probably not a
priority.

-andy

[Jasper Capel]

Andy Gospodarek wrote:
>  I was looking over the contents of post_install_network_config in
> the
>  devel branch of cobbler and it looks pretty good.  The idea that one
>  wants to setup VLANs or bonding as part of the post-install process is a
>  good one.
>  
>  Anyway, there are a few changes that I'd propose though for RHEL/Centos5
>  and Fedora and several that would be needed to make RHEL/Centos4 work
>  correctly.
>  
>  For RHEL/Centos5 and Fedora the bonding parameter 'max_bonds' in
>  modprobe.conf isn't really needed, so it can be dropped. 
*snip*

These changes look good to me, thanks for the feedback. :)
>  
>  In general the VLAN stuff looks good too, but it would be hard to know
>  for sure without testing it pretty well.
>  
>  Long term it would be great to support VLANs on bonded interfaces, but
>  there are not a bunch of people doing that right now (and I didn't write
>  any patches, so I should probably shutup :), so it's probably not a
>  priority.
>   
I'm not exactly sure what you mean here, it was always my intention to 
support VLANs on bonding devices (and by request, also bonding several 
VLAN devices together).
Creating a device named bond0.10 should add VLAN 10 to bond0. If this 
stopped working, that's a defect. ;)

Jasper

[Andy Gospodarek]

On Wed, Dec 10, 2008 at 09:51:11AM +0100, Jasper Capel wrote:
>  Andy Gospodarek wrote:
>  > I was looking over the contents of post_install_network_config in the
>  > devel branch of cobbler and it looks pretty good.  The idea that one
>  > wants to setup VLANs or bonding as part of the post-install process is a
>  > good one.
>  > 
>  > Anyway, there are a few changes that I'd propose though for RHEL/Centos5
>  > and Fedora and several that would be needed to make RHEL/Centos4 work
>  > correctly.
>  > 
>  > For RHEL/Centos5 and Fedora the bonding parameter 'max_bonds' in
>  > modprobe.conf isn't really needed, so it can be dropped.
>  *snip*
>  
>  These changes look good to me, thanks for the feedback. :)
>  > 
>  > In general the VLAN stuff looks good too, but it would be hard to know
>  > for sure without testing it pretty well.
>  > 
>  > Long term it would be great to support VLANs on bonded interfaces, but
>  > there are not a bunch of people doing that right now (and I didn't write
>  > any patches, so I should probably shutup :), so it's probably not a
>  > priority.
>  > 
>  
>  I'm not exactly sure what you mean here, it was always my intention to 
>  support VLANs on bonding devices (and by request, also bonding several 
>  VLAN devices together).
>  Creating a device named bond0.10 should add VLAN 10 to bond0. If this 
>  stopped working, that's a defect. ;)
>   
I actually haven't tested it yet, but I would have been surprised from
the code flow that it worked.  I actually went back and looked again and
as long as bond0 is created before bond0.10 it looks like it should be
fine.  Hopefully I'll get a chance to give this a try soon to know for
sure.

[Michael DeHaan]

Jasper Capel wrote:
>  Andy Gospodarek wrote:
>    
> > I was looking over the contents of post_install_network_config in the
> > devel branch of cobbler and it looks pretty good.  The idea that one
> > wants to setup VLANs or bonding as part of the post-install process is a
> > good one.
> >
> > Anyway, there are a few changes that I'd propose though for RHEL/Centos5
> > and Fedora and several that would be needed to make RHEL/Centos4 work
> > correctly.
> >
> > For RHEL/Centos5 and Fedora the bonding parameter 'max_bonds' in
> > modprobe.conf isn't really needed, so it can be dropped.
> >     
>  *snip*
>
>  These changes look good to me, thanks for the feedback. :)
>    
> > In general the VLAN stuff looks good too, but it would be hard to know
> > for sure without testing it pretty well.
> >
> > Long term it would be great to support VLANs on bonded interfaces, but
> > there are not a bunch of people doing that right now (and I didn't write
> > any patches, so I should probably shutup :), so it's probably not a
> > priority.
> >
> >     
>
>  I'm not exactly sure what you mean here, it was always my intention to 
>  support VLANs on bonding devices (and by request, also bonding several 
>  VLAN devices together).
>  Creating a device named bond0.10 should add VLAN 10 to bond0. If this 
>  stopped working, that's a defect. ;)
>
>  Jasper
>  _______________________________________________
>  cobbler mailing list
>  cobbler(a)lists.fedorahosted.org
>  https://fedorahosted.org/mailman/listinfo/cobbler
>     
Just to let everyone know of test plans, things seem to be working well, 
though I'm going to be doing a fair amount of testing on physical 
machines starting Thursday.

I encountered some network problems (unrelated) on F9/libvirt with 
virtio and/or NetworkManager-enabled-Anaconda yesterday and need to do 
some more extensive probing on that.  Physical installs worked fine 
though I am due for some testing on machines with multiple NICs.

The output from the kickstarts looks good to me.

I will updating the cobbler/koan test RPM today as I likely want to 
spend another week looking this and everything else over.   I should 
stop promising dates though this looks like it means 12/19 (or a bit 
earlier) for 1.4

Everyone can help move that 1.4 release up by helping test the test 
release (using the new sample kickstart files as well as your own, and 
also making sure there are no regressions) when I push out the new test 
release RPM.

Thanks!

--Michael