[freeipa PR#2152][opened] Teach pylint how our api works
by tiran
URL: https://github.com/freeipa/freeipa/pull/2152
Author: tiran
Title: #2152: Teach pylint how our api works
Action: opened
PR body:
"""
pylint 2.0 is more strict and complains about several aspects of
ipalib.api. It turns out that AstroidBuilder.string_build() can be used
to easily teach pylint about object attributes and attribute values.
Although the assignment wouldn't work with the actual implementation,
the string builder assignments shows pylint the names and values of
members. It works without additional transformation.
See: pagure.io/freeipa/issue/7614
Signed-off-by: Christian Heimes <cheimes(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2152/head:pr2152
git checkout pr2152
5 years, 11 months
[freeipa PR#2146][opened] [Backport][ipa-4-5] Handle races in replica config
by tiran
URL: https://github.com/freeipa/freeipa/pull/2146
Author: tiran
Title: #2146: [Backport][ipa-4-5] Handle races in replica config
Action: opened
PR body:
"""
Manual backport of PR #2132 to 4.5 branch
When multiple replicas are installed in parallel, two replicas may try
to create the cn=replica entry at the same time. This leads to a
conflict on one of the replicas. replica_config() and
ensure_replication_managers() now handle conflicts.
ipaldap now maps TYPE_OR_VALUE_EXISTS to DuplicateEntry(). The type or
value exists exception is raised, when an attribute value or type is
already set.
Fixes: https://pagure.io/freeipa/issue/7566
Signed-off-by: Christian Heimes <cheimes(a)redhat.com>
Reviewed-By: Thierry Bordaz <tbordaz(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2146/head:pr2146
git checkout pr2146
5 years, 11 months
[freeipa PR#2060][opened] WebUI build update: use NodeJS instead of Rhino, use system UglifyJS, update Dojo
by pvoborni
URL: https://github.com/freeipa/freeipa/pull/2060
Author: pvoborni
Title: #2060: WebUI build update: use NodeJS instead of Rhino, use system UglifyJS, update Dojo
Action: opened
PR body:
"""
## WebUI build: replace uglifyjs with system package
UgligyJS is packaged in Fedora and other OSes it is no longer required
to carry our own version. This will lower the maintenance burden - the
code doesn't need to be updated and it is less code to have in repo.
On some configuration usage of the bundled UglifyJS 1 produces
"JavaScript throw: java.lang.StackOverflowError" exception. Usage of more
recent version should fix it.
## WebUI build: use NodeJS instead of Rhino
Rhino is no longer mainstream, nor is Nashorn. In addition it is quite
slow (about 10x) in comparison to NodeJS. Over the years NodeJS became
common part of OSes, thus one of the original reasons why use Rhino
went away.
The change in 01-Make-dojo-builder-buildable-by-itself.patch fixes
an incorrect change of the patch (it was not processing input options
well).
Removing configRhino.js and adding configNode.js are prerequisites
for Dojo Builder. These files are copied from Dojo project. Without
them it doesn̈́'t run. In long run, it would be good to replace Dojo
builder with something else but that is outside of this commit/PR.
Last changes are preparation for update to latest stable version of
Dojo 1. The updated Dojo and Dojo builder are in subsequent commit.
## Update Dojo and Dojo builder to 1.13.0
This is a result of the previous commits. Building the Dojo builder
was bit more complex as it was:
1. patched Dojo sources
2. built from Dojo builder sources.
3. moved to it's location in FreeIPA project
4. built by util/make-builder.sh (does minimazation and replaces
itself)
Then Dojo layer is built by just:
1. util/make-dojo.sh
This process was documented some time ago at:
https://www.freeipa.org/page/V3/WebUI_build
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2060/head:pr2060
git checkout pr2060
5 years, 11 months
[freeipa PR#2141][opened] Fix pylint 2.0 conditional-related violations
by netoarmando
URL: https://github.com/freeipa/freeipa/pull/2141
Author: netoarmando
Title: #2141: Fix pylint 2.0 conditional-related violations
Action: opened
PR body:
"""
In order to support pylint 2.0 the following violations must be fixed:
- `chained-comparison` (R1716):
Simplify chained comparison between the operands This message is
emitted when pylint encounters boolean operation like
"a < b and b < c", suggesting instead to refactor it to "a < b < c".
- `consider-using-in` (R1714):
Consider merging these comparisons with "in" to %r To check if a
variable is equal to one of many values,combine the values into a
tuple and check if the variable is contained "in" it instead of
checking for equality against each of the values.This is faster
and less verbose.
Issue: https://pagure.io/freeipa/issue/7614
Signed-off-by: Armando Neto <abiagion(a)redhat.com>
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2141/head:pr2141
git checkout pr2141
5 years, 11 months