[Freeipa-devel] [freeipa PR#1640][opened] Return a value if exceptions are raised in server uninstall

[rcritten]

   URL: https://github.com/freeipa/freeipa/pull/1640
Author: rcritten
 Title: #1640: Return a value if exceptions are raised in server uninstall
Action: opened

PR body:
"""
The server uninstall relies on the Continuous class which will
not re-raise exceptions, only log them.

The AdminTool class purports to "call sys.exit() with the return
value" but most of the run implementations returned no value, or
the methods they called returned nothing so there was nothing to
return, so this was a no-op.

The fix is to capture and bubble up the return values and to
return 1 if any exceptions are caught in Continuous, the exception
being SystemExit which is what is raised when sys.exit() is called.

This potentially affects other users in that when executing the
steps of an installer or uninstaller the highest return code
will be the exit value of that installer.

https://pagure.io/freeipa/issue/7330

Signed-off-by: Rob Crittenden <rcritten(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/1640/head:pr1640
git checkout pr1640