[Freeipa-devel] [freeipa PR#5209][opened] [Backport][ipa-4-8] ipa-kdb: support subordinate/superior UPN suffixes

[abbra]

   URL: https://github.com/freeipa/freeipa/pull/5209
Author: abbra
 Title: #5209: [Backport][ipa-4-8] ipa-kdb: support subordinate/superior UPN suffixes
Action: opened

PR body:
"""
[MS-ADTS] 6.1.6.9.3.2 requires msDS-TrustForestTrustInfo attribute of
trusted domain information in Active Directory to conform certain rules.
One side-effect of those rules is that list of UPN suffixes reported
through the netr_DsRGetForestTrustInformation function is dynamically
filtered to deduplicate subordinate suffixes.

It means that if list of UPN suffixes contains the following top level
names (TLNs):

  fabrikam.com
  sub.fabrikam.com

then netr_DsRGetForestTrustInformation would only return 'fabrikam.com'
as the TLN, fully filtering 'sub.fabrikam.com'.

IPA KDB driver used exact comparison of the UPN suffixes so any
subordinate had to be specified exactly.

Modify logic so that if exact check does not succeed, we validate a
realm to test being a subordinate of the known UPN suffixes. The
subordinate check is done by making sure UPN suffix is at the end of the
test realm and is immediately preceded with a dot.

Because the function to check suffixes potentially called for every
Kerberos principal, precalculate and cache length for each UPN suffix at
the time we retrieve the list of them.

Fixes: https://pagure.io/freeipa/issue/8554

Signed-off-by: Alexander Bokovoy <abokovoy(a)redhat.com&gt;
Reviewed-By: Rob Crittenden <rcritten(a)redhat.com&gt;
Reviewed-By: Robbie Harwood <rharwood(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/5209/head:pr5209
git checkout pr5209