[Freeipa-devel] [freeipa PR#3084][opened] ipactl restart: fix wrong logic when checking service list

[flo-renaud]

   URL: https://github.com/freeipa/freeipa/pull/3084
Author: flo-renaud
 Title: #3084: ipactl restart: fix wrong logic when checking service list
Action: opened

PR body:
"""
ipactl is building a list of currently running services from
the content of /var/run/ipa/services.list, and a list of expected services
from the services configured in LDAP.

Because CA and KRA both correspond to the same pki-tomcatd service, the
lists may contain duplicates. The code handling these duplicates is called
at the wrong place, and may result in a wrong list of services to
stop / restart / start.
The fix removes the duplicates before returning the lists, hence making sure
that there is no error when building the list of services to stop / restart
/ start.

Fixes: https://pagure.io/freeipa/issue/7927
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/3084/head:pr3084
git checkout pr3084