[Freeipa-devel] [freeipa PR#4895][opened] Simplify and make more reliable the server and client installation checks

[rcritten]

   URL: https://github.com/freeipa/freeipa/pull/4895
Author: rcritten
 Title: #4895: Simplify and make more reliable the server and client installation checks
Action: opened

PR body:
"""
Rather than relying on file existence and whether the installer backed up files actually
set a value when the installation is complete for the client and server and use that.

For the server this can be reliable moving forward because we can detect the missing state
and fix it on upgrades. On the client we're stuck so use it but leave the old method
as a fallback. Also remove the requirement to pass in the filestore to the client check as
that makes it more complex as a fact.

Both can be checked fairly easily with:
```
python -c 'from ipaclient.install.client import is_ipa_client_installed; print
("%s" % is_ipa_client_installed())'
python -c 'from ipaserver.install.installutils import is_ipa_configured;
print("%s" % is_ipa_configured())'
```
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/4895/head:pr4895
git checkout pr4895