[Freeipa-devel] [freeipa PR#2120][opened] Fix race condition in get_locations_records()

[tiran]

   URL: https://github.com/freeipa/freeipa/pull/2120
Author: tiran
 Title: #2120: Fix race condition in get_locations_records()
Action: opened

PR body:
"""
The method IPASystemRecords.get_locations_records() has a race condition.
The IPASystemRecords object creates a mapping of server names to server
data. get_locations_records() uses server_find() again to get a list of
servers, but then operates on the cached dict of server names.

In parallel replication case, the second server_find() call in
get_locations_records() can return additional servers. Since the rest of
the code operates on the cached data, the method then fails with a KeyError.

server_data is now an OrderedDict to keep same sorting as with
server_find().

Fixes: https://pagure.io/freeipa/issue/7566
Signed-off-by: Christian Heimes <cheimes(a)redhat.com&gt;
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/2120/head:pr2120
git checkout pr2120