[Freeipa-devel] Re: [PATCH] Fix UnboundLocalError in ipa-replica-manage

[Rob Crittenden]

Theodor van Nahl via FreeIPA-devel wrote:
>  If ipa-replica-manage is unable to retrieve e.g. due to certificate
>  validity problem. An UnboundLocalError is thrown for `type1`. This fixes
>  the issue with a clean exit.
>  ---
>   install/tools/ipa-replica-manage.in | 1 +
>   1 file changed, 1 insertion(+)
>  
>  diff --git a/install/tools/ipa-replica-manage.in b/install/tools/ipa-replica-manage.in
>  index a276239fb..f4e949407 100644
>  --- a/install/tools/ipa-replica-manage.in
>  +++ b/install/tools/ipa-replica-manage.in
>  @@ -279,6 +279,7 @@ def del_link(realm, replica1, replica2, dirman_passwd, force=False):
>           return False
>       except Exception as e:
>           print("Failed to determine agreement type for '%s': %s" %
> (replica2, e))
>  +        return False
>   
>       if type1 == replication.IPA_REPLICA and managed_topology:
>           exit_on_managed_topology(what)
>   
Thanks for the patch. I submitted it upstream in your name as
https://github.com/freeipa/freeipa/pull/3501

rob